Skip to contentSkip to conversation

Patch "iwlwifi: dvm: fix WoWLAN" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iwlwifi: dvm: fix WoWLAN

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iwlwifi-dvm-fix-wowlan.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From a1cdb1c59c8c203de2731fc6910598ed19c97e41 Mon Sep 17 00:00:00 2001

From: Emmanuel Grumbach <[email protected]>
Date: Sun, 20 Dec 2015 08:45:40 +0200
Subject: iwlwifi: dvm: fix WoWLAN

From: Emmanuel Grumbach <[email protected]>

commit a1cdb1c59c8c203de2731fc6910598ed19c97e41 upstream.

My commit below introduced a mutex in the transport to prevent concurrent operations. To do so, it added a flag (is_down) to make sure the transport is in the right state. This uncoverred an bug that didn't cause any harm until
now: iwldvm calls stop_device and then starts the firmware without calling start_hw in between. While this flow is fine from the device configuration point of view (register, etc...), it is now forbidden by the new is_down flag.
This led to this error to appear:
iwlwifi 0000:05:00.0: Can't start_fw since the HW hasn't been started and the suspend would fail.

This fixes:
https://bugzilla.kernel.org/show_bug.cgi?id=109591

Fixes=fa9f3281cbb1 ("iwlwifi: pcie: lock start_hw / start_fw / stop_device")

---
 drivers/net/wireless/iwlwifi/dvm/lib.c |    3 +++
 1 file changed, 3 insertions(+)
drivers/net/wireless/iwlwifi/dvm/lib.c +3 -0
@@ -1154,6 +1154,9 @@ int iwlagn_suspend(struct iwl_priv *priv
 
 	priv->ucode_loaded = false;
 	iwl_trans_stop_device(priv->trans);
+	ret = iwl_trans_start_hw(priv->trans);
+	if (ret)
+		goto out;
 
 	priv->wowlan = true;
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iwlwifi-mvm-don-t-allow-sched-scans-without-matches-to-be-started.patch queue-4.4/iwlwifi-update-and-fix-7265-series-pci-ids.patch queue-4.4/iwlwifi-dvm-fix-wowlan.patch queue-4.4/iwlwifi-pcie-properly-configure-the-debug-buffer-size-for-8000.patch