Skip to contentSkip to conversation

gcc-runtime.inc: disable libitm for little endian MIPS too

PATCH In review Andre McCurdy 3 participants 4 messages Mar 3, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gcc-runtime.inc: disable libitm for little endian MIPS too

libitm is already disabled for big endian MIPS, but needs to be disabled for little endian MIPS targets too.

---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/gcc/gcc-runtime.inc +2 -0
index 707db37..1c3dd54 100644
@@ -12,7 +12,9 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu"
 
 RUNTIMELIBITM = "libitm"
 RUNTIMELIBITM_mips = ""
+RUNTIMELIBITM_mipsel = ""
 RUNTIMELIBITM_mips64 = ""
+RUNTIMELIBITM_mips64el = ""
 
 RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
     ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \
Signature · 1 line
1.9.1
#1 lore raw
Quoted 2 lines · Andre McCurdy

libitm is already disabled for big endian MIPS, but needs to be disabled for little endian MIPS targets too.

No objection to the patch, but do we have any little endian MIPS currently defined or buildable to test?

All of the samples I've seen are all big endian these days. (QEMU or actual boards.)

--Mark

Quoted 20 lines
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/gcc/gcc-runtime.inc +2 -0
index 707db37..1c3dd54 100644
@@ -12,7 +12,9 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu"
 
 RUNTIMELIBITM = "libitm"
 RUNTIMELIBITM_mips = ""
+RUNTIMELIBITM_mipsel = ""
 RUNTIMELIBITM_mips64 = ""
+RUNTIMELIBITM_mips64el = ""
 
 RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
     ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \
#2 lore raw
Quoted 7 lines · Mark Hatle
Quoted 2 lines · Andre McCurdy

libitm is already disabled for big endian MIPS, but needs to be disabled for little endian MIPS targets too.

No objection to the patch, but do we have any little endian MIPS currently defined or buildable to test?

most of mips based set-top boxes are mipsel.

Quoted 31 lines

All of the samples I've seen are all big endian these days. (QEMU or actual boards.)

--Mark

Quoted 11 lines
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/gcc/gcc-runtime.inc +0 -0
index 707db37..1c3dd54 100644

meta/recipes-devtools/gcc/gcc-runtime.inc EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu" · line 20

Quoted 9 lines
meta/recipes-devtools/gcc/gcc-runtime.inc +2 -0
@@ -12,7 +12,9 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu"
 
 RUNTIMELIBITM = "libitm"
 RUNTIMELIBITM_mips = ""
+RUNTIMELIBITM_mipsel = ""
 RUNTIMELIBITM_mips64 = ""
+RUNTIMELIBITM_mips64el = ""
 
 RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
     ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

#3 lore raw
Quoted 12 lines · Khem Raj
Quoted 6 lines · Mark Hatle
Quoted 2 lines · Andre McCurdy

libitm is already disabled for big endian MIPS, but needs to be disabled for little endian MIPS targets too.

No objection to the patch, but do we have any little endian MIPS currently defined or buildable to test?

most of mips based set-top boxes are mipsel.

Quoted 2 lines

All of the samples I've seen are all big endian these days. (QEMU or actual boards.)

Of the MIPS boards supported by OpenWRT, there seem to be an even mixture of big and little endian:

https://dev.openwrt.org/wiki/platforms

I don't know how many (if any) of these boards are supported by OE though...

Quoted 33 lines
Quoted 19 lines

--Mark

Quoted 17 lines
---
 meta/recipes-devtools/gcc/gcc-runtime.inc | 2 ++
 1 file changed, 2 insertions(+)
meta/recipes-devtools/gcc/gcc-runtime.inc +2 -0
index 707db37..1c3dd54 100644
@@ -12,7 +12,9 @@ EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu"
 
 RUNTIMELIBITM = "libitm"
 RUNTIMELIBITM_mips = ""
+RUNTIMELIBITM_mipsel = ""
 RUNTIMELIBITM_mips64 = ""
+RUNTIMELIBITM_mips64el = ""
 
Quoted 9 lines

meta/recipes-devtools/gcc/gcc-runtime.inc EXTRA_OECONF_append_linuxstdbase = " --enable-clocale=gnu" · line 20

Quoted 3 lines
meta/recipes-devtools/gcc/gcc-runtime.inc +0 -0
 RUNTIMETARGET = "libssp libstdc++-v3 libgomp libatomic ${RUNTIMELIBITM} \
     ${@bb.utils.contains_any('FORTRAN', [',fortran',',f77'], 'libquadmath', '', d)} \

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core