Skip to contentSkip to conversation

ext-sdk-prepare: Catch setscene tasks which should have run but didn't

PATCH New Richard Purdie 1 participant 1 message Mar 4, 2016

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ext-sdk-prepare: Catch setscene tasks which should have run but didn't

When installing the eSDK, if setscene task fail for some reason, the tests would ignore this. This is bad since we assume they're working.

This adds some sanity test code which detects if setscene tasks are needing to run and errors if there are any.

meta/files/ext-sdk-prepare.py +3 -1
index 143e0fe..c99e34f 100644
@@ -72,12 +72,14 @@ def main():
                 else:
                     line = line.split('Running', 1)[-1]
                     unexpected.append(line.rstrip())
+            elif 'Running setscene' in line:
+                unexpected.append(line.rstrip())
     except subprocess.CalledProcessError as e:
         print('ERROR: Failed to execute dry-run:\n%s' % e.output)
         return 1
 
     if unexpected:
-        print('ERROR: Unexpected tasks left over to be executed:')
+        print('ERROR: Unexpected tasks or setscene left over to be executed:')
         for line in unexpected:
             print('  ' + line)
         return 1