Skip to contentSkip to conversation

arch/microblaze: export isa_io_base to modules

PATCH In review Nicolai Stange 2 participants 2 messages Mar 7, 2016 Microblaze architecture

lore
Share & tools
lore

Nicolai Stange

author
#0 lore raw

PATCH 1/1 arch/microblaze: export isa_io_base to modules

As discovered by the kbuild test robot, an allmodconfig build on microblaze bails out with

ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined! [... plus dozens more throughout the tree]

Export isa_io_base to modules by means of EXPORT_SYMBOL().

Signed-off-by Nicolai Stange <[email protected]>
---
 arch/microblaze/pci/pci-common.c | 2 ++
 1 file changed, 2 insertions(+)
arch/microblaze/pci/pci-common.c +2 -0
index ae838ed..fba7a46 100644
@@ -48,6 +48,8 @@ static int global_phb_number;		/* Global phb counter */
 resource_size_t isa_mem_base;
 
 unsigned long isa_io_base;
+EXPORT_SYMBOL(isa_io_base);
+
 static int pci_bus_count;
 
 struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
Signature · 1 line
2.7.2
Acked-by on v1 1/1
#1 lore raw
Quoted 10 lines · Nicolai Stange

As discovered by the kbuild test robot, an allmodconfig build on microblaze bails out with

ERROR: "isa_io_base" [sound/pci/vx222/snd-vx222.ko] undefined!
ERROR: "isa_io_base" [sound/pci/trident/snd-trident.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-via82xx-modem.ko] undefined!
ERROR: "isa_io_base" [sound/pci/snd-sonicvibes.ko] undefined! [... plus dozens more throughout the tree]

Quoted 3 lines

Export isa_io_base to modules by means of EXPORT_SYMBOL().

Signed-off-by Nicolai Stange <[email protected]>
Acked-by Bjorn Helgaas <[email protected]>

Michal, this was sent to you, so I assume you'll handle it. Let me know if you want me to do anything else with it.

Quoted 20 lines
---
 arch/microblaze/pci/pci-common.c | 2 ++
 1 file changed, 2 insertions(+)
arch/microblaze/pci/pci-common.c +2 -0
index ae838ed..fba7a46 100644
@@ -48,6 +48,8 @@ static int global_phb_number;		/* Global phb counter */
 resource_size_t isa_mem_base;
 
 unsigned long isa_io_base;
+EXPORT_SYMBOL(isa_io_base);
+
 static int pci_bus_count;
 
 struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
Signature · 1 line
2.7.2