Skip to contentSkip to conversation

drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.

PATCH In review Maarten Lankhorst 3 participants 5 messages Mar 9, 2016 – Mar 15, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.

fb_bits is useful to have in the crtc_state for cs flips when the code is updated to use intel_frontbuffer_flip_prepare/complete. So calculate it in advance and move it to crtc_state. The other stuff can be calculated in post_plane_update, and aren't useful elsewhere.

Changes since v1:
- Changing wording, remove comment about loop.
Changes since v2:
- Rebase.

---
 drivers/gpu/drm/i915/intel_atomic.c  |  1 +
 drivers/gpu/drm/i915/intel_display.c | 29 +++++++++++++++++++++--------
 drivers/gpu/drm/i915/intel_drv.h     |  5 +----
 3 files changed, 23 insertions(+), 12 deletions(-)
drivers/gpu/drm/i915/intel_atomic.c +1 -0
index 6a661e796328..e23e1ec6df89 100644
@@ -99,6 +99,7 @@ intel_crtc_duplicate_state(struct drm_crtc *crtc)
 	crtc_state->wm_changed = false;
 	crtc_state->fb_changed = false;
 	crtc_state->wm.need_postvbl_update = false;
+	crtc_state->fb_bits = 0;
 
 	return &crtc_state->base;
 }
drivers/gpu/drm/i915/intel_display.c +21 -8
index 62d36a7b3398..2d31755608ce 100644
@@ -4908,14 +4908,20 @@ intel_pre_disable_primary(struct drm_crtc *crtc)
 	hsw_disable_ips(intel_crtc);
 }
 
-static void intel_post_plane_update(struct intel_crtc *crtc)
+static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
 {
+	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
+	struct drm_atomic_state *old_state = old_crtc_state->base.state;
 	struct intel_crtc_atomic_commit *atomic = &crtc->atomic;
 	struct intel_crtc_state *pipe_config =
 		to_intel_crtc_state(crtc->base.state);
 	struct drm_device *dev = crtc->base.dev;
+	struct drm_i915_private *dev_priv = dev->dev_private;
+	struct drm_plane *primary = crtc->base.primary;
+	struct drm_plane_state *old_pri_state =
+		drm_atomic_get_existing_plane_state(old_state, primary);
 
-	intel_frontbuffer_flip(dev, atomic->fb_bits);
+	intel_frontbuffer_flip(dev, pipe_config->fb_bits);
 
 	crtc->wm.cxsr_allowed = true;
 
@@ -4925,8 +4931,17 @@ static void intel_post_plane_update(struct intel_crtc *crtc)
 	if (atomic->update_fbc)
 		intel_fbc_post_update(crtc);
 
-	if (atomic->post_enable_primary)
-		intel_post_enable_primary(&crtc->base);
+	if (old_pri_state) {
+		struct intel_plane_state *primary_state =
+			to_intel_plane_state(primary->state);
+		struct intel_plane_state *old_primary_state =
+			to_intel_plane_state(old_pri_state);
+
+		if (primary_state->visible &&
+		    (needs_modeset(&pipe_config->base) ||
+		     !old_primary_state->visible))
+			intel_post_enable_primary(&crtc->base);
+	}
 
 	memset(atomic, 0, sizeof(*atomic));
 }
@@ -12010,12 +12025,10 @@ int intel_plane_atomic_calc_changes(struct drm_crtc_state *crtc_state,
 		to_intel_crtc_state(crtc_state)->wm.need_postvbl_update = true;
 
 	if (visible || was_visible)
-		intel_crtc->atomic.fb_bits |=
-			to_intel_plane(plane)->frontbuffer_bit;
+		pipe_config->fb_bits |= to_intel_plane(plane)->frontbuffer_bit;
 
 	switch (plane->type) {
 	case DRM_PLANE_TYPE_PRIMARY:
-		intel_crtc->atomic.post_enable_primary = turn_on;
 		intel_crtc->atomic.update_fbc = true;
 
 		break;
@@ -13790,7 +13803,7 @@ static int intel_atomic_commit(struct drm_device *dev,
 		intel_atomic_wait_for_vblanks(dev, dev_priv, crtc_vblank_mask);
 
 	for_each_crtc_in_state(state, crtc, crtc_state, i) {
-		intel_post_plane_update(to_intel_crtc(crtc));
+		intel_post_plane_update(to_intel_crtc_state(crtc_state));
 
 		if (put_domains[i])
 			modeset_put_power_domains(dev_priv, put_domains[i]);
drivers/gpu/drm/i915/intel_drv.h +1 -4
index 7b2d66d8dd7f..6385dbb01ace 100644
@@ -418,6 +418,7 @@ struct intel_crtc_state {
 #define PIPE_CONFIG_QUIRK_MODE_SYNC_FLAGS	(1<<0) /* unreliable sync mode.flags */
 	unsigned long quirks;
 
+	unsigned fb_bits; /* framebuffers to flip */
 	bool update_pipe; /* can a fast modeset be performed? */
 	bool disable_cxsr;
 	bool wm_changed; /* watermarks are updated */
@@ -605,10 +606,6 @@ struct intel_crtc_atomic_commit {
 	/* Sleepable operations to perform before commit */
 
 	/* Sleepable operations to perform after commit */
-	unsigned fb_bits;
-	bool post_enable_primary;
-
-	/* Sleepable operations to perform before and after commit */
 	bool update_fbc;
 };
 
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

PATCH 2/2 drm/i915: Nuke fbc members from intel_crtc->atomic, v4.

Whenever there's an update to the primary plane, fbc_pre_update and fbc_post_update are called. Kill off intel_crtc->atomic.update_fbc and now that intel_crtc->atomic is empty, kill it off too.

Changes since v1:
- Add a intel_fbc_supports_rotation helper.
Changes since v2:
- Remove intel_fbc_supports_rotation_helper.
- Remove unrelated changes.
Changes since v3:
- Rebase

---
 drivers/gpu/drm/i915/intel_display.c | 51 +++++++++++-------------------------
 drivers/gpu/drm/i915/intel_drv.h     | 15 -----------
 2 files changed, 16 insertions(+), 50 deletions(-)
drivers/gpu/drm/i915/intel_display.c +16 -35
index 2d31755608ce..6e6d8b342517 100644
@@ -4912,11 +4912,9 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
 {
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
 	struct drm_atomic_state *old_state = old_crtc_state->base.state;
-	struct intel_crtc_atomic_commit *atomic = &crtc->atomic;
 	struct intel_crtc_state *pipe_config =
 		to_intel_crtc_state(crtc->base.state);
 	struct drm_device *dev = crtc->base.dev;
-	struct drm_i915_private *dev_priv = dev->dev_private;
 	struct drm_plane *primary = crtc->base.primary;
 	struct drm_plane_state *old_pri_state =
 		drm_atomic_get_existing_plane_state(old_state, primary);
@@ -4928,22 +4926,19 @@ static void intel_post_plane_update(struct intel_crtc_state *old_crtc_state)
 	if (pipe_config->wm_changed && pipe_config->base.active)
 		intel_update_watermarks(&crtc->base);
 
-	if (atomic->update_fbc)
-		intel_fbc_post_update(crtc);
-
 	if (old_pri_state) {
 		struct intel_plane_state *primary_state =
 			to_intel_plane_state(primary->state);
 		struct intel_plane_state *old_primary_state =
 			to_intel_plane_state(old_pri_state);
 
+		intel_fbc_post_update(crtc);
+
 		if (primary_state->visible &&
 		    (needs_modeset(&pipe_config->base) ||
 		     !old_primary_state->visible))
 			intel_post_enable_primary(&crtc->base);
 	}
-
-	memset(atomic, 0, sizeof(*atomic));
 }
 
 static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state)
@@ -4951,7 +4946,6 @@ static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state)
 	struct intel_crtc *crtc = to_intel_crtc(old_crtc_state->base.crtc);
 	struct drm_device *dev = crtc->base.dev;
 	struct drm_i915_private *dev_priv = dev->dev_private;
-	struct intel_crtc_atomic_commit *atomic = &crtc->atomic;
 	struct intel_crtc_state *pipe_config =
 		to_intel_crtc_state(crtc->base.state);
 	struct drm_atomic_state *old_state = old_crtc_state->base.state;
@@ -4960,15 +4954,14 @@ static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state)
 		drm_atomic_get_existing_plane_state(old_state, primary);
 	bool modeset = needs_modeset(&pipe_config->base);
 
-	if (atomic->update_fbc)
-		intel_fbc_pre_update(crtc);
-
 	if (old_pri_state) {
 		struct intel_plane_state *primary_state =
 			to_intel_plane_state(primary->state);
 		struct intel_plane_state *old_primary_state =
 			to_intel_plane_state(old_pri_state);
 
+		intel_fbc_pre_update(crtc);
+
 		if (old_primary_state->visible &&
 		    (modeset || !primary_state->visible))
 			intel_pre_disable_primary(&crtc->base);
@@ -12027,27 +12020,17 @@ int intel_plane_atomic_calc_changes(struct drm_crtc_state *crtc_state,
 	if (visible || was_visible)
 		pipe_config->fb_bits |= to_intel_plane(plane)->frontbuffer_bit;
 
-	switch (plane->type) {
-	case DRM_PLANE_TYPE_PRIMARY:
-		intel_crtc->atomic.update_fbc = true;
-
-		break;
-	case DRM_PLANE_TYPE_CURSOR:
-		break;
-	case DRM_PLANE_TYPE_OVERLAY:
-		/*
-		 * WaCxSRDisabledForSpriteScaling:ivb
-		 *
-		 * cstate->update_wm was already set above, so this flag will
-		 * take effect when we commit and program watermarks.
-		 */
-		if (IS_IVYBRIDGE(dev) &&
-		    needs_scaling(to_intel_plane_state(plane_state)) &&
-		    !needs_scaling(old_plane_state))
-			pipe_config->disable_lp_wm = true;
+	/*
+	 * WaCxSRDisabledForSpriteScaling:ivb
+	 *
+	 * cstate->update_wm was already set above, so this flag will
+	 * take effect when we commit and program watermarks.
+	 */
+	if (plane->type == DRM_PLANE_TYPE_OVERLAY && IS_IVYBRIDGE(dev) &&
+	    needs_scaling(to_intel_plane_state(plane_state)) &&
+	    !needs_scaling(old_plane_state))
+		pipe_config->disable_lp_wm = true;
 
-		break;
-	}
 	return 0;
 }
 
@@ -13475,9 +13458,6 @@ static int intel_atomic_check(struct drm_device *dev,
 		struct intel_crtc_state *pipe_config =
 			to_intel_crtc_state(crtc_state);
 
-		memset(&to_intel_crtc(crtc)->atomic, 0,
-		       sizeof(struct intel_crtc_atomic_commit));
-
 		/* Catch I915_MODE_FLAG_INHERITED */
 		if (crtc_state->mode.private_flags != crtc->state->mode.private_flags)
 			crtc_state->mode_changed = true;
@@ -13786,7 +13766,8 @@ static int intel_atomic_commit(struct drm_device *dev,
 		if (!modeset)
 			intel_pre_plane_update(to_intel_crtc_state(crtc_state));
 
-		if (crtc->state->active && intel_crtc->atomic.update_fbc)
+		if (crtc->state->active &&
+		    drm_atomic_get_existing_plane_state(state, crtc->primary))
 			intel_fbc_enable(intel_crtc);
 
 		if (crtc->state->active &&
drivers/gpu/drm/i915/intel_drv.h +0 -15
index 6385dbb01ace..dae04c3f8cda 100644
@@ -596,19 +596,6 @@ struct intel_mmio_flip {
 	unsigned int rotation;
 };
 
-/*
- * Tracking of operations that need to be performed at the beginning/end of an
- * atomic commit, outside the atomic section where interrupts are disabled.
- * These are generally operations that grab mutexes or might otherwise sleep
- * and thus can't be run with interrupts disabled.
- */
-struct intel_crtc_atomic_commit {
-	/* Sleepable operations to perform before commit */
-
-	/* Sleepable operations to perform after commit */
-	bool update_fbc;
-};
-
 struct intel_crtc {
 	struct drm_crtc base;
 	enum pipe pipe;
@@ -669,8 +656,6 @@ struct intel_crtc {
 		int scanline_start;
 	} debug;
 
-	struct intel_crtc_atomic_commit atomic;
-
 	/* scalers available on this crtc */
 	int num_scalers;
 
Signature · 6 lines
2.1.0

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by on v1 2/2
#2 lore raw

Re: [PATCH 2/2] drm/i915: Nuke fbc members from intel_crtc->atomic, v4.

Em Qua, 2016-03-09 às 10:35 +0100, Maarten Lankhorst escreveu:

Quoted 13 lines

Whenever there's an update to the primary plane, fbc_pre_update and fbc_post_update are called. Kill off intel_crtc->atomic.update_fbc and now that intel_crtc->atomic is empty, kill it off too.

Changes since v1:
- Add a intel_fbc_supports_rotation helper.
Changes since v2:
- Remove intel_fbc_supports_rotation_helper.
- Remove unrelated changes.
Changes since v3:
- Rebase

Quoted 1 line

Looks like the WM fixes indeed solved the problems I pointed in my previous review, so:

Quoted 190 lines

---
 drivers/gpu/drm/i915/intel_display.c | 51 +++++++++++---------------
----------
 drivers/gpu/drm/i915/intel_drv.h     | 15 -----------

 2 files changed, 16 insertions(+), 50 deletions(-)
drivers/gpu/drm/i915/intel_display.c +0 -0
index 2d31755608ce..6e6d8b342517 100644
@@ -4912,11 +4912,9 @@ static void intel_post_plane_update(struct
 intel_crtc_state *old_crtc_state)
  {

  struct intel_crtc *crtc = to_intel_crtc(old_crtc_state-

Quoted 1 line

base.crtc);

  struct drm_atomic_state *old_state = old_crtc_state-

Quoted 1 line

base.state;

drivers/gpu/drm/i915/intel_display.c +0 -1
-	struct intel_crtc_atomic_commit *atomic = &crtc->atomic;

  struct intel_crtc_state *pipe_config = to_intel_crtc_state(crtc->base.state); struct drm_device *dev = crtc->base.dev;

drivers/gpu/drm/i915/intel_display.c +0 -1
-	struct drm_i915_private *dev_priv = dev->dev_private;

  struct drm_plane *primary = crtc->base.primary; struct drm_plane_state *old_pri_state = drm_atomic_get_existing_plane_state(old_state, primary);

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -4928,22 +4926,19 @@ static void intel_post_plane_update(struct
 intel_crtc_state *old_crtc_state)
  	if (pipe_config->wm_changed && pipe_config->base.active)
  		intel_update_watermarks(&crtc->base);

drivers/gpu/drm/i915/intel_display.c +0 -3
-	if (atomic->update_fbc)
-		intel_fbc_post_update(crtc);
-

  if (old_pri_state) {
  struct intel_plane_state *primary_state = to_intel_plane_state(primary->state); struct intel_plane_state *old_primary_state = to_intel_plane_state(old_pri_state);

drivers/gpu/drm/i915/intel_display.c +2 -0
+		intel_fbc_post_update(crtc);
+

  if (primary_state->visible && (needs_modeset(&pipe_config->base) || !old_primary_state->visible)) intel_post_enable_primary(&crtc->base); }

drivers/gpu/drm/i915/intel_display.c +0 -2
-
-	memset(atomic, 0, sizeof(*atomic));

 }

 static void intel_pre_plane_update(struct intel_crtc_state *old_crtc_state)

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -4951,7 +4946,6 @@ static void intel_pre_plane_update(struct
 intel_crtc_state *old_crtc_state)

  struct intel_crtc *crtc = to_intel_crtc(old_crtc_state-

Quoted 1 line

base.crtc);

  struct drm_device *dev = crtc->base.dev; struct drm_i915_private *dev_priv = dev->dev_private;

drivers/gpu/drm/i915/intel_display.c +0 -1
-	struct intel_crtc_atomic_commit *atomic = &crtc->atomic;

  struct intel_crtc_state *pipe_config = to_intel_crtc_state(crtc->base.state); struct drm_atomic_state *old_state = old_crtc_state-

Quoted 1 line

base.state;

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -4960,15 +4954,14 @@ static void intel_pre_plane_update(struct
 intel_crtc_state *old_crtc_state)
  		drm_atomic_get_existing_plane_state(old_state,
 primary);
  	bool modeset = needs_modeset(&pipe_config->base);

drivers/gpu/drm/i915/intel_display.c +0 -3
-	if (atomic->update_fbc)
-		intel_fbc_pre_update(crtc);
-

  if (old_pri_state) {
  struct intel_plane_state *primary_state = to_intel_plane_state(primary->state); struct intel_plane_state *old_primary_state = to_intel_plane_state(old_pri_state);

drivers/gpu/drm/i915/intel_display.c +2 -0
+		intel_fbc_pre_update(crtc);
+

  if (old_primary_state->visible && (modeset || !primary_state->visible)) intel_pre_disable_primary(&crtc->base);

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -12027,27 +12020,17 @@ int intel_plane_atomic_calc_changes(struct
 drm_crtc_state *crtc_state,
  	if (visible || was_visible)

  pipe_config->fb_bits |= to_intel_plane(plane)-

Quoted 1 line

frontbuffer_bit;

drivers/gpu/drm/i915/intel_display.c +0 -12
-	switch (plane->type) {
-	case DRM_PLANE_TYPE_PRIMARY:
-		intel_crtc->atomic.update_fbc = true;
-
-		break;
-	case DRM_PLANE_TYPE_CURSOR:
-		break;
-	case DRM_PLANE_TYPE_OVERLAY:
-		/*
-		 * WaCxSRDisabledForSpriteScaling:ivb
-		 *
-		 * cstate->update_wm was already set above, so this

flag will

drivers/gpu/drm/i915/intel_display.c +0 -1
-		 * take effect when we commit and program

watermarks.

drivers/gpu/drm/i915/intel_display.c +0 -3
-		 */
-		if (IS_IVYBRIDGE(dev) &&
-		    needs_scaling(to_intel_plane_state(plane_state))

&&

drivers/gpu/drm/i915/intel_display.c +4 -2
-		    !needs_scaling(old_plane_state))
-			pipe_config->disable_lp_wm = true;
+	/*
+	 * WaCxSRDisabledForSpriteScaling:ivb
+	 *
+	 * cstate->update_wm was already set above, so this flag

will

drivers/gpu/drm/i915/intel_display.c +3 -0
+	 * take effect when we commit and program watermarks.
+	 */
+	if (plane->type == DRM_PLANE_TYPE_OVERLAY &&

IS_IVYBRIDGE(dev) &&

drivers/gpu/drm/i915/intel_display.c +3 -0
+	    needs_scaling(to_intel_plane_state(plane_state)) &&
+	    !needs_scaling(old_plane_state))
+		pipe_config->disable_lp_wm = true;

drivers/gpu/drm/i915/intel_display.c +0 -2
-		break;
-	}

  return 0;
 }

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -13475,9 +13458,6 @@ static int intel_atomic_check(struct
 drm_device *dev,

  struct intel_crtc_state *pipe_config = to_intel_crtc_state(crtc_state);

drivers/gpu/drm/i915/intel_display.c +0 -3
-		memset(&to_intel_crtc(crtc)->atomic, 0,
-		       sizeof(struct intel_crtc_atomic_commit));
-

  /* Catch I915_MODE_FLAG_INHERITED */
  if (crtc_state->mode.private_flags != crtc->state-

Quoted 1 line

mode.private_flags)

  crtc_state->mode_changed = true;

drivers/gpu/drm/i915/intel_display.c +0 -0
@@ -13786,7 +13766,8 @@ static int intel_atomic_commit(struct
 drm_device *dev,
  		if (!modeset)

  intel_pre_plane_update(to_intel_crtc_state(c rtc_state));

drivers/gpu/drm/i915/intel_display.c +0 -1
-		if (crtc->state->active && intel_crtc-
Quoted 1 line

atomic.update_fbc)

drivers/gpu/drm/i915/intel_display.c +2 -0
+		if (crtc->state->active &&
+		    drm_atomic_get_existing_plane_state(state, crtc-
Quoted 1 line

primary))

  intel_fbc_enable(intel_crtc);
  if (crtc->state->active &&

drivers/gpu/drm/i915/intel_drv.h +0 -0
index 6385dbb01ace..dae04c3f8cda 100644
@@ -596,19 +596,6 @@ struct intel_mmio_flip {
  	unsigned int rotation;
  };


-/*
- * Tracking of operations that need to be performed at the beginning/end of an
- * atomic commit, outside the atomic section where interrupts are disabled.
- * These are generally operations that grab mutexes or might otherwise sleep
- * and thus can't be run with interrupts disabled.
- */

drivers/gpu/drm/i915/intel_drv.h +0 -7
-struct intel_crtc_atomic_commit {
-	/* Sleepable operations to perform before commit */
-
-	/* Sleepable operations to perform after commit */
-	bool update_fbc;
-};
-

 struct intel_crtc {
  struct drm_crtc base;
  enum pipe pipe;

drivers/gpu/drm/i915/intel_drv.h +0 -0
@@ -669,8 +656,6 @@ struct intel_crtc {
  		int scanline_start;
  	} debug;

drivers/gpu/drm/i915/intel_drv.h +0 -2
-	struct intel_crtc_atomic_commit atomic;
-
Quoted 3 lines

  /* scalers available on this crtc */
  int num_scalers;

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw

✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.

In reply to Maarten Lankhorst
== Series Details ==

== Series Details ==

Series: series starting with [1/2] drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.
URL : https://patchwork.freedesktop.org/series/4261/
State : warning

== Summary ==

Series 4261v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/4261/revisions/1/mbox/

Test gem_ringfill:

        Subgroup basic-default-s3:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test kms_flip:
        Subgroup basic-flip-vs-modeset:
                dmesg-warn -> PASS       (bdw-ultra)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b:
                dmesg-warn -> PASS       (snb-x220t)
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (hsw-brixbox)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (bsw-nuc-2)
Test pm_rpm:
        Subgroup basic-pci-d3-state:
                fail       -> DMESG-FAIL (snb-x220t)
                pass       -> DMESG-WARN (snb-dellxps)
        Subgroup basic-rte:
                dmesg-warn -> PASS       (snb-dellxps)
bdw-nuci7        total:186  pass:174  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:186  pass:167  dwarn:0   dfail:0   fail:0   skip:19 
bsw-nuc-2        total:186  pass:150  dwarn:1   dfail:0   fail:0   skip:35 
byt-nuc          total:186  pass:154  dwarn:0   dfail:0   fail:0   skip:32 
hsw-brixbox      total:186  pass:166  dwarn:0   dfail:0   fail:0   skip:20 
hsw-gt2          total:186  pass:170  dwarn:1   dfail:0   fail:0   skip:15 
ivb-t430s        total:186  pass:164  dwarn:0   dfail:0   fail:0   skip:22 
skl-i5k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
skl-i7k-2        total:186  pass:165  dwarn:0   dfail:0   fail:0   skip:21 
snb-dellxps      total:186  pass:155  dwarn:1   dfail:0   fail:0   skip:30 
snb-x220t        total:186  pass:155  dwarn:1   dfail:1   fail:0   skip:29 

Results at /archive/results/CI_IGT_test/Patchwork_1546/

ab403b26610034afe0e0c97d960782bad98b97d0 drm-intel-nightly: 2016y-03m-09d-09h-25m-31s UTC integration manifest 57b84d83e0ac568bb896e2d91d4055e9398f2c36 drm/i915: Nuke fbc members from intel_crtc->atomic, v4. 6c0ccc5c9c7541ea90a17fbc1d71c017266edf7f drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#4 lore raw

Re: ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.

Op 09-03-16 om 10:59 schreef Patchwork:

Quoted 6 lines

== Series Details ==

Series: series starting with [1/2] drm/i915: Remove some post-commit members from intel_crtc->atomic, v3.
URL : https://patchwork.freedesktop.org/series/4261/
State : warning

Quoted 8 lines

== Summary ==

Series 4261v1 Series without cover letter
http://patchwork.freedesktop.org/api/1.0/series/4261/revisions/1/mbox/

Test gem_ringfill:

        Subgroup basic-default-s3:
                pass       -> DMESG-WARN (bsw-nuc-2)

circular locking with cpu_hotplug.lock again. :(

Quoted 10 lines

Test kms_flip:

        Subgroup basic-flip-vs-modeset:
                dmesg-warn -> PASS       (bdw-ultra)
Test kms_pipe_crc_basic:
        Subgroup nonblocking-crc-pipe-b:
                dmesg-warn -> PASS       (snb-x220t)
        Subgroup nonblocking-crc-pipe-b-frame-sequence:
                dmesg-warn -> PASS       (hsw-brixbox)
        Subgroup suspend-read-crc-pipe-c:
                dmesg-warn -> PASS       (bsw-nuc-2)

Flaky.

Quoted 7 lines

Test pm_rpm:

        Subgroup basic-pci-d3-state:
                fail       -> DMESG-FAIL (snb-x220t)
                pass       -> DMESG-WARN (snb-dellxps)
        Subgroup basic-rte:
                dmesg-warn -> PASS       (snb-dellxps)

Seems the failures were already pre existing and intermittent.
_______________________________________________
Intel-gfx mailing list [email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx