Skip to contentSkip to conversation

Staging: nvec: fix multiline comment style.

PATCH In review Neha Rani 2 participants 3 messages Mar 10, 2016 – Mar 12, 2016 1 message not in the archive

Subsystems (2)
Staging Staging - NVIDIA compliant embedded controller interface (nvec)
lore
Share & tools
lore

Neha Rani

author
#0 lore raw

PATCH 2/2 Staging: nvec: fix multiline comment style.

This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool

Signed-off-by Neha Rani <[email protected]>
---
 drivers/staging/nvec/nvec.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/nvec/nvec.c +4 -2
index 4ae44a5..57ad27a 100644
@@ -508,8 +508,10 @@ static void nvec_rx_completed(struct nvec_chip *nvec)
 
 	spin_lock(&nvec->rx_lock);
 
-	/* add the received data to the work list
-	   and move the ring buffer pointer to the next entry */
+	/**
+	 * add the received data to the work list
+	 * and move the ring buffer pointer to the next entry
+	 */
 	list_add_tail(&nvec->rx->node, &nvec->rx_data);
 
 	spin_unlock(&nvec->rx_lock);
Signature · 1 line
2.5.0
maintainer
#1 lore raw
Quoted 12 lines · Neha Rani

This is a patch in nvec.c file that fixes a multiline comment found by checkpatch.pl tool

Signed-off-by Neha Rani <[email protected]>
---
 drivers/staging/nvec/nvec.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/staging/nvec/nvec.c +0 -0
index 4ae44a5..57ad27a 100644

drivers/staging/nvec/nvec.c static void nvec_rx_completed(struct nvec_chip *nvec) · line 511

Quoted 6 lines
drivers/staging/nvec/nvec.c +1 -2
@@ -508,8 +508,10 @@ static void nvec_rx_completed(struct nvec_chip *nvec)
 
 	spin_lock(&nvec->rx_lock);
 
-	/* add the received data to the work list
-	   and move the ring buffer pointer to the next entry */
+	/**

One too many '*' characters here, sorry.

A message that is not in the archive (sent off-list or not yet received): CAJ7rW_CRN+6ko5vhyv4hRW3mZgPwJ4Bba+uLOkqiUD8rsZtWnA@mail.gmail.com

maintainer
#3 lore raw
Quoted 2 lines · Neha Rani

But it was warned by checkpatch.pl and after modifying, no warning. How can it be wrong?

I'll turn it around and ask you how do you know it is correct? :)

hint, it isn't, read Documentation/CodingStyle please.

thanks,

greg k-h