Skip to contentSkip to conversation

mx6slevk: Fix the power up of the Ethernet PHY

PATCH New Fabio Estevam 2 participants 3 messages Mar 11, 2016 – Mar 13, 2016

lore
Share & tools
lore

Fabio Estevam

author
#0 lore raw

PATCH 1/1 mx6slevk: Fix the power up of the Ethernet PHY

From: Fabio Estevam <[email protected]>

GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.

Fix that, so that we can have Ethernet functional again.

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx6slevk/mx6slevk.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
board/freescale/mx6slevk/mx6slevk.c +4 -5
index 4f816c4..f440ce6 100644
@@ -57,7 +57,7 @@ DECLARE_GLOBAL_DATA_PTR;
 			PAD_CTL_DSE_80ohm | PAD_CTL_HYS |	\
 			PAD_CTL_SRE_FAST)
 
-#define ETH_PHY_RESET	IMX_GPIO_NR(4, 21)
+#define ETH_PHY_POWER	IMX_GPIO_NR(4, 21)
 
 int dram_init(void)
 {

@@ -154,10 +154,9 @@ static void setup_iomux_fec(void)
 {
 	imx_iomux_v3_setup_multiple_pads(fec_pads, ARRAY_SIZE(fec_pads));
 
-	/* Reset LAN8720 PHY */
-	gpio_direction_output(ETH_PHY_RESET , 0);
-	udelay(25000);
-	gpio_set_value(ETH_PHY_RESET, 1);
+	/* Power up LAN8720 PHY */
+	gpio_direction_output(ETH_PHY_POWER , 1);
+	udelay(15000);
 }
 
 #define USDHC1_CD_GPIO	IMX_GPIO_NR(4, 7)
Signature · 1 line
1.9.1
#1 lore raw

PATCH 1/1 mx6slevk: Fix the power up of the Ethernet PHY

Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.

Fix that, so that we can have Ethernet functional again.

Signed-off-by Fabio Estevam <[email protected]>
Reviewed-by Tom Rini <[email protected]>
Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160313/69cb74d8/attachment.sig>
#2 lore raw

PATCH 1/1 mx6slevk: Fix the power up of the Ethernet PHY

In reply to Fabio Estevam
Quoted 7 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

GPIO4_21 is the LAN8720 power pin, not the LAN8720 reset pin.

Fix that, so that we can have Ethernet functional again.

Signed-off-by Fabio Estevam <[email protected]>

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160313/e47adf28/attachment.sig>