Skip to contentSkip to conversation

Patch "block: don't optimize for non-cloned bio in bio_get_last_bvec()" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 14, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

block: don't optimize for non-cloned bio in bio_get_last_bvec()

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
block-don-t-optimize-for-non-cloned-bio-in-bio_get_last_bvec.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 90d0f0f11588ec692c12f9009089b398be395184 Mon Sep 17 00:00:00 2001

From: Ming Lei <[email protected]>
Date: Sat, 12 Mar 2016 22:56:19 +0800
Subject: block: don't optimize for non-cloned bio in bio_get_last_bvec()

From: Ming Lei <[email protected]>

commit 90d0f0f11588ec692c12f9009089b398be395184 upstream.

For !BIO_CLONED bio, we can use .bi_vcnt safely, but it doesn't mean we can just simply return .bi_io_vec[.bi_vcnt - 1] because the start postion may have been moved in the middle of the bvec, such as splitting in the middle of bvec.

Fixes 7bcd79ac50d9(block: bio: introduce helpers to get the 1st and last bvec)
---
 include/linux/bio.h |    5 -----
 1 file changed, 5 deletions(-)
include/linux/bio.h +0 -5
@@ -320,11 +320,6 @@ static inline void bio_get_last_bvec(str
 	struct bvec_iter iter = bio->bi_iter;
 	int idx;
 
-	if (!bio_flagged(bio, BIO_CLONED)) {
-		*bv = bio->bi_io_vec[bio->bi_vcnt - 1];
-		return;
-	}
-
 	if (unlikely(!bio_multiple_segments(bio))) {
 		*bv = bio_iovec(bio);
 		return;

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/block-don-t-optimize-for-non-cloned-bio-in-bio_get_last_bvec.patch