Skip to contentSkip to conversation

Patch "ld-version: Fix awk regex compile failure" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Mar 14, 2016 Stable branch

lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ld-version: Fix awk regex compile failure

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
ld-version-fix-awk-regex-compile-failure.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4b7b1ef2c2f83d702272555e8adb839a50ba0f8e Mon Sep 17 00:00:00 2001

From: James Hogan <[email protected]>
Date: Tue, 8 Mar 2016 16:47:53 +0000
Subject: ld-version: Fix awk regex compile failure

From: James Hogan <[email protected]>

commit 4b7b1ef2c2f83d702272555e8adb839a50ba0f8e upstream.

The ld-version.sh script fails on some versions of awk with the following error, resulting in build failures for MIPS:

awk: scripts/ld-version.sh: line 4: regular expression compile failed (missing '(')

This is due to the regular expression ".*)", meant to strip off the beginning of the ld version string up to the close bracket, however brackets have a meaning in regular expressions, so lets escape it so that awk doesn't expect a corresponding open bracket.

Patchwork: https://patchwork.linux-mips.org/patch/12838/

---
 scripts/ld-version.sh |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/ld-version.sh +1 -1
@@ -1,7 +1,7 @@
 #!/usr/bin/awk -f
 # extract linker version number from stdin and turn into single number
 	{
-	gsub(".*)", "");
+	gsub(".*\\)", "");
 	split($1,a, ".");
 	print a[1]*10000000 + a[2]*100000 + a[3]*10000 + a[4]*100 + a[5];
 	exit

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/ld-version-fix-awk-regex-compile-failure.patch queue-4.4/mips-smp.c-fix-uninitialised-temp_foreign_map.patch