Skip to contentSkip to conversation

Pull request: u-boot-spi/master

U-Boot Jagan Teki 3 participants 4 messages Mar 15, 2016

lore
Share & tools
lore

Jagan Teki

author
#0 lore raw

Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:

Prepare v2016.03 (2016-03-14 10:20:21 -0400)

are available in the git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:

spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)

----------------------------------------------------------------
Jagan Teki (3):
spi: omap3: Move headers code inside the driver
spi: omap3: Make local functions as static
spi: omap3: Convert to driver model

 drivers/spi/Kconfig     |   7 +
 drivers/spi/omap3_spi.c | 757 +++++++++++++++++++++++++++++++-----------------
 drivers/spi/omap3_spi.h | 109 -------
 3 files changed, 497 insertions(+), 376 deletions(-)
 delete mode 100644 drivers/spi/omap3_spi.h
#1 lore raw
Quoted 11 lines · Jagan Teki

Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:

Prepare v2016.03 (2016-03-14 10:20:21 -0400)

Quoted 8 lines

are available in the git repository at:

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:

spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)

Applied to u-boot/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160315/f253631d/attachment.sig>
#2 lore raw
Quoted 15 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:

Prepare v2016.03 (2016-03-14 10:20:21 -0400)

are available in the git repository at:

Quoted 8 lines
Quoted 6 lines

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:

spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)

Applied to u-boot/master, thanks!

But, bah!

+(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple definition of `priv'
+(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
+(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o +(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
+(cm_t3517,cm_t35) make: *** [sub-make] Error 2

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160315/8c7e255c/attachment.sig>
#3 lore raw
Quoted 28 lines · Tom Rini
Quoted 15 lines · Tom Rini
Quoted 13 lines · Jagan Teki

Hi Tom,

Please pull this PR.

thanks!
Jagan.

The following changes since commit df61a74e6845ec9bdcdd48d2aff5e9c2c6debeaa:

Prepare v2016.03 (2016-03-14 10:20:21 -0400)

are available in the git repository at:

Quoted 8 lines
Quoted 6 lines

git://git.denx.de/u-boot-spi.git master

for you to fetch changes up to 77b8d04854f486741471ad02b93b473b5b3d72f8:

spi: omap3: Convert to driver model (2016-03-14 22:46:28 +0530)

Applied to u-boot/master, thanks!

But, bah!

Review

Quoted 5 lines
(quoted diff) +5 -0
+(cm_t3517,cm_t35) drivers/spi/built-in.o:(.bss.priv+0x0): multiple definition of `priv'
+(cm_t3517,cm_t35) drivers/built-in.o:(.bss.priv+0x0): first defined here
+(cm_t3517,cm_t35) arm-linux-gnueabi-ld.bfd: Warning: size of symbol `priv' changed from 20 in drivers/built-in.o to 4 in drivers/spi/built-in.o
+(cm_t3517,cm_t35) make[1]: *** [u-boot] Error 1
+(cm_t3517,cm_t35) make: *** [sub-make] Error 2

Ohh, yes look like an issue with global priv on non-dm stuff, will send the fix.

thanks!

Signature · 1 line
Jagan.