x86: dts: ce4100: Fix compatible string for PCF8575 chip
Subsystems (3)
PATCH 1/1 x86: dts: ce4100: Fix compatible string for PCF8575 chip
The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.
As a practical matter, the gpio-pcf857x driver doesn't match this string, so this device tree currently won't work.
--- Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++-- arch/x86/platform/ce4100/falconfalls.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt +2 -2
@@ -71,7 +71,7 @@ This is an example which is used on FalconFalls: /* This I2C controller has one gpio controller */ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };
@@ -85,7 +85,7 @@ This is an example which is used on FalconFalls: gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };
arch/x86/platform/ce4100/falconfalls.dts +2 -2
@@ -252,7 +252,7 @@ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };
@@ -266,7 +266,7 @@ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };
Signature · 2 lines
Ben Hutchings Software Developer, Codethink Ltd.
Quoted 10 lines · Ben Hutchings
The binding definition for the PCF857x GPIO expanders doesn't mention a "ti,pcf8575" compatible string. This is apparently because TI is only a second source - there is no functional difference between PCF8575 chips manufactured by TI and NXP, and the same board might be populated with either depending on availability.
As a practical matter, the gpio-pcf857x driver doesn't match this string, so this device tree currently won't work.
Signed-off-by Ben Hutchings <[email protected]>
Append or replace that with:
Quoted 50 lines
--- Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt | 4 ++-- arch/x86/platform/ce4100/falconfalls.dts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)Documentation/devicetree/bindings/i2c/i2c-pxa-pci-ce4100.txt +2
-2@@ -71,7 +71,7 @@ This is an example which is used on FalconFalls: /* This I2C controller has one gpio controller */ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };@@ -85,7 +85,7 @@ This is an example which is used on FalconFalls: gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };arch/x86/platform/ce4100/falconfalls.dts +2
-2@@ -252,7 +252,7 @@ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };@@ -266,7 +266,7 @@ gpio@26 { #gpio-cells = <2>; - compatible = "ti,pcf8575"; + compatible = "nxp,pcf8575"; reg = <0x26>; gpio-controller; };
Signature · 2 lines
Ben Hutchings Software Developer, Codethink Ltd.