Skip to contentSkip to conversation

staging: netlogic: Fixed alignment of parantheseis checkpatch warning

PATCH In review Parth Sane 2 participants 2 messages Mar 19, 2016 Staging

lore
Share & tools
lore

Parth Sane

author
#0 lore raw

PATCH 1/1 staging: netlogic: Fixed alignment of parantheseis checkpatch warning

Fixed alignment of paranthesis as per checkpatch.

Signed-off-by Parth Sane <[email protected]>
---
 drivers/staging/netlogic/platform_net.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/staging/netlogic/platform_net.c +1 -3
index daee1b2..82af021 100644
@@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
 		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
 		ndata1.phy_addr[mac] = mac + 4 + 0x10;
 
-		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);
 	}
 	xlr_net_dev1.num_resources = 8;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 1 line · Parth Sane

Fixed alignment of paranthesis as per checkpatch.

Please run your proposed patches through checkpatch.

drivers/staging/netlogic/platform_net.c

Quoted 1 line
drivers/staging/netlogic/platform_net.c +0 -0

[]

drivers/staging/netlogic/platform_net.c static struct platform_device *gmac_controller2_init(void *gmac0_addr) · line 124

Quoted 8 lines
drivers/staging/netlogic/platform_net.c +0 -0
@@ -121,9 +121,7 @@ static struct platform_device *gmac_controller2_init(void *gmac0_addr)
  		ndata1.tx_stnid[mac] = FMN_STNID_GMAC1_TX0 + mac;
  		ndata1.phy_addr[mac] = mac + 4 + 0x10;

drivers/staging/netlogic/platform_net.c +1 -3
-		xlr_resource_init(&xlr_net1_res[mac * 2],
-				xlr_gmac_offsets[mac + 4],
-				xlr_gmac_irqs[mac + 4]);
+		xlr_resource_init(&xlr_net1_res[mac * 2], xlr_gmac_offsets[mac + 4], xlr_gmac_irqs[mac + 4]);

More typical is to avoid exceeding 80 columns
and wrap this line like:

		xlr_resource_init(&xlr_net1_res[mac * 2],
				  xlr_gmac_offsets[mac + 4],
				  xlr_gmac_irqs[mac + 4]);

Indenting the 2nd and 3rd lines with 4 tabs and 2 spaces