Asoc: bytcr-rt5640: add more machine/board information for user space
Subsystems (3)
PATCH 1/1 Asoc: bytcr-rt5640: add more machine/board information for user space
From: "Lu, Han" <[email protected]>
Add more machine/board information for PA and UCM. Previously on ASoc, the card short name, driver name and long name are all the same as the machine driver name. On T100TA it looks like:
$ cat /proc/asound/cards
0 [bytcr-rt5640]: bytcr-rt5640 - bytcr-rt5640
bytcr-rt5640
The patch made changes below:
driver name ---> machine driver name
short name ---> DMI_PRODUCT_NAME or DMI_BOARD_NAME
long name ---> short name:driver name(:DMI_SYS_VENDOR if applicable)
And add card component: long name:firmware name. On T100TA it looks like:
$ cat /proc/asound/cards
0 [T100TA ]: bytcr-rt5640 - T100TA
T100TA:bytcr-rt5640:ASUSTek COMPUTER INC.
$ amixer -c0 info
Card hw:0 'T100TA'/'T100TA:bytcr-rt5640:ASUSTek COMPUTER INC.'
Mixer name : ''
Components : 'T100TA:bytcr-rt5640:ASUSTek COMPUTER INC.:intel/fw_s
st_0f28.bin'
Controls : 256
Simple ctrls : 228sound/soc/intel/boards/bytcr_rt5640.c +30 -0
@@ -152,6 +152,8 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { {} }; +static struct snd_soc_card byt_rt5640_card; +static int byt_rt5640_init (struct snd_soc_pcm_runtime *runtime) {int ret;
@@ -159,6 +161,34 @@ static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime)struct snd_soc_card *card = runtime->card;const struct snd_soc_dapm_route *custom_map;int num_routes; +const char *dmi_name; +char *component; +struct sst_acpi_mach *mach = byt_rt5640_card.dev->platform_data; + +/* Add machine/board information for userspace: +* card driver name ---> machine driver name +* card short name ---> DMI_PRODUCT_NAME or DMI_BOARD_NAME +* card long name ---> short name:driver name(:DMI_SYS_VENDOR) +*/ + card->driver_name = card->name; + dmi_name =dmi_get_system_info (DMI_PRODUCT_NAME ); +if (!dmi_name) + dmi_name =dmi_get_system_info (DMI_BOARD_NAME ); +if (dmi_name) + card->name = dmi_name; + card->long_name =kstrdup (card->name,GFP_KERNEL ); +strcat ((char *)card->long_name,":" ); +strcat ((char *)card->long_name, card->driver_name); + dmi_name =dmi_get_system_info (DMI_SYS_VENDOR ); +if (dmi_name) { +strcat ((char *)card->long_name,":" ); +strcat ((char *)card->long_name, dmi_name); + } +/* card component ---> long name:firmware name */ + component =kstrdup (card->long_name,GFP_KERNEL ); +strcat (component,":" ); +strcat (component, mach->fw_filename); +snd_component_add (card->snd_card, component); card->dapm.idle_bias_off = true;
Signature · 1 line
2.5.0
Liam Girdwood
maintainerQuoted 49 lines · On Tue, 2016-03-29 at 14:35 +0800, [email protected] wrote:
From: "Lu, Han" <[email protected]>
Add more machine/board information for PA and UCM. Previously on ASoc, the card short name, driver name and long name are all the same as the machine driver name. On T100TA it looks like:
$ cat /proc/asound/cards 0 [bytcr-rt5640]: bytcr-rt5640 - bytcr-rt5640 bytcr-rt5640 The patch made changes below: driver name ---> machine driver name short name ---> DMI_PRODUCT_NAME or DMI_BOARD_NAME long name ---> short name:driver name(:DMI_SYS_VENDOR if applicable) And add card component: long name:firmware name. On T100TA it looks like: $ cat /proc/asound/cards 0 [T100TA ]: bytcr-rt5640 - T100TA T100TA:bytcr-rt5640:ASUSTek COMPUTER INC. $ amixer -c0 info Card hw:0 'T100TA'/'T100TA:bytcr-rt5640:ASUSTek COMPUTER INC.' Mixer name : '' Components : 'T100TA:bytcr-rt5640:ASUSTek COMPUTER INC.:intel/fw_s st_0f28.bin' Controls : 256 Simple ctrls : 228Signed-off-by Lu, Han <[email protected]>sound/soc/intel/boards/bytcr_rt5640.c +8
-0@@ -152,6 +152,8 @@ static const struct dmi_system_id byt_rt5640_quirk_table[] = { {} }; +static struct snd_soc_card byt_rt5640_card; +static int byt_rt5640_init (struct snd_soc_pcm_runtime *runtime) {int ret;@@ -159,6 +161,34 @@ static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime)struct snd_soc_card *card = runtime->card;const struct snd_soc_dapm_route *custom_map;int num_routes; +const char *dmi_name; +char *component; +struct sst_acpi_mach *mach = byt_rt5640_card.dev->platform_data; + +/* Add machine/board information for userspace: +* card driver name ---> machine driver name
sound/soc/intel/boards/bytcr_rt5640.c static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime) · line 179
Quoted 10 lines
sound/soc/intel/boards/bytcr_rt5640.c +10
-0+* card short name ---> DMI_PRODUCT_NAME or DMI_BOARD_NAME +* card long name ---> short name:driver name(:DMI_SYS_VENDOR) +*/ + card->driver_name = card->name; + dmi_name =dmi_get_system_info (DMI_PRODUCT_NAME ); +if (!dmi_name) + dmi_name =dmi_get_system_info (DMI_BOARD_NAME ); +if (dmi_name) + card->name = dmi_name; + card->long_name =kstrdup (card->name,GFP_KERNEL )
Best to check here and below whether kstrdup succeeds.
Quoted 6 lines
sound/soc/intel/boards/bytcr_rt5640.c +4
-0; +strcat ((char *)card->long_name,":" ); +strcat ((char *)card->long_name, card->driver_name); + dmi_name =dmi_get_system_info (DMI_SYS_VENDOR ); +if (dmi_name) {
sound/soc/intel/boards/bytcr_rt5640.c static int byt_rt5640_init(struct snd_soc_pcm_runtime *runtime) · line 193
Quoted 10 lines
sound/soc/intel/boards/bytcr_rt5640.c +8
-0+strcat ((char *)card->long_name,":" ); +strcat ((char *)card->long_name, dmi_name); + } +/* card component ---> long name:firmware name */ + component =kstrdup (card->long_name,GFP_KERNEL ); +strcat (component,":" ); +strcat (component, mach->fw_filename); +snd_component_add (card->snd_card, component); card->dapm.idle_bias_off = true;
We should probably add this as a core API since a lot of machine drivers will likely just copy and paste.
Thanks
Liam