Skip to contentSkip to conversation

usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb

PATCH In review [email protected] 2 participants 3 messages Mar 30, 2016

Subsystems (2)
USB DesignWare USB3 DRD IP driver
lore
Share & tools
lore

[email protected]

author
#0 lore raw

PATCH 1/1 usb: dwc3: rename __dwc3_cleanup_done_trbs to __dwc3_cleanup_one_trb

From: "Du, Changbin" <[email protected]>

Actually, the function only clean one trb. So rename the function.

Signed-off-by Du, Changbin <[email protected]>
---
 drivers/usb/dwc3/gadget.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/gadget.c +2 -2
index 3ac170f..f84be3d 100644
@@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)
 
 /* -------------------------------------------------------------------------- */
 
-static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
+static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep,
 		struct dwc3_request *req, struct dwc3_trb *trb,
 		const struct dwc3_event_depevt *event, int status)
 {

@@ -1975,7 +1975,7 @@ static int dwc3_cleanup_done_reqs(struct dwc3 *dwc, struct dwc3_ep *dep,
 			slot %= DWC3_TRB_NUM;
 			trb = &dep->trb_pool[slot];
 
-			ret = __dwc3_cleanup_done_trbs(dwc, dep, req, trb,
+			ret = __dwc3_cleanup_one_trb(dwc, dep, req, trb,
 					event, status);
 			if (ret)
 				break;
Signature · 1 line
2.5.0
#1 lore raw

Hi,

Quoted 6 lines · [email protected] writes:

[ text/plain ]
From: "Du, Changbin" <[email protected]>

Actually, the function only clean one trb. So rename the function.

Signed-off-by Du, Changbin <[email protected]>

okay :-)

Quoted 9 lines
---
 drivers/usb/dwc3/gadget.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/usb/dwc3/gadget.c +0 -0
index 3ac170f..f84be3d 100644

drivers/usb/dwc3/gadget.c static void dwc3_gadget_free_endpoints(struct dwc3 *dwc) · line 1876

Quoted 5 lines
drivers/usb/dwc3/gadget.c +1 -1
@@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)
 
 /* -------------------------------------------------------------------------- */
 
-static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep *dep,
+static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep *dep,

I would rather just remove that 's' from the end so the function's name stays as __dwc3_cleanup_done_trb() ;-)

Care to do that ?

thanks

Signature · 1 line
balbi
author
#2 lore raw
Quoted 13 lines

Review static void dwc3_gadget_free_endpoints(struct

Quoted 1 line
(quoted diff) +0 -0
@@ -1873,7 +1873,7 @@ static void dwc3_gadget_free_endpoints(struct

dwc3 *dwc)

drivers/usb/dwc3/gadget.c static void dwc3_gadget_free_endpoints(struct dwc3 *dwc)

Quoted 4 lines
drivers/usb/dwc3/gadget.c +0 -1
 /* -------------------------------------------------------------------------- */
 
-static int __dwc3_cleanup_done_trbs(struct dwc3 *dwc, struct dwc3_ep

*dep,

Review static void dwc3_gadget_free_endpoints(struct · line 1875

Quoted 1 line
(quoted diff) +1 -0
+static int __dwc3_cleanup_one_trb(struct dwc3 *dwc, struct dwc3_ep

*dep,

I would rather just remove that 's' from the end so the function's name stays as __dwc3_cleanup_done_trb() ;-)

Quoted 6 lines

Care to do that ?

thanks

--
Balbi

IMO, "one_trb" is a little more clear. But both is okay for me. :)

Thanks,
Du, Changbin