Skip to contentSkip to conversation

fluentbit: add new recipe

PATCH Superseded Eduardo Silva 4 participants 10 messages Mar 31, 2016 – Apr 6, 2016

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 fluentbit: add new recipe

Fluent Bit is an open source data collector for Embedded Linux, this patch adds the recipe for version 0.7.2.

Project web site: http://fluentbit.io
Documentation : http://fluentbit.io/documentation/

---
 meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +15 -0
new file mode 100644
index 0000000..fd38e84
@@ -0,0 +1,15 @@
+SUMMARY = "Fast data collector for Embedded Linux"
+HOMEPAGE = "http://fluentbit.io"
+BUGTRACKER = "https://github.com/fluent/fluent-bit/issues"
+
+SRC_URI = "http://fluentbit.io/releases/0.7/fluent-bit-${PV}.tar.gz"
+SRC_URI[md5sum] = "6df9d676e1d2d782a243e655e144e8ae"
+SRC_URI[sha256sum] = "695b56ce378f56855c9554f88f5d8e4f7b11ba7691284903870f779912af4ebe"
+S = "${WORKDIR}/fluent-bit-${PV}"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"
+
+RDEPENDS_${PN} = "zlib"
+
+inherit cmake
Signature · 1 line
2.5.0
#1 lore raw
Quoted 19 lines · Eduardo Silva

Fluent Bit is an open source data collector for Embedded Linux, this patch adds the recipe for version 0.7.2.

Project web site: http://fluentbit.io
Documentation : http://fluentbit.io/documentation/

---
 meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
 create mode 100644 meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +1 -0
new file mode 100644
index 0000000..fd38e84
@@ -0,0 +1,15 @@
+SUMMARY = "Fast data collector for Embedded Linux"

meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb line 11

Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +10 -0
+HOMEPAGE = "http://fluentbit.io"
+BUGTRACKER = "https://github.com/fluent/fluent-bit/issues"
+
+SRC_URI = "http://fluentbit.io/releases/0.7/fluent-bit-${PV}.tar.gz"
+SRC_URI[md5sum] = "6df9d676e1d2d782a243e655e144e8ae"
+SRC_URI[sha256sum] = "695b56ce378f56855c9554f88f5d8e4f7b11ba7691284903870f779912af4ebe"
+S = "${WORKDIR}/fluent-bit-${PV}"
+
+LICENSE = "Apache-2.0"
+LIC_FILES_CHKSUM = "file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb line 13

Quoted 2 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -0
+
+inherit cmake
Signature · 7 lines
2.5.0

-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 1 line

+LIC_FILES_CHKSUM =

"file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

Quoted 5 lines

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

Thanks, I have updated my local copy

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

I added that because I got a QA warning message:

WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build dependency? [build-deps]

what's your suggestion in this case ?

best

Quoted 21 lines
Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -1
+
+inherit cmake
--

2.5.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
Eduardo Silva
Monkey Software
#3 lore raw

Then it's probably build time dependency as the warning says, not runtime dependency like you did.

Read what the component build does, if it checks for zlib in configure then you really need to add it to DEPENDS not RDEPENDS_${PN}.

Quoted 64 lines · Eduardo Silva
Quoted 1 line

+LIC_FILES_CHKSUM =

"file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

Quoted 5 lines

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

Thanks, I have updated my local copy

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

I added that because I got a QA warning message:

WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build dependency? [build-deps]

what's your suggestion in this case ?

best

Quoted 14 lines
Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -1
+
+inherit cmake
--

2.5.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Eduardo Silva
Monkey Software
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

#4 lore raw

Oh, sorry I misunderstood. The program requires zlib to run, so it's a build (headers) and runtime dependency.

Quoted 78 lines · Martin Jansa

Then it's probably build time dependency as the warning says, not runtime dependency like you did.

Read what the component build does, if it checks for zlib in configure then you really need to add it to DEPENDS not RDEPENDS_${PN}.

Quoted 55 lines · Eduardo Silva
Quoted 1 line

+LIC_FILES_CHKSUM =

"file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

Quoted 5 lines

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

Thanks, I have updated my local copy

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

I added that because I got a QA warning message:

WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build dependency? [build-deps]

what's your suggestion in this case ?

best

Quoted 14 lines
Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -1
+
+inherit cmake
--

2.5.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 9 lines

--
Eduardo Silva
Monkey Software
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Signature · 2 lines
Eduardo Silva
Monkey Software
#5 lore raw

on this case should be "RDEPENDS_${PN} = "zlib" OK ?

Quoted 92 lines · Eduardo Silva

Oh, sorry I misunderstood. The program requires zlib to run, so it's a build (headers) and runtime dependency.

Quoted 73 lines · Martin Jansa

Then it's probably build time dependency as the warning says, not runtime dependency like you did.

Read what the component build does, if it checks for zlib in configure then
you really need to add it to DEPENDS not RDEPENDS_${PN}.

Quoted 55 lines · Eduardo Silva
Quoted 1 line

+LIC_FILES_CHKSUM =

"file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

Quoted 5 lines

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

Thanks, I have updated my local copy

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

I added that because I got a QA warning message:

WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build dependency? [build-deps]

what's your suggestion in this case ?

best

Quoted 14 lines
Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -1
+
+inherit cmake
--

2.5.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 9 lines

--
Eduardo Silva
Monkey Software
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 6 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Eduardo Silva
Monkey Software

Signature · 2 lines
Eduardo Silva
Monkey Software
#6 lore raw
Quoted 1 line · Eduardo Silva

on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

Quoted 105 lines · Eduardo Silva
Quoted 93 lines

Oh, sorry I misunderstood. The program requires zlib to run, so it's a build (headers) and runtime dependency.

Quoted 73 lines · Martin Jansa

Then it's probably build time dependency as the warning says, not runtime dependency like you did.

Read what the component build does, if it checks for zlib in configure then
you really need to add it to DEPENDS not RDEPENDS_${PN}.

Quoted 55 lines · Eduardo Silva
Quoted 1 line

+LIC_FILES_CHKSUM =

"file://${S}/LICENSE;md5=2ee41112a44fe7014dce33e26468ba93"

Quoted 5 lines

LIC_FILES_CHKSUM is relative to ${S}, so LIC_FILES_CHKSUM = "file://LICENSE.. should work fine

Thanks, I have updated my local copy

Quoted 8 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+
+RDEPENDS_${PN} = "zlib"

If it does link with libz then the runtime dependency should be added automatically by shlibs code in package.bbclass if it's not the case can you add comment explaining why it needs to be added explicitly?

I added that because I got a QA warning message:

WARNING: QA Issue: fluentbit-dev rdepends on zlib, but it isn't a build dependency? [build-deps]
WARNING: QA Issue: fluentbit rdepends on zlib, but it isn't a build dependency? [build-deps]

what's your suggestion in this case ?

best

Quoted 14 lines
Quoted 10 lines
meta-oe/recipes-extended/fluentbit/fluentbit_0.7.2.bb new file +2 -1
+
+inherit cmake
--

2.5.0

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Martin 'JaMa' Jansa jabber: [email protected]

Quoted 7 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 9 lines

--
Eduardo Silva
Monkey Software
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

Quoted 6 lines

--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel

--
Eduardo Silva
Monkey Software

Signature · 7 lines
Eduardo Silva
Monkey Software
-- 
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#7 lore raw
Quoted 4 lines · On Sat, 02 Apr 2016 20:17:14 Martin Jansa wrote:
Quoted 1 line · Eduardo Silva

on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

It's build-time so you want zlib in DEPENDS. A runtime dependency will get added automatically (since binaries packaged by the recipe will be linking against libz.so).

Cheers,
Paul

Signature · 2 lines
Paul Eggleton
Intel Open Source Technology Centre
#8 lore raw

Thanks. Already sent a Patch v2.

Quoted 18 lines · Paul Eggleton
Quoted 4 lines · On Sat, 02 Apr 2016 20:17:14 Martin Jansa wrote:
Quoted 1 line · Eduardo Silva

on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

It's build-time so you want zlib in DEPENDS. A runtime dependency will get added automatically (since binaries packaged by the recipe will be linking against libz.so).

Cheers,
Paul

--

Paul Eggleton
Intel Open Source Technology Centre

#9 lore raw

Hi Eduardo,

Quoted 1 line · Eduardo Silva

Thanks. Already sent a Patch v2.

Please, avoid top-posting.

Quoted 21 lines
Quoted 18 lines · Paul Eggleton
Quoted 4 lines · On Sat, 02 Apr 2016 20:17:14 Martin Jansa wrote:
Quoted 1 line · Eduardo Silva

on this case should be "RDEPENDS_${PN} = "zlib" OK ?

NO

It's build-time so you want zlib in DEPENDS. A runtime dependency will get added automatically (since binaries packaged by the recipe will be linking against libz.so).

Cheers,
Paul

--

Paul Eggleton
Intel Open Source Technology Centre

Signature · 1 line
Felipe