Skip to contentSkip to conversation

scripts, lib: Don't limit traceback lengths to arbitrary values

PATCH In review Richard Purdie 2 participants 2 messages Mar 31, 2016

lore
Share & tools
lore

Richard Purdie

author
#0 lore raw

PATCH 1/1 scripts, lib: Don't limit traceback lengths to arbitrary values

There appears to have been a lot of copy and pasting of the code which prints tracebacks upon failure and limits the stack trace to 5 entries. This obscures the real error and is very confusing to the user it look me an age to work out why some tracebacks weren't useful.

This patch removes the limit, making tracebacks much more useful for debugging.

[YOCTO #9230]

Signed-off-by Richard Purdie <[email protected]>
meta/files/ext-sdk-prepare.py +1 -1
index 7887696..80db8bb 100644
@@ -94,5 +94,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
meta/lib/oeqa/runexported.py +1 -1
index dba0d7a..e9a2912 100755
@@ -140,5 +140,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/cleanup-workdir +1 -1
index a7f5a3a..01ebd52 100755
@@ -194,5 +194,5 @@ if __name__ == '__main__':
     except Exception:
         ret = 2
         import traceback
-        traceback.print_exc(3)
+        traceback.print_exc()
     sys.exit(ret)
scripts/combo-layer +1 -1
index 09a53a2..9127041 100755
@@ -920,5 +920,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/devtool +1 -1
index 06e91b7..e1198b1 100755
@@ -318,5 +318,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/oe-publish-sdk +1 -1
index 1729a0d..2b6e9bc 100755
@@ -150,5 +150,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/oe-selftest +1 -1
index 9b61bfa..9b29ae0 100755
@@ -630,7 +630,7 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     finally:
         remove_include()
         remove_inc_files()
scripts/recipetool +1 -1
index 1198cc2..6c66487 100755
@@ -117,5 +117,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/test-remote-image +1 -1
index 97d03d7..9c5b015 100755
@@ -357,5 +357,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/yocto-bsp +1 -1
index 2d9453f..82a050e 100755
@@ -151,6 +151,6 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/yocto-kernel +1 -1
index c9b2821..daaad07 100755
@@ -395,5 +395,5 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
scripts/yocto-layer +1 -1
index 313d464..356972e 100755
@@ -146,6 +146,6 @@ if __name__ == "__main__":
     except Exception:
         ret = 1
         import traceback
-        traceback.print_exc(5)
+        traceback.print_exc()
     sys.exit(ret)
#1 lore raw
Quoted 9 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Richard Purdie
Sent: den 31 mars 2016 13:47
To: openembedded-core
Subject: [OE-core] [PATCH] scripts, lib: Don't limit traceback lengths to arbitrary values

Quoted 4 lines

There appears to have been a lot of copy and pasting of the code which prints tracebacks upon failure and limits the stack trace to 5 entries. This obscures the real error and is very confusing to the user it look me an age to work out why some tracebacks weren't useful.

     ^^^^

Change "look" to "took".

//Peter