qtdeclarative: fix compilation of examples/qquickviewcomparison
PATCH 1/2 qtdeclarative: fix compilation of examples/qquickviewcomparison
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14: error: 'QCoreApplication' has not been declared
if (!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28 ++++++++++++++++++++++ recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644 recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +28 -0
@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has not been + declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +index 5b86c93..e77514e 100644 +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView> ++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +
recipes-qt/qt5/qtdeclarative_git.bb +1 -0
@@ -15,6 +15,7 @@ DEPENDS += "qtbase" SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ + file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \ " EXTRA_OEMAKE += "QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
Signature · 1 line
2.2.0
PATCH 2/2 qtquickcontrols: fix compilation of examples/texteditor
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/controls/texteditor/src/documenthandler.cpp:136:12: error: invalid use of incomplete type 'class QDebug'
qDebug() << "saved to" << localPath;
--- ...fix-invalid-use-of-incomplete-type-class-.patch | 27 ++++++++++++++++++++++ recipes-qt/qt5/qtquickcontrols_git.bb | 4 ++++ 2 files changed, 31 insertions(+) create mode 100644 recipes-qt/qt5/qtquickcontrols/0001-texteditor-fix-invalid-use-of-incomplete-type-class-.patch
recipes-qt/qt5/qtquickcontrols/0001-texteditor-fix-invalid-use-of-incomplete-type-class-.patch new file +27 -0
@@ -0,0 +1,27 @@ +From c39a563984693efac577adb137115693634c038f Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:57:01 -0400 +Subject: [PATCH] texteditor: fix invalid use of incomplete type 'class QDebug' + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/controls/texteditor/src/documenthandler.cpp | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/examples/quick/controls/texteditor/src/documenthandler.cpp b/examples/quick/controls/texteditor/src/documenthandler.cpp +index 2e9987a..c8bf419 100644 +--- a/examples/quick/controls/texteditor/src/documenthandler.cpp ++++ b/examples/quick/controls/texteditor/src/documenthandler.cpp +@@ -44,6 +44,7 @@ + #include <QtGui/QTextCursor> + #include <QtGui/QFontDatabase> + #include <QtCore/QFileInfo> ++#include <QtCore/QDebug> + + DocumentHandler::DocumentHandler() + : m_target(0) +-- +2.2.0 +
recipes-qt/qt5/qtquickcontrols_git.bb +4 -0
@@ -13,4 +13,8 @@ DEPENDS += "qtdeclarative" RDEPENDS_${PN}-dev = "" +SRC_URI += " \ + file://0001-texteditor-fix-invalid-use-of-incomplete-type-class-.patch \ +" + SRCREV = "93d06fb27d7eae9290db33b6684916a225939f0b"
Signature · 1 line
2.2.0
Ping. These 2 have been sitting in master-next as well for quite some time. Any updates?
Quoted 66 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14: error: 'QCoreApplication' has not been declared
if (!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28 ++++++++++++++++++++++ recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644 recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchrecipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +28
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has not been + declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +index 5b86c93..e77514e 100644 +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView> ++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/qtdeclarative_git.bb +1
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase" SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ + file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \ " EXTRA_OEMAKE += "QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"Signature · 7 lines
2.2.0 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Martin,
Any comments?
Quoted 76 lines · Denys Dmytriyenko
Ping. These 2 have been sitting in master-next as well for quite some time. Any updates?
Quoted 66 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14: error: 'QCoreApplication' has not been declared
if (!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28 ++++++++++++++++++++++ recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644 recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchrecipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +28
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has not been + declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +index 5b86c93..e77514e 100644 +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView> ++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/qtdeclarative_git.bb +1
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase" SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ + file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \ " EXTRA_OEMAKE += "QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"Signature · 7 lines
2.2.0 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-develSignature · 4 lines
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
I was testing if this is still needed with latest 5.6 currently in jansa/master. Or if I can just drop this again when upgrading to newer revisions.
Did you see this issue only with 5.6 revisions currently in master or with 5.6 revisions sent by Andreas which are now in master-next and where even qtbase examples fail to build in default setup as reported in separate e-mail?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-April/107077.html
Quoted 103 lines · Denys Dmytriyenko
Martin,
Any comments?
Quoted 1 line · Denys Dmytriyenko
Ping. These 2 have been sitting in master-next as well for quite some
time.
Quoted 7 lines
Any updates?
Quoted 3 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14:
error: 'QCoreApplication' has not been declaredQuoted 1 line
Quoted 1 line
if
(!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
Quoted 4 lines
Quoted 4 lines
Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28++++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 2 lines
Quoted 2 lines
diff --git
a/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchb/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 4 lines
Quoted 4 lines
new file mode 100644
index 0000000..1687fbe
---/dev/null
+++
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 5 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch line 4
Quoted 5 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +4
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has notbeen
Quoted 10 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 10 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +10
-0+ declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hb/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 7 lines
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0+index 5b86c93..e77514e 100644 +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView>Quoted 8 lines
recipes-qt/qt5/
Quoted 8 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/ renamed from recipes-qt/qt5/qtdeclarative_git.bb +0
-0qtdeclarative_git.bb
Quoted 8 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 18
Quoted 8 lines
index 93442fb..9274d00 100644
recipes-qt/qt5/qtdeclarative_git.bb +1
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase" SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ +file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 21
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +0
-0" EXTRA_OEMAKE +="QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
Quoted 8 lines
Quoted 8 lines
--
2.2.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 9 lines · Martin Jansa
I was testing if this is still needed with latest 5.6 currently in jansa/master. Or if I can just drop this again when upgrading to newer revisions.
Did you see this issue only with 5.6 revisions currently in master or with 5.6 revisions sent by Andreas which are now in master-next and where even qtbase examples fail to build in default setup as reported in separate e-mail?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-April/107077.html
Sorry, I haven't had a chance to try master-next yet. Those patches are needed for 5.5.99/5.6-beta from current master.
If you merge 5.6 into master any time soon, I would definitely prefer for examples to work there. BTW, I can't believe examples are so broken in Qt, even in the official 5.6 release, based on your other email... So, if you want master/krogoth to be 5.6 release, we'd have to backport example fixes from post-5.6 revs, which I would be glad to help with...
Signature · 1 line
Denys
Quoted 110 lines · Denys Dmytriyenko
Quoted 104 lines
Martin,
Any comments?
Quoted 1 line · Denys Dmytriyenko
Ping. These 2 have been sitting in master-next as well for quite some
time.
Quoted 7 lines
Any updates?
Quoted 3 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14:
error: 'QCoreApplication' has not been declaredQuoted 1 line
Quoted 1 line
if
(!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
Quoted 4 lines
Quoted 4 lines
Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28++++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 2 lines
Quoted 2 lines
diff --git
a/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchb/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 4 lines
Quoted 4 lines
new file mode 100644
index 0000000..1687fbe
---/dev/null
+++
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 5 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch line 4
Quoted 5 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +4
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:00 2001 +From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication has notbeen
Quoted 10 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 10 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +10
-0+ declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h | 1 + + 1 file changed, 1 insertion(+) + +diff --git
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hb/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 7 lines
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0+index 5b86c93..e77514e 100644 +--- a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h ++++ b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h +@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView>Quoted 8 lines
recipes-qt/qt5/
Quoted 8 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/ renamed from recipes-qt/qt5/qtdeclarative_git.bb +0
-0qtdeclarative_git.bb
Quoted 8 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 18
Quoted 8 lines
index 93442fb..9274d00 100644
recipes-qt/qt5/qtdeclarative_git.bb +1
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase" SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ +file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch \
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 21
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +0
-0" EXTRA_OEMAKE +="QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
Quoted 8 lines
Quoted 8 lines
--
2.2.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develSignature · 4 lines
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
The strange part is that examples built fine here with current master (5.5.99/5.6-beta)
without your patches.
Quoted 157 lines · Denys Dmytriyenko
Quoted 5 lines · Martin Jansa
I was testing if this is still needed with latest 5.6 currently in jansa/master. Or if I can just drop this again when upgrading to newer revisions.
Did you see this issue only with 5.6 revisions currently in master or
with
Quoted 4 lines
5.6 revisions sent by Andreas which are now in master-next and where even qtbase examples fail to build in default setup as reported in separate e-mail?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-April/107077.html
Sorry, I haven't had a chance to try master-next yet. Those patches are needed
for 5.5.99/5.6-beta from current master.If you merge 5.6 into master any time soon, I would definitely prefer for examples to work there. BTW, I can't believe examples are so broken in Qt, even in the official 5.6 release, based on your other email... So, if you want
master/krogoth to be 5.6 release, we'd have to backport example fixes from post-5.6 revs, which I would be glad to help with...--
DenysQuoted 1 line
On Mon, Apr 25, 2016 at 8:07 PM, Denys Dmytriyenko <[email protected]>
Quoted 9 lines · wrote:
Quoted 9 lines
Martin,
Any comments?
Quoted 1 line · Denys Dmytriyenko
Ping. These 2 have been sitting in master-next as well for quite some
time.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Any updates?
Quoted 3 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14:
Quoted 3 lines
Quoted 3 lines
error: 'QCoreApplication' has not been declared
Quoted 1 line
Quoted 1 line
if
(!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
Quoted 9 lines
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28++++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
diff --git
a/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 1 line
Quoted 1 line
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
new file mode 100644
index 0000000..1687fbe
---/dev/null
+++
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
Review line 1
Quoted 2 lines
(quoted diff) +1
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:002001
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +3
-0+From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication hasnot
Quoted 8 lines
Quoted 8 lines
been
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0+ declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h |1 +
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +3
-0+ 1 file changed, 1 insertion(+) + +diff --git
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hb/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 2 lines
Quoted 2 lines
(quoted diff) +2
-0+index 5b86c93..e77514e 100644 +---
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 1 line
Quoted 1 line
Quoted 1 line
Review line 17
Quoted 1 line
(quoted diff) +1
-0++++
b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 18 lines
Quoted 18 lines
Quoted 4 lines
Quoted 4 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +4
-0+@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView>Quoted 8 lines
recipes-qt/qt5/
Quoted 8 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/ renamed from recipes-qt/qt5/qtdeclarative_git.bb +0
-0qtdeclarative_git.bb
Quoted 5 lines
Quoted 5 lines
index 93442fb..9274d00 100644
recipes-qt/qt5/qtdeclarative_git.bb +0
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase"Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase"
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +1
-0SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ +file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
\
Quoted 23 lines
Quoted 17 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 21
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +0
-0" EXTRA_OEMAKE +="QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
Quoted 8 lines
Quoted 8 lines
--
2.2.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 6 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 3 lines · Martin Jansa
The strange part is that examples built fine here with current master (5.5.99/5.6-beta)
without your patches.
That is strange. Can it be toolchain-related? I'm using Linaro gcc-5.3, but I would expect OE-built gcc-5.3 to be as strict and fail similarly on those undeclared or incomplete classes...
Quoted 164 lines · Denys Dmytriyenko
Quoted 158 lines · Martin Jansa
Quoted 5 lines
I was testing if this is still needed with latest 5.6 currently in jansa/master. Or if I can just drop this again when upgrading to newer revisions.
Did you see this issue only with 5.6 revisions currently in master or
with
Quoted 4 lines
5.6 revisions sent by Andreas which are now in master-next and where even qtbase examples fail to build in default setup as reported in separate e-mail?
http://lists.openembedded.org/pipermail/openembedded-devel/2016-April/107077.html
Sorry, I haven't had a chance to try master-next yet. Those patches are needed
for 5.5.99/5.6-beta from current master.If you merge 5.6 into master any time soon, I would definitely prefer for examples to work there. BTW, I can't believe examples are so broken in Qt, even in the official 5.6 release, based on your other email... So, if you want
master/krogoth to be 5.6 release, we'd have to backport example fixes from post-5.6 revs, which I would be glad to help with...--
DenysQuoted 1 line
On Mon, Apr 25, 2016 at 8:07 PM, Denys Dmytriyenko <[email protected]>
Quoted 9 lines · wrote:
Quoted 9 lines
Martin,
Any comments?
Quoted 1 line · Denys Dmytriyenko
Ping. These 2 have been sitting in master-next as well for quite some
time.
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines
Any updates?
Quoted 3 lines · Denys Dmytriyenko
From: Denys Dmytriyenko <[email protected]>
git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp:180:14:
Quoted 3 lines
Quoted 3 lines
error: 'QCoreApplication' has not been declared
Quoted 1 line
Quoted 1 line
if
(!QCoreApplication::arguments().contains(QStringLiteral("--no_render_alpha")))
Quoted 9 lines
Quoted 9 lines
Quoted 4 lines
Quoted 4 lines
Signed-off-by Denys Dmytriyenko <[email protected]>--- ...omparison-fix-QCoreApplication-has-not-be.patch | 28++++++++++++++++++++++
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb | 1 + 2 files changed, 29 insertions(+) create mode 100644
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 3 lines
Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
diff --git
a/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 1 line
Quoted 1 line
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 5 lines
Quoted 5 lines
Quoted 4 lines
Quoted 4 lines
new file mode 100644
index 0000000..1687fbe
---/dev/null
+++
b/recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patchQuoted 2 lines
Quoted 2 lines
Quoted 2 lines
Review line 1
Quoted 2 lines
(quoted diff) +1
-0@@ -0,0 +1,28 @@ +From 1cdd3278a0b1508640d983720782d39eb919caaf Mon Sep 17 00:00:002001
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +3
-0+From: Denys Dmytriyenko <[email protected]> +Date: Thu, 31 Mar 2016 19:38:58 -0400 +Subject: [PATCH] qquickviewcomparison: fix QCoreApplication hasnot
Quoted 8 lines
Quoted 8 lines
been
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 7 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0+ declared error + +Upstream-Status: Pending + +Signed-off-by: Denys Dmytriyenko <[email protected]> +--- + examples/quick/quickwidgets/qquickviewcomparison/mainwindow.h |1 +
Quoted 7 lines
Quoted 7 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
Quoted 3 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +3
-0+ 1 file changed, 1 insertion(+) + +diff --git
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hb/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 2 lines
Quoted 2 lines
(quoted diff) +2
-0+index 5b86c93..e77514e 100644 +---
a/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 1 line
Quoted 1 line
Quoted 1 line
Review line 17
Quoted 1 line
(quoted diff) +1
-0++++
b/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.hQuoted 18 lines
Quoted 18 lines
Quoted 4 lines
Quoted 4 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +4
-0+@@ -44,6 +44,7 @@ + #include <QWidget> + #include <QQuickWidget> + #include <QQuickView>Quoted 8 lines
recipes-qt/qt5/
Quoted 8 lines
recipes-qt/qt5/qtdeclarative/0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch new file +7
-0++#include <QCoreApplication> + + QT_FORWARD_DECLARE_CLASS(QRadioButton) + QT_FORWARD_DECLARE_CLASS(QCheckBox) +-- +2.2.0 +recipes-qt/qt5/ renamed from recipes-qt/qt5/qtdeclarative_git.bb +0
-0qtdeclarative_git.bb
Quoted 5 lines
Quoted 5 lines
index 93442fb..9274d00 100644
recipes-qt/qt5/qtdeclarative_git.bb +0
-0@@ -15,6 +15,7 @@ DEPENDS += "qtbase"Quoted 4 lines
Quoted 4 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase"
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +1
-0SRC_URI += " \ file://0001-qmltestexample-fix-link.patch \ +file://0001-qquickviewcomparison-fix-QCoreApplication-has-not-be.patch
\
Quoted 23 lines
Quoted 17 lines
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb DEPENDS += "qtbase" · line 21
Quoted 3 lines
recipes-qt/qt5/qtdeclarative_git.bb +0
-0" EXTRA_OEMAKE +="QMAKE_SYNCQT=${STAGING_BINDIR_NATIVE}${QT_DIR_NAME}/syncqt"
Quoted 8 lines
Quoted 8 lines
--
2.2.0--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 6 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develQuoted 5 lines
--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-develSignature · 4 lines
_______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 11 lines · Denys Dmytriyenko
Quoted 3 lines · Martin Jansa
The strange part is that examples built fine here with current master (5.5.99/5.6-beta)
without your patches.That is strange. Can it be toolchain-related? I'm using Linaro gcc-5.3, but I would expect OE-built gcc-5.3 to be as strict and fail similarly on those undeclared or incomplete classes…
can both of you paste the <gcc> -E -dM output of this file in question ?
Quoted 8 lines · Khem Raj
Quoted 8 lines · Denys Dmytriyenko
Quoted 3 lines · Martin Jansa
The strange part is that examples built fine here with current master (5.5.99/5.6-beta)
without your patches.
Quoted 7 lines
Quoted 3 lines
That is strange. Can it be toolchain-related? I'm using Linaro gcc-5.3, but I would expect OE-built gcc-5.3 to be as strict and fail similarly on those undeclared or incomplete classes…
can both of you paste the <gcc> -E -dM output of this file in question ?
i586-oe-linux-g++ -m32 -march=i586 --sysroot=/OE/build/oe-core/tmp-glibc/sysroots/qemux86 -c -pipe -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0=/usr/src/debug/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0 -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/sysroots/x86_64-linux= -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/sysroots/qemux86= -fvisibility-inlines-hidden -O2 -std=gnu++0x -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DQT_NO_MTDEV -DQT_NO_TSLIB -DQT_NO_LIBINPUT -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_QML_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I/OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0/git/examples/quick/quickwidgets/qquickviewcomparison -I. -I../../../../include -I../../../../include/QtQuickWidgets -I../../../../include/QtQuick -I../../../../include/QtQml -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5 -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtWidgets -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtGui -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtNetwork -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtCore -I.moc -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/libdrm -I/OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/lib/qt5/mkspecs/linux-oe-g++ -o .obj/mainwindow.o /OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0/git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cpp
and mainwindow.E is attached
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
7,907 lines not shown · raw message
Part of this message is not shown here. View the raw message.
Quoted 13 lines · Martin Jansa
Quoted 12 lines · Khem Raj
Quoted 11 lines · Denys Dmytriyenko
Quoted 3 lines · Martin Jansa
The strange part is that examples built fine here with current master (5.5.99/5.6-beta)
without your patches.That is strange. Can it be toolchain-related? I'm using Linaro gcc-5.3, but I would expect OE-built gcc-5.3 to be as strict and fail similarly on those undeclared or incomplete classes…
Quoted 8 lines
Quoted 3 lines
can both of you paste the <gcc> -E -dM output of this file in question ?
i586-oe-linux-g++ -m32 -march=i586 --sysroot=/OE/build/oe-core/tmp-glibc/sysroots/qemux86 -c -pipe -O2 -pipe -g -feliminate-unused-debug-types -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0=/usr/src/debug/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0 -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/sysroots/x86_64-linux= -fdebug-prefix-map=/OE/build/oe-core/tmp-glibc/sysroots/qemux86= -fvisibility-inlines-hidden -O2 -std=gnu++0x -fno-exceptions -Wall -W -D_REENTRANT -fPIC -DQT_NO_MTDEV -DQT_NO_TSLIB -DQT_NO_LIBINPUT -DQT_NO_EXCEPTIONS -D_LARGEFILE64_SOURCE -D_LARGEFILE_SOURCE -DQT_NO_DEBUG -DQT_QUICKWIDGETS_LIB -DQT_QUICK_LIB -DQT_QML_LIB -DQT_WIDGETS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_CORE_LIB -I/OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0/git/examples/quick/quickwidgets/qquickviewcomparison -I. -I../../../../include -I../../../../include/QtQuickWidgets -I../../../.
./include/QtQuick-I../../../../include/QtQml -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5 -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtWidgets -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtGui -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtNetwork -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/qt5/QtCore -I.moc -isystem /OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/include/libdrm -I/OE/build/oe-core/tmp-glibc/sysroots/qemux86/usr/lib/qt5/mkspecs/linux-oe-g++ -o.obj/mainwindow.o/OE/build/oe-core/tmp-glibc/work/i586-oe-linux/qtdeclarative/5.5.99+5.6.0-rc+gitAUTOINC+0fab5761d5-r0/git/examples/quick/quickwidgets/qquickviewcomparison/mainwindow.cppand mainwindow.E is attached
Sorry for the delay.
Can you please provide more detailed instructions in order to get this output?
Signature · 1 line
Denys