drm/i915/bxt: Set max cdclk frequency properly
Subsystems (2)
PATCH 1/1 drm/i915/bxt: Set max cdclk frequency properly
intel_update_max_cdclk() doesn't have a switch case for Broxton, so dev_priv->max_cdclk_freq gets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This causes our max dotclock to also be set too low and in turn leads mode verification to reject perfectly valid modes while loading EDID firmware blobs.
--- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/gpu/drm/i915/intel_display.c +2 -0
@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq =450000 ; else dev_priv->max_cdclk_freq = 337500; + }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ; }else if (IS_BROADWELL (dev)) {/* * FIXME with extra cooling we can allow
Signature · 6 lines
2.1.4 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 10 lines · Matt Roper
intel_update_max_cdclk()doesn't have a switch case for Broxton, sodev_priv->max_cdclk_freqgets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This causes our max dotclock to also be set too low and in turn leads mode verification to reject perfectly valid modes while loading EDID firmware blobs.Cc Imre Deak <[email protected]>Signed-off-by Matt Roper <[email protected]>---
One thing I should have mentioned is that it's unclear to me whether we should be looking at the cdclk limit bits in the DFSM register like we do on SKL/KBL. The bspec seems to indicate that the register in general applies to gen9, including BXT, but the actual meaning of the bits doesn't match up with the frequencies we have on BXT.
Matt
Quoted 19 lines
drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +2
-0@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq =450000 ; else dev_priv->max_cdclk_freq = 337500; + }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ; }else if (IS_BROADWELL (dev)) {/* * FIXME with extra cooling we can allow Signature · 1 line
2.1.4
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 12 lines · Matt Roper
Quoted 10 lines · Matt Roper
intel_update_max_cdclk()doesn't have a switch case for Broxton, sodev_priv->max_cdclk_freqgets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This causes our max dotclock to also be set too low and in turn leads mode verification to reject perfectly valid modes while loading EDID firmware blobs.Cc Imre Deak <[email protected]>Signed-off-by Matt Roper <[email protected]>---
Quoted 5 lines
One thing I should have mentioned is that it's unclear to me whether we should be looking at the cdclk limit bits in the DFSM register like we do on SKL/KBL. The bspec seems to indicate that the register in general applies to gen9, including BXT, but the actual meaning of the bits doesn't match up with the frequencies we have on BXT.
It also says
"This field is unused on BXT. Any CD clock frequency limitation must be done in software."
Anyway the DFSM story is apparently a sad one. See the discussion eg. in
https://lists.freedesktop.org/archives/intel-gfx/2016-February/087510.html
would be nice if someone could pick that up and figure out what we really want/need to do.
Quoted 34 lines
Matt
Quoted 19 lines
drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +2
-0@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq =450000 ; else dev_priv->max_cdclk_freq = 337500; + }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ; }else if (IS_BROADWELL (dev)) {/* * FIXME with extra cooling we can allow Signature · 1 line
2.1.4Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signature · 6 lines
Ville Syrjälä Intel OTC _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 19 lines · Ville Syrjälä
Quoted 12 lines · Matt Roper
Quoted 10 lines · Matt Roper
intel_update_max_cdclk()doesn't have a switch case for Broxton, sodev_priv->max_cdclk_freqgets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This causes our max dotclock to also be set too low and in turn leads mode verification to reject perfectly valid modes while loading EDID firmware blobs.Cc Imre Deak <[email protected]>Signed-off-by Matt Roper <[email protected]>---
Quoted 5 lines
One thing I should have mentioned is that it's unclear to me whether we should be looking at the cdclk limit bits in the DFSM register like we do on SKL/KBL. The bspec seems to indicate that the register in general applies to gen9, including BXT, but the actual meaning of the bits doesn't match up with the frequencies we have on BXT.
Quoted 8 lines
It also says
"This field is unused on BXT. Any CD clock frequency limitation must be done in software."Anyway the DFSM story is apparently a sad one. See the discussion eg. in
https://lists.freedesktop.org/archives/intel-gfx/2016-February/087510.html
would be nice if someone could pick that up and figure out what we really want/need to do.
Oh strange; the note about being unused for BXT gets hidden if you're filtering the bspec on BXT. I have to remove the filter to see it. Seems a bit backwards...
Thanks for the confirmation and background.
Matt
Quoted 39 lines
Quoted 35 lines
Matt
Quoted 19 lines
drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +2
-0@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq =450000 ; else dev_priv->max_cdclk_freq = 337500; + }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ; }else if (IS_BROADWELL (dev)) {/* * FIXME with extra cooling we can allow Signature · 1 line
2.1.4Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfxSignature · 2 lines
Ville Syrjälä Intel OTC
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Imre Deak
Reviewed-byQuoted 15 lines · Matt Roper
Quoted 10 lines · Matt Roper
intel_update_max_cdclk()doesn't have a switch case for Broxton, sodev_priv->max_cdclk_freqgets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This
causes our max dotclock to also be set too low and in turn leads mode
verification to reject perfectly valid modes while loading EDID firmware
blobs.Quoted 3 lines
Cc Imre Deak <[email protected]>Signed-off-by Matt Roper <[email protected]>---
Quoted 5 lines
One thing I should have mentioned is that it's unclear to me whether we should be looking at the cdclk limit bits in the DFSM register like we do on SKL/KBL. The bspec seems to indicate that the register in general applies to gen9, including BXT, but the actual meaning of the bits doesn't match up with the frequencies we have on BXT.
Yes, vendors could restrict the max CDCLK frequency via some method, but we don't have that mechanism in place anyway and we would use the hard-coded 624MHz if BIOS didn't enable CDCLK. So this is a correct fix for now:
Quoted 17 lines
Matt
Quoted 13 lines
drivers/gpu/drm/i915/intel_display.c | 2 ++
1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq = 450000;else
dev_priv->max_cdclk_freq= 337500;
Quoted 9 lines
Quoted 8 lines
drivers/gpu/drm/i915/intel_display.c +2
-0+ }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ;} else if (IS_BROADWELL(dev)) {
/*
* FIXME with extra cooling we can allowSignature · 1 line
2.1.4
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 22 lines · Imre Deak
Quoted 15 lines · Matt Roper
Quoted 10 lines · Matt Roper
intel_update_max_cdclk()doesn't have a switch case for Broxton, sodev_priv->max_cdclk_freqgets set to whatever clock frequency we're currently running at (e.g., 144 MHz) rather than the true maximum. This
causes our max dotclock to also be set too low and in turn leads mode
verification to reject perfectly valid modes while loading EDID firmware
blobs.Quoted 3 lines
Cc Imre Deak <[email protected]>Signed-off-by Matt Roper <[email protected]>---
Quoted 5 lines
One thing I should have mentioned is that it's unclear to me whether we should be looking at the cdclk limit bits in the DFSM register like we do on SKL/KBL. The bspec seems to indicate that the register in general applies to gen9, including BXT, but the actual meaning of the bits doesn't match up with the frequencies we have on BXT.
Quoted 6 lines
Yes, vendors could restrict the max CDCLK frequency via some method, but we don't have that mechanism in place anyway and we would use the hard-coded 624MHz if BIOS didn't enable CDCLK. So this is a correct fix for now:
Reviewed-by Imre Deak <[email protected]>
Thanks for the review. Pushed to dinq.
Matt
Quoted 27 lines
Quoted 27 lines
Matt
Quoted 21 lines
drivers/gpu/drm/i915/intel_display.c | 2 ++
1 file changed, 2 insertions(+)drivers/gpu/drm/i915/intel_display.c +0
-0@@ -5261,6 +5261,8 @@ static void intel_update_max_cdclk(struct drm_device *dev) dev_priv->max_cdclk_freq = 450000;else
dev_priv->max_cdclk_freq= 337500;drivers/gpu/drm/i915/intel_display.c +2
-0+ }else if (IS_BROXTON (dev)) { + dev_priv->max_cdclk_freq =624000 ;} else if (IS_BROADWELL(dev)) {
/*
* FIXME with extra cooling we can allowSignature · 1 line
2.1.4
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/i915/bxt: Set max cdclk frequency properly
In reply to Matt Roper== Series Details ==
== Series Details ==
Series: drm/i915/bxt: Set max cdclk frequency properly
URL : https://patchwork.freedesktop.org/series/5348/
State : failure
== Summary ==
Series 5348v1 drm/i915/bxt: Set max cdclk frequency properly
http://patchwork.freedesktop.org/api/1.0/series/5348/revisions/1/mbox/
Test gem_sync:
Subgroup basic-all:
dmesg-fail -> PASS (bsw-nuc-2)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
dmesg-warn -> PASS (ilk-hp8440p) UNSTABLE
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (bsw-nuc-2)
Test kms_force_connector_basic:
Subgroup prune-stale-modes:
skip -> PASS (ivb-t430s)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-c:
dmesg-warn -> PASS (bsw-nuc-2)bdw-nuci7 total:196 pass:184 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:196 pass:175 dwarn:0 dfail:0 fail:0 skip:21 bsw-nuc-2 total:196 pass:158 dwarn:0 dfail:0 fail:1 skip:37 byt-nuc total:196 pass:161 dwarn:0 dfail:0 fail:0 skip:35 hsw-brixbox total:196 pass:174 dwarn:0 dfail:0 fail:0 skip:22 hsw-gt2 total:196 pass:179 dwarn:0 dfail:0 fail:0 skip:17 ilk-hp8440p total:196 pass:132 dwarn:0 dfail:0 fail:0 skip:64 ivb-t430s total:196 pass:171 dwarn:0 dfail:0 fail:0 skip:25 skl-i7k-2 total:196 pass:173 dwarn:0 dfail:0 fail:0 skip:23 skl-nuci5 total:196 pass:185 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:196 pass:162 dwarn:0 dfail:0 fail:0 skip:34 snb-x220t total:196 pass:162 dwarn:0 dfail:0 fail:1 skip:33
Results at /archive/results/CI_IGT_test/Patchwork_1811/
12899f13b8ee9a4944f167a08e4db0526a3f3855 drm-intel-nightly: 2016y-04m-05d-19h-09m-25s UTC integration manifest 65c53e538f64d2242ed44e62134c4f73d6737590 drm/i915/bxt: Set max cdclk frequency properly
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: ✗ Fi.CI.BAT: failure for drm/i915/bxt: Set max cdclk frequency properly
Quoted 11 lines · Patchwork
== Series Details ==
Series: drm/i915/bxt: Set max cdclk frequency properly
URL : https://patchwork.freedesktop.org/series/5348/
State : failure== Summary ==
Series 5348v1 drm/i915/bxt: Set max cdclk frequency properly
http://patchwork.freedesktop.org/api/1.0/series/5348/revisions/1/mbox/
Quoted 8 lines
Test
gem_sync:Subgroup basic-all: dmesg-fail -> PASS (bsw-nuc-2) Test kms_flip: Subgroup basic-flip-vs-dpms: dmesg-warn -> PASS (ilk-hp8440p) UNSTABLE Subgroup basic-flip-vs-wf_vblank: pass -> FAIL (bsw-nuc-2)
https://bugs.freedesktop.org/show_bug.cgi?id=94294
Quoted 25 lines
Test
kms_force_connector_basic:Subgroup prune-stale-modes: skip -> PASS (ivb-t430s) Test kms_pipe_crc_basic: Subgroup suspend-read-crc-pipe-c: dmesg-warn -> PASS (bsw-nuc-2)bdw-nuci7 total:196 pass:184 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:196 pass:175 dwarn:0 dfail:0 fail:0 skip:21 bsw-nuc-2 total:196 pass:158 dwarn:0 dfail:0 fail:1 skip:37 byt-nuc total:196 pass:161 dwarn:0 dfail:0 fail:0 skip:35 hsw-brixbox total:196 pass:174 dwarn:0 dfail:0 fail:0 skip:22 hsw-gt2 total:196 pass:179 dwarn:0 dfail:0 fail:0 skip:17 ilk-hp8440p total:196 pass:132 dwarn:0 dfail:0 fail:0 skip:64 ivb-t430s total:196 pass:171 dwarn:0 dfail:0 fail:0 skip:25 skl-i7k-2 total:196 pass:173 dwarn:0 dfail:0 fail:0 skip:23 skl-nuci5 total:196 pass:185 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:196 pass:162 dwarn:0 dfail:0 fail:0 skip:34 snb-x220t total:196 pass:162 dwarn:0 dfail:0 fail:1 skip:33Results at /archive/results/CI_IGT_test/Patchwork_1811/
12899f13b8ee9a4944f167a08e4db0526a3f3855drm-intel-nightly: 2016y-04m-05d-19h-09m-25s UTC integration manifest65c53e538f64d2242ed44e62134c4f73d6737590drm/i915/bxt: Set max cdclk frequency properly
Signature · 9 lines
Matt Roper Graphics Software Engineer IoTG Platform Enabling & Development Intel Corporation (916) 356-2795 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx