Skip to contentSkip to conversation

cppc_cpufreq

DISCUSSION Pandruvada, Srinivas 3 participants 5 messages Apr 7, 2016 – Apr 11, 2016

lore
Share & tools
lore
#0 lore raw

Hi Ashwin,

I didn't see in the cppc_cpufreq.c

MODULE_LICENSE()

Is it intentional?

Thanks,
Srinivas

#1 lore raw
Quoted 7 lines · Srinivas

Hi Ashwin,

I didn't see in the cppc_cpufreq.c

MODULE_LICENSE()

Is it intentional?

Not intentional. Doesn't the absence of this default to GPLv2? or is it required that the license be explicitly stated?

Thanks,
Ashwin.

#2 lore raw
Quoted 4 lines · Ashwin Chaugule
Quoted 2 lines · Srinivas

Hi Ashwin,

Quoted 9 lines
Quoted 5 lines

I didn't see in the cppc_cpufreq.c

MODULE_LICENSE()

Is it intentional?

Not intentional. Doesn't the absence of this default to GPLv2? or is it required that the license be explicitly stated?

You are using symbols exported using EXPORT_SYMBOL_GPL

I get following error during insmod:

[   33.400861] cppc_cpufreq: module verification failed: signature and/or required key missing - tainting kernel
[   33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver (err 0)
[   33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err 0) [   33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err 0) [   33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end (err 0)
[   33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err 0) [   33.400945] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_begin (err 0)
[   33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)

I had to add MODULE_LICENSE(GPL).

Thanks,
Srinivas

Quoted 3 lines

Thanks,
Ashwin.

#3 lore raw
Quoted 31 lines · Srinivas Pandruvada
Quoted 4 lines · Ashwin Chaugule
Quoted 2 lines · Srinivas

Hi Ashwin,

Quoted 9 lines
Quoted 5 lines

I didn't see in the cppc_cpufreq.c

MODULE_LICENSE()

Is it intentional?

Not intentional. Doesn't the absence of this default to GPLv2? or is it required that the license be explicitly stated?

You are using symbols exported using EXPORT_SYMBOL_GPL

I get following error during insmod:

[   33.400861] cppc_cpufreq: module verification failed: signature
and/or required key missing - tainting kernel
[   33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver
(err 0)
[   33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err 0)
[   33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err 0)
[   33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end
(err 0)
[   33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err 0)
[   33.400945] cppc_cpufreq: Unknown symbol
cpufreq_freq_transition_begin (err 0)
[   33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)
Quoted 1 line

I had to add MODULE_LICENSE(GPL).

Ok. Thanks for the heads up. Will post a patch soon, unless you want to go ahead and send yours out.

Thanks,
Ashwin.

#4 lore raw
Quoted 38 lines · Ashwin Chaugule
Quoted 36 lines · Srinivas Pandruvada
Quoted 6 lines · Ashwin Chaugule
Quoted 4 lines · Srinivas

Hi Ashwin,

I didn't see in the cppc_cpufreq.c

Quoted 8 lines
Quoted 3 lines

MODULE_LICENSE()

Is it intentional?

Not intentional. Doesn't the absence of this default to GPLv2? or is
it required that the license be explicitly stated?

You are using symbols exported using EXPORT_SYMBOL_GPL

I get following error during insmod:

[   33.400861] cppc_cpufreq: module verification failed: signature and/or required key missing - tainting kernel
[   33.400890] cppc_cpufreq: Unknown symbol cpufreq_register_driver (err 0)
[   33.400901] cppc_cpufreq: Unknown symbol cppc_get_perf_ctrs (err
0)
[   33.400914] cppc_cpufreq: Unknown symbol acpi_get_psd_map (err
0)
[   33.400924] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_end
(err 0)
[   33.400935] cppc_cpufreq: Unknown symbol cppc_get_perf_caps (err
0)
[   33.400945] cppc_cpufreq: Unknown symbol cpufreq_freq_transition_begin (err 0)
[   33.400954] cppc_cpufreq: Unknown symbol cppc_set_perf (err 0)

Quoted 4 lines
Quoted 1 line

I had to add MODULE_LICENSE(GPL).

Ok. Thanks for the heads up. Will post a patch soon, unless you want to go ahead and send yours out.

This is license, so I prefer you post.
I will post other changes to CPPC for x86 once I am ready.

Thanks,
Srinivas

Quoted 3 lines

Thanks,
Ashwin.