Patch "crypto: ux500 - fix checks of error code returned by devm_ioremap_resource()" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
crypto: ux500 - fix checks of error code returned by devm_ioremap_resource()
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-ux500-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
b62917a2622ebcb03a500ef20da47be80d8c8951Mon Sep 17 00:00:00 2001
From: Vladimir Zapolskiy <[email protected]>
Date: Sun, 6 Mar 2016 03:22:04 +0200
Subject: crypto: ux500 - fix checks of error code returned by devm_ioremap_resource()
From: Vladimir Zapolskiy <[email protected]>
commit b62917a2622ebcb03a500ef20da47be80d8c8951 upstream.
The change fixes potential oops while accessing iomem on invalid address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never returns NULL, which makes useless a following check for NULL.
--- drivers/crypto/ux500/cryp/cryp_core.c | 4 ++-- drivers/crypto/ux500/hash/hash_core.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/crypto/ux500/cryp/cryp_core.c +2 -2
@@ -1440,9 +1440,9 @@ static int ux500_cryp_probe(struct platf device_data->phybase = res->start; device_data->base =devm_ioremap_resource (dev, res); -if (!device_data->base) { +if (IS_ERR (device_data->base)) {dev_err (dev,"[%s]: ioremap failed!" , __func__); - ret = -ENOMEM ; + ret =PTR_ERR (device_data->base); goto out; }
drivers/crypto/ux500/hash/hash_core.c +2 -2
@@ -1675,9 +1675,9 @@ static int ux500_hash_probe(struct platf device_data->phybase = res->start; device_data->base =devm_ioremap_resource (dev, res); -if (!device_data->base) { +if (IS_ERR (device_data->base)) {dev_err (dev,"%s: ioremap() failed!\n" , __func__); - ret = -ENOMEM ; + ret =PTR_ERR (device_data->base); goto out; }spin_lock_init (&device_data->ctx_lock);
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/crypto-atmel-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch queue-4.4/crypto-ux500-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch