Patch "crypto: atmel - fix checks of error code returned by devm_ioremap_resource()" has been added to the 4.5-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
crypto: atmel - fix checks of error code returned by devm_ioremap_resource()
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
crypto-atmel-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
9b52d55f4f0e2bb9a34abbcf99e05e17f1b3b281Mon Sep 17 00:00:00 2001
From: Vladimir Zapolskiy <[email protected]>
Date: Sun, 6 Mar 2016 03:21:52 +0200
Subject: crypto: atmel - fix checks of error code returned by devm_ioremap_resource()
From: Vladimir Zapolskiy <[email protected]>
commit 9b52d55f4f0e2bb9a34abbcf99e05e17f1b3b281 upstream.
The change fixes potential oops while accessing iomem on invalid address, if devm_ioremap_resource() fails due to some reason.
The devm_ioremap_resource() function returns ERR_PTR() and never returns NULL, which makes useless a following check for NULL.
--- drivers/crypto/atmel-aes.c | 4 ++-- drivers/crypto/atmel-sha.c | 4 ++-- drivers/crypto/atmel-tdes.c | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-)
drivers/crypto/atmel-aes.c +2 -2
@@ -2085,9 +2085,9 @@ static int atmel_aes_probe(struct platfo } aes_dd->io_base =devm_ioremap_resource (&pdev->dev, aes_res); -if (!aes_dd->io_base) { +if (IS_ERR (aes_dd->io_base)) {dev_err (dev,"can't ioremap\n" ); - err = -ENOMEM ; + err =PTR_ERR (aes_dd->io_base); goto res_err; }
drivers/crypto/atmel-sha.c +2 -2
@@ -1404,9 +1404,9 @@ static int atmel_sha_probe(struct platfo } sha_dd->io_base =devm_ioremap_resource (&pdev->dev, sha_res); -if (!sha_dd->io_base) { +if (IS_ERR (sha_dd->io_base)) {dev_err (dev,"can't ioremap\n" ); - err = -ENOMEM ; + err =PTR_ERR (sha_dd->io_base); goto res_err; }
drivers/crypto/atmel-tdes.c +2 -2
@@ -1417,9 +1417,9 @@ static int atmel_tdes_probe(struct platf } tdes_dd->io_base =devm_ioremap_resource (&pdev->dev, tdes_res); -if (!tdes_dd->io_base) { +if (IS_ERR (tdes_dd->io_base)) {dev_err (dev,"can't ioremap\n" ); - err = -ENOMEM ; + err =PTR_ERR (tdes_dd->io_base); goto res_err; }
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/crypto-atmel-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch queue-4.5/crypto-ux500-fix-checks-of-error-code-returned-by-devm_ioremap_resource.patch