Skip to contentSkip to conversation

Patch "HID: fix hid_ignore_special_drivers module parameter" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 10, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

HID: fix hid_ignore_special_drivers module parameter

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
hid-fix-hid_ignore_special_drivers-module-parameter.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 4392bf333388cabdad5afe5b1500002d7b9c318e Mon Sep 17 00:00:00 2001

From: Benjamin Tissoires <[email protected]>
Date: Fri, 12 Feb 2016 17:10:37 +0100
Subject: HID: fix hid_ignore_special_drivers module parameter

From: Benjamin Tissoires <[email protected]>

commit 4392bf333388cabdad5afe5b1500002d7b9c318e upstream.

hid_ignore_special_drivers works fine until hid_scan_report autodetects and reassign devices (for hid-multitouch, hid-microsoft and hid-rmi).

Simplify the handling of the parameter: if it is there, use hid-generic, no matter what, and if not, scan the device or rely on the hid_have_special_driver table.

This was detected while trying to disable hid-multitouch on a Surface Pro cover which prevented to use the keyboard.

---
 drivers/hid/hid-core.c |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
drivers/hid/hid-core.c +4 -3
@@ -2616,9 +2616,10 @@ int hid_add_device(struct hid_device *hd
 	/*
 	 * Scan generic devices for group information
 	 */
-	if (hid_ignore_special_drivers ||
-	    (!hdev->group &&
-	     !hid_match_id(hdev, hid_have_special_driver))) {
+	if (hid_ignore_special_drivers) {
+		hdev->group = HID_GROUP_GENERIC;
+	} else if (!hdev->group &&
+		   !hid_match_id(hdev, hid_have_special_driver)) {
 		ret = hid_scan_report(hdev);
 		if (ret)
 			hid_warn(hdev, "bad device descriptor (%d)\n", ret);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/hid-multitouch-force-retrieving-of-win8-signature-blob.patch queue-4.4/hid-fix-hid_ignore_special_drivers-module-parameter.patch queue-4.4/hid-i2c-hid-fix-oob-write-in-i2c_hid_set_or_send_report.patch