Skip to contentSkip to conversation

tty: Remove unused TTY_NUMBER() macro

PATCH In review Peter Hurley 2 participants 4 messages Apr 10, 2016 TTY layer and serial drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/2 tty: Remove unused TTY_NUMBER() macro

TTY_NUMBER() has been unused since v2.5.71; removed by "[PATCH] callout removal: callout is gone".

---
 drivers/tty/tty_io.c | 3 ---
 1 file changed, 3 deletions(-)
drivers/tty/tty_io.c +0 -3
index 320dc4d..3cdd63b 100644
@@ -230,9 +230,6 @@ static void tty_del_file(struct file *file)
 	tty_free_file(file);
 }
 
-
-#define TTY_NUMBER(tty) ((tty)->index + (tty)->driver->name_base)
-
 /**
  *	tty_name	-	return tty naming
  *	@tty: tty structure
Signature · 1 line
2.8.1
#1 lore raw

PATCH 2/2 tty: Remove stale parameter comment

noctty was removed as a parameter by commit 216513411937586 ("tty: Consolidate noctty check in tty_open()").

---
 drivers/tty/tty_io.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/tty_io.c +0 -1
index 3cdd63b..50979be 100644
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
  *	tty_lookup_driver - lookup a tty driver for a given device file
  *	@device: device number
  *	@filp: file pointer to tty
- *	@noctty: set if the device should not become a controlling tty
  *	@index: index for the device in the @return driver
  *	@return: driver for this inode (with increased refcount)
  *
Signature · 1 line
2.8.1
#2 lore raw

Re: [PATCH 2/2] tty: Remove stale parameter comment

Quoted 1 line · Peter Hurley

noctty was removed as a parameter by commit 216513411937586

It is actually 11e1d4aa4da.

Quoted 20 lines

("tty: Consolidate noctty check in tty_open()").

---
 drivers/tty/tty_io.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/tty_io.c +0 -1
index 3cdd63b..50979be 100644
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
  *	tty_lookup_driver - lookup a tty driver for a given device file
  *	@device: device number
  *	@filp: file pointer to tty
- *	@noctty: set if the device should not become a controlling tty
  *	@index: index for the device in the @return driver
  *	@return: driver for this inode (with increased refcount)
  *
Signature · 2 lines
js
suse labs
#3 lore raw

Re: [PATCH 2/2] tty: Remove stale parameter comment

Quoted 4 lines · Jiri Slaby
Quoted 1 line · Peter Hurley

noctty was removed as a parameter by commit 216513411937586

It is actually 11e1d4aa4da.

Right; not sure where that number came from.

Quoted 23 lines
Quoted 21 lines

("tty: Consolidate noctty check in tty_open()").

---
 drivers/tty/tty_io.c | 1 -
 1 file changed, 1 deletion(-)
drivers/tty/tty_io.c +0 -1
index 3cdd63b..50979be 100644
@@ -1960,7 +1960,6 @@ static struct tty_struct *tty_open_current_tty(dev_t device, struct file *filp)
  *	tty_lookup_driver - lookup a tty driver for a given device file
  *	@device: device number
  *	@filp: file pointer to tty
- *	@noctty: set if the device should not become a controlling tty
  *	@index: index for the device in the @return driver
  *	@return: driver for this inode (with increased refcount)
  *