Skip to contentSkip to conversation

Patch "quota: Fix possible GPF due to uninitialised pointers" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 10, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

quota: Fix possible GPF due to uninitialised pointers

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
quota-fix-possible-gpf-due-to-uninitialised-pointers.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From ab73ef46398e2c0159f3a71de834586422d2a44a Mon Sep 17 00:00:00 2001

From: Nikolay Borisov <[email protected]>
Date: Thu, 3 Mar 2016 10:54:57 +0100
Subject: quota: Fix possible GPF due to uninitialised pointers

From: Nikolay Borisov <[email protected]>

commit ab73ef46398e2c0159f3a71de834586422d2a44a upstream.

When dqget() in __dquot_initialize() fails e.g. due to IO error, __dquot_initialize() will pass an array of uninitialized pointers to dqput_all() and thus can lead to deference of random data. Fix the problem by properly initializing the array.

---
 fs/quota/dquot.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
fs/quota/dquot.c +1 -2
@@ -1398,7 +1398,7 @@ static int dquot_active(const struct ino
 static int __dquot_initialize(struct inode *inode, int type)
 {
 	int cnt, init_needed = 0;
-	struct dquot **dquots, *got[MAXQUOTAS];
+	struct dquot **dquots, *got[MAXQUOTAS] = {};
 	struct super_block *sb = inode->i_sb;
 	qsize_t rsv;
 	int ret = 0;
@@ -1415,7 +1415,6 @@ static int __dquot_initialize(struct ino
 		int rc;
 		struct dquot *dquot;
 
-		got[cnt] = NULL;
 		if (type != -1 && cnt != type)
 			continue;
 		/*

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/quota-fix-possible-gpf-due-to-uninitialised-pointers.patch queue-4.4/ib-ipoib-fix-for-rare-multicast-join-race-condition.patch