Skip to contentSkip to conversation

drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

PATCH New [email protected] 2 participants 2 messages Apr 12, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

From: Tim Gore <[email protected]>

WaEnableSamplerGPGPUPreemptionSupport fixes a problem related to mid thread pre-emption.

---
 drivers/gpu/drm/i915/i915_reg.h         | 1 +
 drivers/gpu/drm/i915/intel_ringbuffer.c | 7 ++++---
 2 files changed, 5 insertions(+), 3 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +1 -0
index cea5a39..ff83c64 100644
@@ -7161,6 +7161,7 @@ enum skl_disp_power_wells {
 
 #define GEN9_HALF_SLICE_CHICKEN7	_MMIO(0xe194)
 #define   GEN9_ENABLE_YV12_BUGFIX	(1<<4)
+#define   GEN9_ENABLE_GPGPU_PREEMPTION	(1<<2)
 
 /* Audio */
 #define G4X_AUD_VID_DID			_MMIO(dev_priv->info.display_mmio_offset + 0x62020)
drivers/gpu/drm/i915/intel_ringbuffer.c +4 -3
index 41b604e..c2603f7 100644
@@ -959,9 +959,10 @@ static int gen9_init_workarounds(struct intel_engine_cs *engine)
 	}
 
 	/* WaEnableYV12BugFixInHalfSliceChicken7:skl,bxt */
-	if (IS_SKL_REVID(dev, SKL_REVID_C0, REVID_FOREVER) || IS_BROXTON(dev))
-		WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
-				  GEN9_ENABLE_YV12_BUGFIX);
+	/* WaEnableSamplerGPGPUPreemptionSupport:skl,bxt */
+	WA_SET_BIT_MASKED(GEN9_HALF_SLICE_CHICKEN7,
+			  GEN9_ENABLE_YV12_BUGFIX |
+			  GEN9_ENABLE_GPGPU_PREEMPTION);
 
 	/* Wa4x4STCOptimizationDisable:skl,bxt */
 	/* WaDisablePartialResolveInVc:skl,bxt */
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev3)

== Series Details ==

== Series Details ==

Series: drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport (rev3)
URL : https://patchwork.freedesktop.org/series/5367/
State : failure

== Summary ==

Series 5367v3 drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport
http://patchwork.freedesktop.org/api/1.0/series/5367/revisions/3/mbox/

Test drv_getparams_basic:

        Subgroup basic-subslice-total:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_basic:
        Subgroup create-close:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_ctx_exec:
        Subgroup basic:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_ctx_param_basic:
        Subgroup invalid-param-get:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup root-set:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_ctx_switch:
        Subgroup basic-default:
                pass       -> SKIP       (bsw-nuc-2)
Test gem_exec_basic:
        Subgroup basic-blt:
                pass       -> SKIP       (bsw-nuc-2)
        Subgroup basic-render:
                pass       -> SKIP       (bsw-nuc-2)
        Subgroup readonly-blt:
                pass       -> SKIP       (bsw-nuc-2)
Test gem_exec_create:
        Subgroup basic:
                pass       -> SKIP       (bsw-nuc-2)
Test gem_exec_store:
        Subgroup basic-blt:
                pass       -> SKIP       (bsw-nuc-2)
Test gem_mmap:
        Subgroup basic-small-bo:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_mmap_gtt:
        Subgroup basic-copy:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup basic-read:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup basic-write-read-distinct:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_pread:
        Subgroup basic:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_pwrite:
        Subgroup basic:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test gem_storedw_loop:
        Subgroup basic-bsd:
                pass       -> SKIP       (bsw-nuc-2)
        Subgroup basic-render:
                pass       -> SKIP       (bsw-nuc-2)
Test gem_sync:
        Subgroup basic-render:
                pass       -> INCOMPLETE (bsw-nuc-2)
Test kms_addfb_basic:
        Subgroup bad-pitch-128:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup bad-pitch-256:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup clobberred-modifier:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup size-max:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup unused-offsets:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test kms_flip:
        Subgroup basic-flip-vs-dpms:
                pass       -> DMESG-FAIL (bsw-nuc-2)
        Subgroup basic-flip-vs-modeset:
                pass       -> DMESG-FAIL (bsw-nuc-2)
                pass       -> DMESG-WARN (skl-i7k-2)
Test kms_pipe_crc_basic:
        Subgroup bad-nb-words-3:
                pass       -> DMESG-WARN (bsw-nuc-2)
        Subgroup hang-read-crc-pipe-a:
                pass       -> INCOMPLETE (snb-dellxps)
        Subgroup read-crc-pipe-c-frame-sequence:
                pass       -> DMESG-FAIL (bsw-nuc-2)
Test pm_rpm:
        Subgroup basic-rte:
                pass       -> DMESG-WARN (bsw-nuc-2)
Test pm_rps:
        Subgroup basic-api:
                pass       -> DMESG-WARN (bsw-nuc-2)
bdw-nuci7        total:203  pass:191  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:203  pass:180  dwarn:0   dfail:0   fail:0   skip:23 
bsw-nuc-2        total:185  pass:119  dwarn:19  dfail:3   fail:0   skip:43 
byt-nuc          total:202  pass:164  dwarn:0   dfail:0   fail:0   skip:38 
hsw-brixbox      total:203  pass:179  dwarn:0   dfail:0   fail:0   skip:24 
hsw-gt2          total:203  pass:184  dwarn:0   dfail:0   fail:0   skip:19 
ivb-t430s        total:203  pass:175  dwarn:0   dfail:0   fail:0   skip:28 
skl-i7k-2        total:203  pass:177  dwarn:1   dfail:0   fail:0   skip:25 
skl-nuci5        total:203  pass:192  dwarn:0   dfail:0   fail:0   skip:11 
snb-dellxps      total:33   pass:26   dwarn:0   dfail:0   fail:0   skip:6  
snb-x220t        total:203  pass:165  dwarn:0   dfail:0   fail:1   skip:37 

Results at /archive/results/CI_IGT_test/Patchwork_1874/

42189a46296988a9e16b57dca9e25c227458888b drm-intel-nightly: 2016y-04m-12d-14h-35m-43s UTC integration manifest 5be1245 drm/i915/gen9: implement WaEnableSamplerGPGPUPreemptionSupport

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx