Skip to contentSkip to conversation

Patch "parisc: Avoid function pointers for kernel exception routines" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message Apr 12, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

parisc: Avoid function pointers for kernel exception routines

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
parisc-avoid-function-pointers-for-kernel-exception-routines.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From e3893027a300927049efc1572f852201eb785142 Mon Sep 17 00:00:00 2001

From: Helge Deller <[email protected]>
Date: Fri, 8 Apr 2016 18:11:33 +0200
Subject: parisc: Avoid function pointers for kernel exception routines

From: Helge Deller <[email protected]>

commit e3893027a300927049efc1572f852201eb785142 upstream.

We want to avoid the kernel module loader to create function pointers for the kernel fixup routines of get_user() and put_user(). Changing the external reference from function type to int type fixes this.

This unbreaks exception handling for get_user() and put_user() when called from a kernel module.

---
 arch/parisc/kernel/parisc_ksyms.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/parisc/kernel/parisc_ksyms.c +5 -5
@@ -47,11 +47,11 @@ EXPORT_SYMBOL(__cmpxchg_u64);
 EXPORT_SYMBOL(lclear_user);
 EXPORT_SYMBOL(lstrnlen_user);
 
-/* Global fixups */
-extern void fixup_get_user_skip_1(void);
-extern void fixup_get_user_skip_2(void);
-extern void fixup_put_user_skip_1(void);
-extern void fixup_put_user_skip_2(void);
+/* Global fixups - defined as int to avoid creation of function pointers */
+extern int fixup_get_user_skip_1;
+extern int fixup_get_user_skip_2;
+extern int fixup_put_user_skip_1;
+extern int fixup_put_user_skip_2;
 EXPORT_SYMBOL(fixup_get_user_skip_1);
 EXPORT_SYMBOL(fixup_get_user_skip_2);
 EXPORT_SYMBOL(fixup_put_user_skip_1);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/parisc-fix-kernel-crash-with-reversed-copy_from_user.patch queue-4.4/parisc-unbreak-handling-exceptions-from-kernel-modules.patch queue-4.4/parisc-avoid-function-pointers-for-kernel-exception-routines.patch