Skip to contentSkip to conversation

rule: fix leaks in NFTNL_RULE_USERDATA

PATCH New Pablo Neira Ayuso 1 participant 1 message Apr 15, 2016 netfilter

lore
Share & tools
lore

Pablo Neira Ayuso

author maintainer
#0 lore raw

PATCH 1/1 rule: fix leaks in NFTNL_RULE_USERDATA

Fix leaks in nftnl_rule_free() and nftnl_rule_set_data().

---
 src/rule.c | 5 +++++
 1 file changed, 5 insertions(+)
src/rule.c +5 -0
index 3a32bf6..9c09127 100644
@@ -75,6 +75,8 @@ void nftnl_rule_free(struct nftnl_rule *r)
 		xfree(r->table);
 	if (r->chain != NULL)
 		xfree(r->chain);
+	if (r->user.data != NULL)
+		xfree(r->user.data);
 
 	xfree(r);
 }
@@ -162,6 +164,9 @@ void nftnl_rule_set_data(struct nftnl_rule *r, uint16_t attr,
 		r->position = *((uint64_t *)data);
 		break;
 	case NFTNL_RULE_USERDATA:
+		if (r->user.data != NULL)
+			xfree(r->user.data);
+
 		r->user.data = (void *)data;
 		r->user.len = data_len;
 		break;
Signature · 6 lines
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html