Skip to contentSkip to conversation

Patch "sctp: lack the check for ports in sctp_v6_cmp_addr" has been added to the 3.14-stable tree

PATCH [email protected] 1 participant 1 message Apr 17, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

sctp: lack the check for ports in sctp_v6_cmp_addr

to the 3.14-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
sctp-lack-the-check-for-ports-in-sctp_v6_cmp_addr.patch
and it can be found in the queue-3.14 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From foo@baz Sat Apr 16 22:36:37 PDT 2016

From: Xin Long <[email protected]>
Date: Sun, 28 Feb 2016 10:03:51 +0800
Subject: sctp: lack the check for ports in sctp_v6_cmp_addr
Status: RO
Content-Length: 1078
Lines: 34

From: Xin Long <[email protected]>

[ Upstream commit 40b4f0fd74e46c017814618d67ec9127ff20f157 ]

As the member .cmp_addr of sctp_af_inet6, sctp_v6_cmp_addr should also check the port of addresses, just like sctp_v4_cmp_addr, cause it's invoked by sctp_cmp_addr_exact().

Now sctp_v6_cmp_addr just check the port when two addresses have different family, and lack the port check for two ipv6 addresses. that will make sctp_hash_cmp() cannot work well.

so fix it by adding ports comparison in sctp_v6_cmp_addr().

---
 net/sctp/ipv6.c |    2 ++
 1 file changed, 2 insertions(+)
net/sctp/ipv6.c +2 -0
@@ -519,6 +519,8 @@ static int sctp_v6_cmp_addr(const union
 		}
 		return 0;
 	}
+	if (addr1->v6.sin6_port != addr2->v6.sin6_port)
+		return 0;
 	if (!ipv6_addr_equal(&addr1->v6.sin6_addr, &addr2->v6.sin6_addr))
 		return 0;
 	/* If this is a linklocal address, compare the scope_id. */

Patches currently in stable-queue which might be from [email protected] are

queue-3.14/sctp-lack-the-check-for-ports-in-sctp_v6_cmp_addr.patch