Skip to contentSkip to conversation

regulator: core: Add debugfs for regulator always_on flag

PATCH In review Richard Fitzgerald 2 participants 3 messages Apr 22, 2016 Voltage and current regulator framework

lore
Share & tools
lore

Richard Fitzgerald

author
#0 lore raw

PATCH 1/1 regulator: core: Add debugfs for regulator always_on flag

This patch adds a debugfs file for the always_on flag in struct regulator. It's useful for debugging to be able to view the state of this flag and as it's set by logic inside the regulator core it doesn't necessarily have the same value as the always_on flag in constraints.

Signed-off-by Richard Fitzgerald <[email protected]>
---
 drivers/regulator/core.c | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)
drivers/regulator/core.c +26 -0
index 7338175..9b7ad25 100644
@@ -1273,6 +1273,23 @@ static void unset_regulator_supplies(struct regulator_dev *rdev)
 }
 
 #ifdef CONFIG_DEBUG_FS
+static ssize_t always_on_read_file(struct file *file, char __user *user_buf,
+				   size_t count, loff_t *ppos)
+{
+	const struct regulator *regulator = file->private_data;
+	char *buf = kmalloc(PAGE_SIZE, GFP_KERNEL);
+	ssize_t ret;
+
+	if (!buf)
+		return -ENOMEM;
+
+	ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);
+	ret = simple_read_from_buffer(user_buf, count, ppos, buf, ret);
+	kfree(buf);
+
+	return ret;
+}
+
 static ssize_t constraint_flags_read_file(struct file *file,
 					  char __user *user_buf,
 					  size_t count, loff_t *ppos)

@@ -1310,8 +1327,15 @@ static ssize_t constraint_flags_read_file(struct file *file,
 
 	return ret;
 }
+#endif
 
+static const struct file_operations always_on_fops = {
+#ifdef CONFIG_DEBUG_FS
+	.open = simple_open,
+	.read = always_on_read_file,
+	.llseek = default_llseek,
 #endif
+};
 
 static const struct file_operations constraint_flags_fops = {
 #ifdef CONFIG_DEBUG_FS

@@ -1376,6 +1400,8 @@ static struct regulator *create_regulator(struct regulator_dev *rdev,
 				   &regulator->min_uV);
 		debugfs_create_u32("max_uV", 0444, regulator->debugfs,
 				   &regulator->max_uV);
+		debugfs_create_file("always_on", 0444, regulator->debugfs,
+				    regulator, &always_on_fops);
 		debugfs_create_file("constraint_flags", 0444,
 				    regulator->debugfs, regulator,
 				    &constraint_flags_fops);
Signature · 1 line
1.9.1
maintainer
#1 lore raw
Quoted 4 lines · Richard Fitzgerald

This patch adds a debugfs file for the always_on flag in struct regulator. It's useful for debugging to be able to view the state of this flag and as it's set by logic inside the regulator core it doesn't necessarily have the same value as the always_on flag in constraints.

Why not include this in the same file as the rest of the constraints? Or why not have one file per constraint (which would be easier for scripts)?

Review

Quoted 3 lines
(quoted diff) +2 -0
+	ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);
 
+		debugfs_create_file("always_on", 0444, regulator->debugfs,

It seems to be formatted as though it's going to end up in the same file but it's a separate file so instead it's just repeating the name of the file inside the file.

author
#2 lore raw
Quoted 8 lines · Mark Brown
Quoted 4 lines · Richard Fitzgerald

This patch adds a debugfs file for the always_on flag in struct regulator. It's useful for debugging to be able to view the state of this flag and as it's set by logic inside the regulator core it doesn't necessarily have the same value as the always_on flag in constraints.

Why not include this in the same file as the rest of the constraints? Or why not have one file per constraint (which would be easier for scripts)?

Hmm, well the thing is there's two separate always_on flags, the one in constraints (if you have any constraints) and the one in struct regulator. I could munge the always_on status printed in the constraints debugfs to be (regulator.always_on || constraints.always_on) though I'm not sure if that's helpful (it shows actual state) or confusing (it might not match what was fed in as constraints).

Quoted 5 lines

Review

Quoted 2 lines
(quoted diff) +2 -0
+	ret = snprintf(buf, PAGE_SIZE, "always_on: %u\n", regulator->always_on);
+		debugfs_create_file("always_on", 0444, regulator->debugfs,

It seems to be formatted as though it's going to end up in the same file but it's a separate file so instead it's just repeating the name of the file inside the file.

Sorry, that was lazy copy-and-paste. I'll fix it.