drm/atomic: Always allow async support for the atomic ioctl.
Subsystems (2)
Maarten Lankhorst
maintainerPATCH 1/1 drm/atomic: Always allow async support for the atomic ioctl.
async_page_flip is a unrelated flag and should not be used for testing support. It's up to the drivers to fail if they don't support async commit.
--- drivers/gpu/drm/drm_atomic.c | 4 ---- 1 file changed, 4 deletions(-)
drivers/gpu/drm/drm_atomic.c +0 -4
@@ -1587,10 +1587,6 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,if (arg->reserved)return -EINVAL ; -if ((arg->flags &DRM_MODE_PAGE_FLIP_ASYNC ) && - !dev->mode_config.async_page_flip) -return -EINVAL ; -/* can't test and expect an event at the same time. */ if ((arg->flags &DRM_MODE_ATOMIC_TEST_ONLY ) && (arg->flags &DRM_MODE_PAGE_FLIP_EVENT ))
Signature · 6 lines
2.1.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 5 lines · Maarten Lankhorst
async_page_flipis a unrelated flag and should not be used for testing support. It's up to the drivers to fail if they don't support async commit.Signed-off-by Maarten Lankhorst <[email protected]>
Once more (summary of our irc discussion):
- DRM_MODE_PAGE_FLIP_ASYNC = flipping with tearing, i.e. not vblank synced. Gives you lower latency and unrestricted rendering, aka benchmark mode. Needs special hw support and on intel only supported on the primary plane. I think a better way to almost get all the benefits of async by simply implementing a queue of flips that all get collapsed to the next vblank.
- async atomic commit = non-blocking ioctl.
Two entirely orthogonal things (you could do blocking atomic commit with async flip, but doesn't make much sense).
Maybe instead we need a better documentation for the FLIP_ASYNC flag? -Daniel
Quoted 26 lines
--- drivers/gpu/drm/drm_atomic.c | 4 ---- 1 file changed, 4 deletions(-)drivers/gpu/drm/drm_atomic.c +0
-5@@ -1587,10 +1587,6 @@ int drm_mode_atomic_ioctl(struct drm_device *dev,if (arg->reserved)return -EINVAL ; -if ((arg->flags &DRM_MODE_PAGE_FLIP_ASYNC ) && - !dev->mode_config.async_page_flip) -return -EINVAL ; -/* can't test and expect an event at the same time. */ if ((arg->flags &DRM_MODE_ATOMIC_TEST_ONLY ) && (arg->flags &DRM_MODE_PAGE_FLIP_EVENT )) --2.1.0
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Maarten Lankhorst
maintainerOp 25-04-16 om 11:35 schreef Daniel Vetter:
Quoted 16 lines
Quoted 5 lines · Maarten Lankhorst
async_page_flipis a unrelated flag and should not be used for testing support. It's up to the drivers to fail if they don't support async commit.Signed-off-by Maarten Lankhorst <[email protected]>Once more (summary of our irc discussion):
-
DRM_MODE_PAGE_FLIP_ASYNC= flipping with tearing, i.e. not vblank synced. Gives you lower latency and unrestricted rendering, aka benchmark mode. Needs special hw support and on intel only supported on the primary plane. I think a better way to almost get all the benefits of async by simply implementing a queue of flips that all get collapsed to the next vblank.
Quoted 7 lines
- async atomic commit = non-blocking ioctl.
Two entirely orthogonal things (you could do blocking atomic commit with async flip, but doesn't make much sense).
Maybe instead we need a better documentation for the
FLIP_ASYNCflag?
yeah it's confusing, especially with atomic async commit. Maybe rename to nonblocking commit?
~Maarten
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 17 lines · Maarten Lankhorst
Op 25-04-16 om 11:35 schreef Daniel Vetter:
Quoted 16 lines
Quoted 5 lines · Maarten Lankhorst
async_page_flipis a unrelated flag and should not be used for testing support. It's up to the drivers to fail if they don't support async commit.Signed-off-by Maarten Lankhorst <[email protected]>Once more (summary of our irc discussion):
-
DRM_MODE_PAGE_FLIP_ASYNC= flipping with tearing, i.e. not vblank synced. Gives you lower latency and unrestricted rendering, aka benchmark mode. Needs special hw support and on intel only supported on the primary plane. I think a better way to almost get all the benefits of async by simply implementing a queue of flips that all get collapsed to the next vblank.
Quoted 8 lines
Quoted 7 lines
- async atomic commit = non-blocking ioctl.
Two entirely orthogonal things (you could do blocking atomic commit with async flip, but doesn't make much sense).
Maybe instead we need a better documentation for the
FLIP_ASYNCflag?yeah it's confusing, especially with atomic async commit. Maybe rename to nonblocking commit?
Well uabi renaming train left the station, but internally we can definitely do that. s/drm_atomic_async_commit/drm_atomic_nonblocking_commit/ plus s/async/nonblocking/ in the driver's ->atomic_commit hooks sounds like a very fine idea. Volunteered?
-Daniel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.BAT: failure for drm/atomic: Always allow async support for the atomic ioctl.
In reply to Maarten Lankhorst== Series Details ==
== Series Details ==
Series: drm/atomic: Always allow async support for the atomic ioctl.
URL : https://patchwork.freedesktop.org/series/6245/
State : failure
== Summary ==
Series 6245v1 drm/atomic: Always allow async support for the atomic ioctl.
http://patchwork.freedesktop.org/api/1.0/series/6245/revisions/1/mbox/
Test drv_hangman:
Subgroup error-state-basic:
incomplete -> PASS (snb-dellxps)
Test gem_exec_whisper:
Subgroup basic:
fail -> PASS (ilk-hp8440p)
Test gem_sync:
Subgroup basic-bsd:
pass -> DMESG-FAIL (ilk-hp8440p)
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
fail -> PASS (bdw-ultra)
fail -> PASS (byt-nuc)
Test kms_force_connector_basic:
Subgroup force-edid:
pass -> SKIP (ilk-hp8440p)bdw-nuci7 total:193 pass:181 dwarn:0 dfail:0 fail:0 skip:12 bdw-ultra total:193 pass:170 dwarn:0 dfail:0 fail:0 skip:23 bsw-nuc-2 total:192 pass:153 dwarn:0 dfail:0 fail:0 skip:39 byt-nuc total:192 pass:154 dwarn:0 dfail:0 fail:0 skip:38 hsw-brixbox total:193 pass:169 dwarn:0 dfail:0 fail:0 skip:24 hsw-gt2 total:193 pass:174 dwarn:0 dfail:0 fail:0 skip:19 ilk-hp8440p total:193 pass:134 dwarn:0 dfail:1 fail:0 skip:58 ivb-t430s total:193 pass:165 dwarn:0 dfail:0 fail:0 skip:28 skl-i7k-2 total:193 pass:168 dwarn:0 dfail:0 fail:0 skip:25 skl-nuci5 total:193 pass:182 dwarn:0 dfail:0 fail:0 skip:11 snb-dellxps total:193 pass:155 dwarn:0 dfail:0 fail:0 skip:38 snb-x220t total:193 pass:155 dwarn:0 dfail:0 fail:1 skip:37
Results at /archive/results/CI_IGT_test/Patchwork_2060/
2725e5c353b4628e3e37b3e3e26fc6e75222e692 drm-intel-nightly: 2016y-04m-25d-10h-31m-27s UTC integration manifest 685e34b drm/atomic: Always allow async support for the atomic ioctl.
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx