Skip to contentSkip to conversation

rtl8712: Fixed alignment to match open parenthesis

PATCH In review Parth Sane 2 participants 4 messages Apr 25, 2016 – Apr 26, 2016 1 message not in the archive Staging

lore
Share & tools
lore

Parth Sane

author
#0 lore raw

PATCH v6 1/1 rtl8712: Fixed alignment to match open parenthesis

Fixed alignment to match open parenthesis.

Signed-off-by Parth Sane <[email protected]>

---
Changes in v6:
-Added line before Signed-off message

 drivers/staging/rtl8712/hal_init.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
drivers/staging/rtl8712/hal_init.c +5 -4
index 0c76fbc..0dd458d 100644
@@ -197,8 +197,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 						       0x0000ffff);
 			memcpy(ppayload, ptr, dump_imem_sz);
 			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-				  dump_imem_sz + TXDESC_SIZE,
-				  (u8 *)ptx_desc);
+					dump_imem_sz + TXDESC_SIZE,
+					(u8 *)ptx_desc);
 			ptr += dump_imem_sz;
 			imem_sz -= dump_imem_sz;
 		} while (imem_sz > 0);

@@ -226,7 +226,8 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 						       0x0000ffff);
 			memcpy(ppayload, ptr, dump_emem_sz);
 			r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-				  dump_emem_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+					dump_emem_sz + TXDESC_SIZE,
+					(u8 *)ptx_desc);
 			ptr += dump_emem_sz;
 			emem_sz -= dump_emem_sz;
 		} while (emem_sz > 0);

@@ -278,7 +279,7 @@ static u8 rtl8712_dl_fw(struct _adapter *padapter)
 		ptx_desc->txdw0 |= cpu_to_le32(BIT(28));
 		memcpy(ppayload, &fwhdr.fwpriv, fwhdr.fw_priv_sz);
 		r8712_write_mem(padapter, RTL8712_DMA_VOQ,
-			  fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
+				fwhdr.fw_priv_sz + TXDESC_SIZE, (u8 *)ptx_desc);
 
 		/* polling dmem code done */
 		i = 100;
Signature · 1 line
1.9.1
#1 lore raw
Quoted 8 lines · Parth Sane

Fixed alignment to match open parenthesis.

Signed-off-by Parth Sane <[email protected]>

---
Changes in v6:
-Added line before Signed-off message

This last version looks good to me. Did you find this issue with checkpatch.pl?

Thanks,
Luis

author
#2 lore raw

Hi,
Thanks for the feedback. I did find this issue with the assistance checkpatch.pl script. Regards,
Parth Sane

Quoted 17 lines · Luis de Bethencourt
Quoted 8 lines · Parth Sane

Fixed alignment to match open parenthesis.

Signed-off-by Parth Sane <[email protected]>

---
Changes in v6:
-Added line before Signed-off message

This last version looks good to me. Did you find this issue with checkpatch.pl?

Thanks,
Luis

author
#4 lore raw
In reply to a message not in the archive

Hi,
Yes you are right on that regard. I did do that in my previous patches. It’s just something that I will have to remember now onwards. Thanks. Regards,
Parth Sane

Quoted 38 lines · Luis de Bethencourt
Quoted 4 lines · Parth Sane

Hi,
Thanks for the feedback. I did find this issue with the assistance checkpatch.pl script. Regards,
Parth Sane

Normally people mention the checkpatch warning they are fixing.

For example:
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=5f10ef7dce02d8e36665974aca0977cda58c1122

Verbosity in the commit message is a good thing :)

I have tested that your patch still applies cleanly to Greg's staging-testing branch.

Thanks,
Luis

Quoted 18 lines
Quoted 17 lines · Luis de Bethencourt
Quoted 8 lines · Parth Sane

Fixed alignment to match open parenthesis.

Signed-off-by Parth Sane <[email protected]>

---
Changes in v6:
-Added line before Signed-off message

This last version looks good to me. Did you find this issue with checkpatch.pl?

Thanks,
Luis