samba: fix QA warnings.
PATCH 1/1 samba: fix QA warnings.
WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: samba-4.4.2-r0 do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]
--- meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta-networking/recipes-connectivity/samba/samba_4.4.2.bb +2 -1
@@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative # remove default added RDEPENDS on perl RDEPENDS_${PN}_remove = "perl" -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd" +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio" SYSVINITTYPE_linuxstdbase = "lsb" SYSVINITTYPE = "sysv"
@@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd" PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi" PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi" PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind," +PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust" SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2" SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"
Signature · 1 line
2.3.5
Quoted 3 lines · Armin Kuster
WARNING: samba-4.4.2-r0
do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: samba-4.4.2-r0do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]
We used to have PACKAGECONFIG for aio, maybe it's worth trying to fix it instead of adding libaio directly to DEPENDS?
Also there is still:
WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
and also new:
WARN: samba: samba rdepends on libarchive, but it isn't a build dependency?
Quoted 34 lines
Signed-off-by Armin Kuster <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-networking/recipes-connectivity/samba/samba_4.4.2.bb +2
-1@@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative # remove default added RDEPENDS on perl RDEPENDS_${PN}_remove = "perl" -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd" +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio" SYSVINITTYPE_linuxstdbase = "lsb" SYSVINITTYPE = "sysv"@@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd" PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi" PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi" PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind," +PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust" SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2" SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"Signature · 7 lines
2.3.5 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 7 lines · Martin Jansa
Quoted 3 lines · Armin Kuster
WARNING: samba-4.4.2-r0
do_package_qa: QA Issue: samba rdepends on libaio, but it isn't a build dependency, missing libaio in DEPENDS or PACKAGECONFIG? [build-deps]
WARNING: samba-4.4.2-r0do_package_qa: QA Issue: samba rdepends on lttng-ust, but it isn't a build dependency, missing lttng-ust in DEPENDS or PACKAGECONFIG? [build-deps]We used to have PACKAGECONFIG for aio, maybe it's worth trying to fix it instead of adding libaio directly to DEPENDS?
correct. that option is no longer available. Removed in 4.4.0
Quoted 3 lines
Also there is still:
WARN: samba: samba rdepends on libpam, but it isn't a build dependency?
I think Joe is looking into this. He has some fixes not yet published.
Quoted 3 lines
and also new:
WARN: samba: samba rdepends on libarchive, but it isn't a build dependency?
that is new to me too. Not sure if Joe has that addressed. I can resend patch to deal with this.
thanks,
Armin
Quoted 39 lines
Quoted 36 lines
Signed-off-by Armin Kuster <[email protected]>--- meta-networking/recipes-connectivity/samba/samba_4.4.2.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-networking/recipes-connectivity/samba/samba_4.4.2.bb +2
-1@@ -27,7 +27,7 @@ inherit systemd waf-samba cpan-base perlnative # remove default added RDEPENDS on perl RDEPENDS_${PN}_remove = "perl" -DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd" +DEPENDS += "readline virtual/libiconv zlib popt libtalloc libtdb libtevent libldb krb5 ctdb libbsd libaio" SYSVINITTYPE_linuxstdbase = "lsb" SYSVINITTYPE = "sysv"@@ -54,6 +54,7 @@ PACKAGECONFIG[systemd] = "--with-systemd,--without-systemd,systemd" PACKAGECONFIG[dmapi] = "--with-dmapi,--without-dmapi,dmapi" PACKAGECONFIG[zeroconf] = "--enable-avahi,--disable-avahi,avahi" PACKAGECONFIG[valgrind] = ",--without-valgrind,valgrind," +PACKAGECONFIG[lttng] = "--with-lttng, --without-lttng,lttng-ust" SAMBA4_IDMAP_MODULES="idmap_ad,idmap_rid,idmap_adex,idmap_hash,idmap_tdb2" SAMBA4_PDB_MODULES="pdb_tdbsam,${@bb.utils.contains('PACKAGECONFIG', 'ldap', 'pdb_ldap,', '', d)}pdb_ads,pdb_smbpasswd,pdb_wbc_sam,pdb_samba4"Signature · 7 lines
2.3.5 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel