Skip to contentSkip to conversation

perf tools: Make the x86 clean quiet

PATCH In review Jiri Olsa 3 participants 5 messages Apr 25, 2016 – Apr 27, 2016 perf events

lore
Share & tools
lore

Jiri Olsa

author reviewer
#0 lore raw

PATCH 1/2 perf tools: Make the x86 clean quiet

Turn current clean output:

  $ make clean
  rm -f arch/x86/include/generated/asm/syscalls_64.c
    CLEAN    libbpf
    CLEAN    libapi

into:

  $ make clean
    CLEAN    x86
    CLEAN    libapi
    CLEAN    libbpf
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Jiri Olsa <[email protected]>
---
 tools/perf/arch/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/arch/x86/Makefile +1 -1
index a33729173b13..6c9211b18ec0 100644
@@ -24,6 +24,6 @@ $(header): $(sys)/syscall_64.tbl $(systbl)
 	$(Q)$(SHELL) '$(systbl)' $(sys)/syscall_64.tbl 'x86_64' > $@
 
 clean::
-	rm -f $(header)
+	$(call QUIET_CLEAN, x86) $(RM) $(header)
 
 archheaders: $(header)
Signature · 1 line
2.4.11
author reviewer
#1 lore raw

PATCH 2/2 tools build: Fix perf_clean target

Fixig perf_clean target to follow the same logic as perf target, it fixes following make invokation:

  $ cd <kernelsrc> && make tools/perf_clean
Reported-by TJ <[email protected]>
Link https://bugzilla.kernel.org/show_bug.cgi?id=116411
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Jiri Olsa <[email protected]>
---
 tools/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/Makefile +2 -1
index 60c7e6c8ff17..6bf68fe7dd29 100644
@@ -137,7 +137,8 @@ libsubcmd_clean:
 	$(call descend,lib/subcmd,clean)
 
 perf_clean:
-	$(call descend,$(@:_clean=),clean)
+	$(Q)mkdir -p $(PERF_O) .
+	$(Q)$(MAKE) --no-print-directory -C perf O=$(PERF_O) subdir= clean
 
 selftests_clean:
 	$(call descend,testing/$(@:_clean=),clean)
Signature · 1 line
2.4.11
maintainer
#2 lore raw

Re: [PATCH 2/2] tools build: Fix perf_clean target

Em Mon, Apr 25, 2016 at 10:17:18PM +0200, Jiri Olsa escreveu:

Quoted 4 lines

Fixig perf_clean target to follow the same logic as perf target, it fixes following make invokation:

  $ cd <kernelsrc> && make tools/perf_clean

TJ, have you had the chance to test this? If so, can I have your
Tested-by: ack?

- Arnaldo

Quoted 24 lines
Reported-by TJ <[email protected]>
Link https://bugzilla.kernel.org/show_bug.cgi?id=116411
Link http://lkml.kernel.org/n/[email protected] open here
Signed-off-by Jiri Olsa <[email protected]>
---
 tools/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/Makefile +2 -1
index 60c7e6c8ff17..6bf68fe7dd29 100644
@@ -137,7 +137,8 @@ libsubcmd_clean:
 	$(call descend,lib/subcmd,clean)
 
 perf_clean:
-	$(call descend,$(@:_clean=),clean)
+	$(Q)mkdir -p $(PERF_O) .
+	$(Q)$(MAKE) --no-print-directory -C perf O=$(PERF_O) subdir= clean
 
 selftests_clean:
 	$(call descend,testing/$(@:_clean=),clean)
Signature · 1 line
2.4.11
merge bot
#3 lore raw

[tip:perf/core] tools build: Fix perf_clean target

In reply to Jiri Olsa
tools build: Fix perf_clean target
Commit-ID:  ab362f5a95ff72a895c446e9d5ef548cac2fea07
Gitweb:     http://git.kernel.org/tip/ab362f5a95ff72a895c446e9d5ef548cac2fea07
Author:     Jiri Olsa <[email protected]>
AuthorDate: Mon, 25 Apr 2016 22:17:18 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 25 Apr 2016 17:59:36 -0300

tools build: Fix perf_clean target

Fix perf_clean target to follow the same logic as perf target.

Fixes the following make invokation:

  $ cd <kernelsrc> && make tools/perf_clean
Reported-by TJ <[email protected]>
Signed-off-by Jiri Olsa <[email protected]>
Tested-by Arnaldo Carvalho de Melo <[email protected]>
Cc David Ahern <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=116411

Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/Makefile | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
tools/Makefile +2 -1
index 60c7e6c..6bf68fe 100644
@@ -137,7 +137,8 @@ libsubcmd_clean:
 	$(call descend,lib/subcmd,clean)
 
 perf_clean:
-	$(call descend,$(@:_clean=),clean)
+	$(Q)mkdir -p $(PERF_O) .
+	$(Q)$(MAKE) --no-print-directory -C perf O=$(PERF_O) subdir= clean
 
 selftests_clean:
 	$(call descend,testing/$(@:_clean=),clean)
merge bot
#4 lore raw
In reply to Jiri Olsa
perf tools: Make the x86 clean quiet
Commit-ID:  6404436a63a463d03ef9b5d7cd5edd371e711a95
Gitweb:     http://git.kernel.org/tip/6404436a63a463d03ef9b5d7cd5edd371e711a95
Author:     Jiri Olsa <[email protected]>
AuthorDate: Mon, 25 Apr 2016 22:17:17 +0200
Committer:  Arnaldo Carvalho de Melo <[email protected]>
CommitDate: Mon, 25 Apr 2016 17:56:15 -0300

perf tools: Make the x86 clean quiet

Turn current clean output:

  $ make clean
  rm -f arch/x86/include/generated/asm/syscalls_64.c
    CLEAN    libbpf
    CLEAN    libapi

into:

  $ make clean
    CLEAN    x86
    CLEAN    libapi
    CLEAN    libbpf
Signed-off-by Jiri Olsa <[email protected]>
Tested-by Arnaldo Carvalho de Melo <[email protected]>
Cc David Ahern <[email protected]>
Cc Namhyung Kim <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc TJ <[email protected]>
Link http://lkml.kernel.org/r/[email protected] open here
Signed-off-by Arnaldo Carvalho de Melo <[email protected]>
---
 tools/perf/arch/x86/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/arch/x86/Makefile +1 -1
index a337291..6c9211b 100644
@@ -24,6 +24,6 @@ $(header): $(sys)/syscall_64.tbl $(systbl)
 	$(Q)$(SHELL) '$(systbl)' $(sys)/syscall_64.tbl 'x86_64' > $@
 
 clean::
-	rm -f $(header)
+	$(call QUIET_CLEAN, x86) $(RM) $(header)
 
 archheaders: $(header)