Skip to contentSkip to conversation

drm/i915/guc: Use major_minor version for filename

PATCH In review [email protected] 4 participants 5 messages Apr 25, 2016 – Apr 28, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/guc: Use major_minor version for filename

From: Tom O'Rourke <Tom.O'[email protected]>

Load guc firmware from file with major_minor number in filename instead of using symolic link with only major number.

Issue: VIZ-7713

---
 drivers/gpu/drm/i915/intel_guc_loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_guc_loader.c +1 -1
index 876e5da..321bdbb 100644
@@ -59,7 +59,7 @@
  *
  */
 
-#define I915_SKL_GUC_UCODE "i915/skl_guc_ver6.bin"
+#define I915_SKL_GUC_UCODE "i915/skl_guc_ver6_1.bin"
 MODULE_FIRMWARE(I915_SKL_GUC_UCODE);
 
 /* User-friendly representation of an enum */
Signature · 6 lines
1.9.1

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw

✗ Fi.CI.BAT: failure for drm/i915/guc: Use major_minor version for filename

== Series Details ==

== Series Details ==

Series: drm/i915/guc: Use major_minor version for filename
URL : https://patchwork.freedesktop.org/series/6293/
State : failure

== Summary ==

Series 6293v1 drm/i915/guc: Use major_minor version for filename
http://patchwork.freedesktop.org/api/1.0/series/6293/revisions/1/mbox/

Test drv_hangman:

        Subgroup error-state-basic:
                incomplete -> PASS       (snb-dellxps)
Test gem_busy:
        Subgroup basic-bsd1:
                pass       -> DMESG-WARN (skl-nuci5)
Test gem_sync:
        Subgroup basic-bsd:
                pass       -> DMESG-WARN (skl-nuci5)
Test kms_pipe_crc_basic:
        Subgroup hang-read-crc-pipe-a:
                pass       -> FAIL       (skl-nuci5)
        Subgroup read-crc-pipe-b-frame-sequence:
                skip       -> PASS       (bdw-nuci7)
        Subgroup read-crc-pipe-c-frame-sequence:
                pass       -> DMESG-WARN (skl-nuci5)
bdw-nuci7        total:200  pass:188  dwarn:0   dfail:0   fail:0   skip:12 
bsw-nuc-2        total:199  pass:158  dwarn:0   dfail:0   fail:0   skip:41 
hsw-brixbox      total:200  pass:174  dwarn:0   dfail:0   fail:0   skip:26 
skl-i7k-2        total:200  pass:173  dwarn:0   dfail:0   fail:0   skip:27 
skl-nuci5        total:200  pass:185  dwarn:3   dfail:0   fail:1   skip:11 
snb-dellxps      total:193  pass:155  dwarn:0   dfail:0   fail:0   skip:38 

bdw-ultra failed to connect after reboot
ilk-hp8440p failed to connect after reboot
ivb-t430s failed to connect after reboot

Results at /archive/results/CI_IGT_test/Patchwork_2065/

f814551aa7232ed36d71244dd148b48660b53a78 drm-intel-nightly: 2016y-04m-25d-11h-36m-27s UTC integration manifest bc7fd31 drm/i915/guc: Use major_minor version for filename

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#2 lore raw

Re: ✗ Fi.CI.BAT: failure for drm/i915/guc: Use major_minor version for filename

Hello,
These errors are unrelated to the major_minor version change. Thanks,
Tom

Quoted 42 lines

-----Original Message-----
From: Patchwork [mailto:[email protected]]
Sent: Monday, April 25, 2016 10:18 PM
To: O'Rourke, Tom <[email protected]>
Cc: [email protected]
Subject: ✗ Fi.CI.BAT: failure for drm/i915/guc: Use major_minor version for filename

== Series Details ==

Series: drm/i915/guc: Use major_minor version for filename
URL : https://patchwork.freedesktop.org/series/6293/
State : failure

== Summary ==

Series 6293v1 drm/i915/guc: Use major_minor version for filename
http://patchwork.freedesktop.org/api/1.0/series/6293/revisions/1/mbox/

Test drv_hangman:

       Subgroup error-state-basic:
               incomplete -> PASS       (snb-dellxps)
Test gem_busy:
       Subgroup basic-bsd1:
               pass       -> DMESG-WARN (skl-nuci5)
Test gem_sync:
       Subgroup basic-bsd:
               pass       -> DMESG-WARN (skl-nuci5)
Test kms_pipe_crc_basic:
       Subgroup hang-read-crc-pipe-a:
               pass       -> FAIL       (skl-nuci5)
       Subgroup read-crc-pipe-b-frame-sequence:
               skip       -> PASS       (bdw-nuci7)
       Subgroup read-crc-pipe-c-frame-sequence:
               pass       -> DMESG-WARN (skl-nuci5)
bdw-nuci7        total:200  pass:188  dwarn:0   dfail:0   fail:0   skip:12
bsw-nuc-2        total:199  pass:158  dwarn:0   dfail:0   fail:0   skip:41
hsw-brixbox      total:200  pass:174  dwarn:0   dfail:0   fail:0   skip:26
skl-i7k-2        total:200  pass:173  dwarn:0   dfail:0   fail:0   skip:27
skl-nuci5        total:200  pass:185  dwarn:3   dfail:0   fail:1   skip:11
snb-dellxps      total:193  pass:155  dwarn:0   dfail:0   fail:0   skip:38
Quoted 8 lines

bdw-ultra failed to connect after reboot ilk-hp8440p failed to connect after reboot ivb-t430s failed to connect after reboot

Results at /archive/results/CI_IGT_test/Patchwork_2065/

f814551aa7232ed36d71244dd148b48660b53a78 drm-intel-nightly: 2016y-04m- 25d-11h-36m-27s UTC integration manifest
bc7fd31 drm/i915/guc: Use major_minor version for filename

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

#3 lore raw
In reply to [email protected]
Quoted 5 lines · On Mon, Apr 25, 2016 at 04:22:10PM -0700, [email protected] wrote:

From: Tom O'Rourke <Tom.O'[email protected]>

Load guc firmware from file with major_minor number in filename instead of using symolic link with only major number.

What's the justification for this change? Either a release breaks ABI (or has fixes that are so important that they're worth treating as equivalent to an ABI-break) and thus warrants a major-number bump, or it's a minor (non-ABI-breaking) fix, which would then fit fine within a minor number bump.

Since the firmware is released separately from the driver this will most likely lead to more cases where the system ends up running without any firmware loaded at all. Is that case better than having an older revision of the same major release of the firmware?

Kind regards, David Weinehall
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

maintainer Acked-by
#4 lore raw
Quoted 13 lines · David Weinehall
Quoted 5 lines · On Mon, Apr 25, 2016 at 04:22:10PM -0700, [email protected] wrote:

From: Tom O'Rourke <Tom.O'[email protected]>

Load guc firmware from file with major_minor number in filename instead of using symolic link with only major number.

What's the justification for this change? Either a release breaks ABI (or has fixes that are so important that they're worth treating as equivalent to an ABI-break) and thus warrants a major-number bump, or it's a minor (non-ABI-breaking) fix, which would then fit fine within a minor number bump.

Quoted 5 lines

Since the firmware is released separately from the driver this will most likely lead to more cases where the system ends up running without any firmware loaded at all. Is that case better than having an older revision of the same major release of the firmware?

The patch could use a more detailed commit message.

This is what I wrote on the matter previously.

Quoted 10 lines · Jani Nikula

I think we should move to accepting only specific firmware versions in the driver instead of having an illusion of forward compatible firmware minor versions.

By accepting any firmware with minor version greater than required, we create a huge testing burden on all prior released kernels when we release a new firmware version. We don't have the resources for that. But we also can't just go ahead and release firmware versions that might break stable kernels in distros out there.

Quoted 8 lines

We need to turn this the other way round. We need to make releasing firmware versions easy, and add the testing burden to the single kernel commit that accepts a new firmware version. We already have CI in place for that.

We (and the distros) can then *choose* to backport the commits that enable newer firmware versions, instead of having this control (or lack thereof) in the firmware release process.

For clarification, first, I don't reject the possibility of accepting multiple specific firmware versions, and second, the minor versions *should* be forward compatible but we don't know for sure without testing against each and every kernel that might load said firmware version. The combinations just explode.

I have not looked into all the details here, but in general this is

Maybe we should also consider cc: drm-intel-fixes or even cc: stable.

BR,
Jani.

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx