Skip to contentSkip to conversation

ASoC: topology: Check failure to create a widget

PATCH In review [email protected] 2 participants 2 messages Apr 27, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 ASoC: topology: Check failure to create a widget

From: Mengdong Lin <[email protected]>

Stop loading topology info if error happens when creating a widget.

sound/soc/soc-topology.c +3 -1
index bde79f7..e38664e 100644
@@ -1500,9 +1500,11 @@ static int soc_tplg_dapm_widget_elems_load(struct soc_tplg *tplg,
 	for (i = 0; i < count; i++) {
 		widget = (struct snd_soc_tplg_dapm_widget *) tplg->pos;
 		ret = soc_tplg_dapm_widget_create(tplg, widget);
-		if (ret < 0)
+		if (ret < 0) {
 			dev_err(tplg->dev, "ASoC: failed to load widget %s\n",
 				widget->name);
+			return ret;
+		}
 	}
 
 	return 0;
Signature · 1 line
2.5.0
maintainer
#1 lore raw

Applied "ASoC: topology: Check failure to create a widget" to the asoc tree

The patch

ASoC: topology: Check failure to create a widget

has been applied to the asoc tree at

git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark

Quoted 1 line

From 7de76b621f77aba456f594e4621eca2e94a146f3 Mon Sep 17 00:00:00 2001

From: Mengdong Lin <[email protected]>
Date: Wed, 27 Apr 2016 14:52:38 +0800
Subject: [PATCH] ASoC: topology: Check failure to create a widget

Stop loading topology info if error happens when creating a widget.

---
 sound/soc/soc-topology.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
sound/soc/soc-topology.c +3 -1
index ca5f82885031..0224a6458f3b 100644
@@ -1500,9 +1500,11 @@ static int soc_tplg_dapm_widget_elems_load(struct soc_tplg *tplg,
 	for (i = 0; i < count; i++) {
 		widget = (struct snd_soc_tplg_dapm_widget *) tplg->pos;
 		ret = soc_tplg_dapm_widget_create(tplg, widget);
-		if (ret < 0)
+		if (ret < 0) {
 			dev_err(tplg->dev, "ASoC: failed to load widget %s\n",
 				widget->name);
+			return ret;
+		}
 	}
 
 	return 0;
Signature · 1 line
2.8.0.rc3