Skip to contentSkip to conversation

drm/i915/lvds: do not set border bits when panel fitter is not enabled

PATCH In review Jani Nikula 4 participants 6 messages Apr 29, 2016 – May 2, 2016

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/lvds: do not set border bits when panel fitter is not enabled

We also don't read the border bits in i9xx_get_pfit_config() when the panel fitter is not enabled, causing the state checker warning:

[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)

Cc: Ville Syrjälä <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632

---
 drivers/gpu/drm/i915/intel_panel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_panel.c +1 -0
index 828f0fcaaaf8..67cf2e22ba51 100644
@@ -363,6 +363,7 @@ out:
 	if ((pfit_control & PFIT_ENABLE) == 0) {
 		pfit_control = 0;
 		pfit_pgm_ratios = 0;
+		border = 0;
 	}
 
 	/* Make sure pre-965 set dither correctly for 18bpp panels. */
Signature · 6 lines
2.1.4

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#1 lore raw
Quoted 18 lines · Jani Nikula

We also don't read the border bits in i9xx_get_pfit_config() when the panel fitter is not enabled, causing the state checker warning:

[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)

Cc: Ville Syrjälä <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632

---
 drivers/gpu/drm/i915/intel_panel.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_panel.c +0 -0
index 828f0fcaaaf8..67cf2e22ba51 100644

drivers/gpu/drm/i915/intel_panel.c out: · line 366

Quoted 4 lines
drivers/gpu/drm/i915/intel_panel.c +1 -0
@@ -363,6 +363,7 @@ out:
 	if ((pfit_control & PFIT_ENABLE) == 0) {
 		pfit_control = 0;
 		pfit_pgm_ratios = 0;
+		border = 0;

That doesn't seem right. We especially want the border for "center".

Quoted 5 lines
drivers/gpu/drm/i915/intel_panel.c +0 -0
 	}
 
 	/* Make sure pre-965 set dither correctly for 18bpp panels. */
Signature · 1 line
2.1.4
Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#2 lore raw
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula

We also don't read the border bits in i9xx_get_pfit_config() when the panel fitter is not enabled, causing the state checker warning:

[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)

Cc: Ville Syrjälä <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632

---
 drivers/gpu/drm/i915/intel_panel.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines

drivers/gpu/drm/i915/intel_panel.c out: · line 366

Quoted 9 lines
drivers/gpu/drm/i915/intel_panel.c +1 -0
index 828f0fcaaaf8..67cf2e22ba51 100644
@@ -363,6 +363,7 @@ out:
 	if ((pfit_control & PFIT_ENABLE) == 0) {
 		pfit_control = 0;
 		pfit_pgm_ratios = 0;
+		border = 0;

That doesn't seem right. We especially want the border for "center".

So after looking at this again, I think we should just move the border bit readout to the lvds get_config() hook.

Or was there some magic reason for doing the readout in the wrong place? Daniel?

Signature · 6 lines
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#3 lore raw
Quoted 15 lines · Ville Syrjälä
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula

We also don't read the border bits in i9xx_get_pfit_config() when the panel fitter is not enabled, causing the state checker warning:

[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)

Cc: Ville Syrjälä <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632

---
 drivers/gpu/drm/i915/intel_panel.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines
Quoted 11 lines

drivers/gpu/drm/i915/intel_panel.c out: · line 366

Quoted 9 lines
drivers/gpu/drm/i915/intel_panel.c +1 -0
index 828f0fcaaaf8..67cf2e22ba51 100644
@@ -363,6 +363,7 @@ out:
 	if ((pfit_control & PFIT_ENABLE) == 0) {
 		pfit_control = 0;
 		pfit_pgm_ratios = 0;
+		border = 0;

That doesn't seem right. We especially want the border for "center".

Doh.

Quoted 2 lines

So after looking at this again, I think we should just move the border bit readout to the lvds get_config() hook.

Agreed. Patches sent [1].

Quoted 2 lines

Or was there some magic reason for doing the readout in the wrong place? Daniel?

I tried to dig the history, didn't find anything.

BR,
Jani.

[1] http://patchwork.freedesktop.org/patch/msgid/[email protected]

Signature · 5 lines
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#4 lore raw
Quoted 28 lines · Jani Nikula
Quoted 15 lines · Ville Syrjälä
Quoted 14 lines · Ville Syrjälä
Quoted 13 lines · Jani Nikula

We also don't read the border bits in i9xx_get_pfit_config() when the panel fitter is not enabled, causing the state checker warning:

[drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in gmch_pfit.lvds_border_bits (expected 0x00008000, found 0x00000000)

Cc: Ville Syrjälä <[email protected]>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=87632

---
 drivers/gpu/drm/i915/intel_panel.c | 1 +
 1 file changed, 1 insertion(+)
Quoted 11 lines
Quoted 11 lines

drivers/gpu/drm/i915/intel_panel.c out: · line 366

Quoted 9 lines
drivers/gpu/drm/i915/intel_panel.c +1 -0
index 828f0fcaaaf8..67cf2e22ba51 100644
@@ -363,6 +363,7 @@ out:
 	if ((pfit_control & PFIT_ENABLE) == 0) {
 		pfit_control = 0;
 		pfit_pgm_ratios = 0;
+		border = 0;

That doesn't seem right. We especially want the border for "center".

Quoted 6 lines

Doh.

Quoted 2 lines

So after looking at this again, I think we should just move the border bit readout to the lvds get_config() hook.

Agreed. Patches sent [1].

Oops, year-long standing misunderstanding from me - I thought border only makes sense when pfit is enabled ...
-Daniel

Signature · 7 lines
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
#5 lore raw

✓ Fi.CI.BAT: success for drm/i915/lvds: do not set border bits when panel fitter is not enabled

In reply to Jani Nikula
== Series Details ==

== Series Details ==

Series: drm/i915/lvds: do not set border bits when panel fitter is not enabled
URL : https://patchwork.freedesktop.org/series/6530/
State : success

== Summary ==

Series 6530v1 drm/i915/lvds: do not set border bits when panel fitter is not enabled
http://patchwork.freedesktop.org/api/1.0/series/6530/revisions/1/mbox/

bdw-nuci7-2      total:201  pass:189  dwarn:0   dfail:0   fail:0   skip:12 
bdw-ultra        total:201  pass:176  dwarn:0   dfail:0   fail:0   skip:25 
bsw-nuc-2        total:200  pass:159  dwarn:0   dfail:0   fail:0   skip:41 
byt-nuc          total:200  pass:159  dwarn:0   dfail:0   fail:0   skip:41 
hsw-brixbox      total:201  pass:175  dwarn:0   dfail:0   fail:0   skip:26 
hsw-gt2          total:201  pass:179  dwarn:0   dfail:0   fail:1   skip:21 
ilk-hp8440p      total:201  pass:140  dwarn:0   dfail:0   fail:0   skip:61 
ivb-t430s        total:201  pass:170  dwarn:0   dfail:0   fail:0   skip:31 
skl-i7k-2        total:201  pass:174  dwarn:0   dfail:0   fail:0   skip:27 
skl-nuci5        total:201  pass:190  dwarn:0   dfail:0   fail:0   skip:11 
snb-dellxps      total:201  pass:159  dwarn:0   dfail:0   fail:0   skip:42 
snb-x220t        total:201  pass:159  dwarn:0   dfail:0   fail:1   skip:41 

Results at /archive/results/CI_IGT_test/Patchwork_2111/

1d56af10bdd6f4714e0892c05ff01d11e77f54fc drm-intel-nightly: 2016y-04m-29d-09h-21m-52s UTC integration manifest 42aec19 drm/i915/lvds: do not set border bits when panel fitter is not enabled

_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx