FAILED: patch "[PATCH] drm/amdgpu: forbid mapping of userptr bo through radeon" failed to apply to 4.4-stable tree
Subsystems (3)
[email protected]
maintainerThe patch below does not apply to the 4.4-stable tree.
If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to <[email protected]>.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
Quoted 1 line
From
054892ed6a1645e265bc35641c2a96433a051453Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= <[email protected]>
Date: Tue, 19 Apr 2016 09:07:51 -0400
Subject: [PATCH] drm/amdgpu: forbid mapping of userptr bo through radeon
device file
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Allowing userptr bo which are basicly a list of page from some vma (so either anonymous page or file backed page) would lead to serious corruption of kernel structures and counters (because we overwrite the page->mapping field when mapping buffer).
This will already block if the buffer was populated before anyone does try to mmap it because then TTM_PAGE_FLAG_SG would be set in in the ttm_tt flags. But that flag is check before ttm_tt_populate in the ttm vm fault handler.
So to be safe just add a check to verify_access() callback.
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c +2 -0
@@ -223,6 +223,8 @@ static int amdgpu_verify_access(struct ttm_buffer_object *bo, struct file *filp) { struct amdgpu_bo *rbo = container_of(bo, struct amdgpu_bo, tbo); +if (amdgpu_ttm_tt_get_usermm (bo->ttm)) +return -EPERM ;return drm_vma_node_verify_access (&rbo->gem_base.vma_node, filp); }