Skip to contentSkip to conversation

Patch "iwlwifi: mvm: fix memory leak in paging" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 1, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

iwlwifi: mvm: fix memory leak in paging

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
iwlwifi-mvm-fix-memory-leak-in-paging.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 7fdf9663261cc77a516396fec82cee8a8ea07e76 Mon Sep 17 00:00:00 2001

From: Matti Gottlieb <[email protected]>
Date: Tue, 15 Mar 2016 13:46:47 +0200
Subject: iwlwifi: mvm: fix memory leak in paging

From: Matti Gottlieb <[email protected]>

commit 7fdf9663261cc77a516396fec82cee8a8ea07e76 upstream.

Currently paging download buffer is freed during the the unloading of the opmode which happens when the driver is unloaded.

This causes a memory leak since the paging download buffer is allocated every time we enable the interface, so the download buffer can be allocated many times, but only be freed once.

Free paging download buffer during disabling of the interface.

---
 drivers/net/wireless/iwlwifi/mvm/mac80211.c |    2 ++
 drivers/net/wireless/iwlwifi/mvm/ops.c      |    2 --
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/net/wireless/iwlwifi/mvm/mac80211.c +2 -0
@@ -1557,6 +1557,8 @@ void __iwl_mvm_mac_stop(struct iwl_mvm *
 	/* the fw is stopped, the aux sta is dead: clean up driver state */
 	iwl_mvm_del_aux_sta(mvm);
 
+	iwl_free_fw_paging(mvm);
+
 	/*
 	 * Clear IN_HW_RESTART flag when stopping the hw (as restart_complete()
 	 * won't be called in this case).
drivers/net/wireless/iwlwifi/mvm/ops.c +0 -2
@@ -645,8 +645,6 @@ static void iwl_op_mode_mvm_stop(struct
 	for (i = 0; i < NVM_MAX_NUM_SECTIONS; i++)
 		kfree(mvm->nvm_sections[i].data);
 
-	iwl_free_fw_paging(mvm);
-
 	iwl_mvm_tof_clean(mvm);
 
 	ieee80211_free_hw(mvm->hw);

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/iwlwifi-mvm-fix-memory-leak-in-paging.patch