Patch "perf intel-pt: Fix segfault tracing transactions" has been added to the 4.4-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
perf intel-pt: Fix segfault tracing transactions
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
perf-intel-pt-fix-segfault-tracing-transactions.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
1342e0b7a6c1a060c593037fbac9f4b717f1cb3bMon Sep 17 00:00:00 2001
From: Adrian Hunter <[email protected]>
Date: Mon, 18 Apr 2016 13:57:48 +0300
Subject: perf intel-pt: Fix segfault tracing transactions
From: Adrian Hunter <[email protected]>
commit 1342e0b7a6c1a060c593037fbac9f4b717f1cb3b upstream.
Tracing a workload that uses transactions gave a seg fault as follows:
perf record -e intel_pt// workload
perf report
Program received signal SIGSEGV, Segmentation fault.
0x000000000054b58c in intel_pt_reset_last_branch_rb (ptq=0x1a36110)
at util/intel-pt.c:929
929 ptq->last_branch_rb->nr = 0;
(gdb) p ptq->last_branch_rb
$1 = (struct branch_stack *) 0x0
(gdb) up
1148 intel_pt_reset_last_branch_rb(ptq);
(gdb) l
1143 if (ret)
1144 pr_err("Intel Processor Trace: failed to deliver transaction event
1145 ret);
1146
1147 if (pt->synth_opts.callchain)
1148 intel_pt_reset_last_branch_rb(ptq);
1149
1150 return ret;
1151 }
1152
(gdb) p pt->synth_opts.callchain
$2 = true
(gdb)
(gdb) bt
#0 0x000000000054b58c in intel_pt_reset_last_branch_rb (ptq=0x1a36110)
#1 0x000000000054c1e0 in intel_pt_synth_transaction_sample (ptq=0x1a36110)
#2 0x000000000054c5b2 in intel_pt_sample (ptq=0x1a36110)Caused by checking the 'callchain' flag when it should have been the 'last_branch' flag. Fix that.
--- tools/perf/util/intel-pt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/util/intel-pt.c +1 -1
@@ -1127,7 +1127,7 @@ static int intel_pt_synth_transaction_sapr_err ("Intel Processor Trace: failed to deliver transaction event, error %d\n" , ret); -if (pt->synth_opts.callchain) +if (pt->synth_opts.last_branch)intel_pt_reset_last_branch_rb (ptq);return ret;
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/perf-intel-pt-fix-segfault-tracing-transactions.patch