Skip to contentSkip to conversation

Patch "perf hists: Fix determination of a callchain node's childlessness" has been added to the 4.5-stable tree

PATCH [email protected] 1 participant 1 message May 2, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

perf hists: Fix determination of a callchain node's childlessness

to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
perf-hists-fix-determination-of-a-callchain-node-s-childlessness.patch
and it can be found in the queue-4.5 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 909890355507e92bdaf648e73870f6b5df606da8 Mon Sep 17 00:00:00 2001

From: Andres Freund <[email protected]>
Date: Wed, 30 Mar 2016 21:02:45 +0200
Subject: perf hists: Fix determination of a callchain node's childlessness

From: Andres Freund <[email protected]>

commit 909890355507e92bdaf648e73870f6b5df606da8 upstream.

The 4b3a3212233a ("perf hists browser: Support flat callchains") commit over-aggressively tried to optimize callchain_node__init_have_children().

That lead to --tui mode not allowing to expand call chain elements if a call chain element had only one parent. That's why --inverted callgraphs looked halfway sane, but plain ones didn't.

Revert that individual optimization, it wasn't really related to the rest of the commit.

---
 tools/perf/ui/browsers/hists.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tools/perf/ui/browsers/hists.c +1 -1
@@ -302,7 +302,7 @@ static void callchain_node__init_have_ch
 	chain = list_entry(node->val.next, struct callchain_list, list);
 	chain->has_children = has_sibling;
 
-	if (node->val.next != node->val.prev) {
+	if (!list_empty(&node->val)) {
 		chain = list_entry(node->val.prev, struct callchain_list, list);
 		chain->has_children = !RB_EMPTY_ROOT(&node->rb_root);
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.5/perf-hists-fix-determination-of-a-callchain-node-s-childlessness.patch