Patch "btrfs: cleaner_kthread() doesn't need explicit freeze" has been added to the 4.5-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
btrfs: cleaner_kthread() doesn't need explicit freeze
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
btrfs-cleaner_kthread-doesn-t-need-explicit-freeze.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
838fe1887765f4cc679febea60d87d2a06bd300eMon Sep 17 00:00:00 2001
From: Jiri Kosina <[email protected]>
Date: Tue, 15 Mar 2016 11:28:54 +0100
Subject: btrfs: cleaner_kthread() doesn't need explicit freeze
From: Jiri Kosina <[email protected]>
commit 838fe1887765f4cc679febea60d87d2a06bd300e upstream.
cleaner_kthread() is not marked freezable, and therefore calling try_to_freeze() in its context is a pointless no-op.
In addition to that, as has been clearly demonstrated by 80ad623edd2d ("Revert "btrfs: clear PF_NOFREEZE in cleaner_kthread()"), it's perfectly valid / legal for cleaner_kthread() to stay scheduled out in an arbitrary place during suspend (in that particular example that was waiting for reading of extent pages), so there is no need to leave any traces of freezer in this kthread.
--- fs/btrfs/disk-io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
fs/btrfs/disk-io.c +1 -1
@@ -1830,7 +1830,7 @@ static int cleaner_kthread(void *arg)*/ btrfs_delete_unused_bgs (root->fs_info); sleep: -if (!try_to_freeze () && !again) { +if (!again) {set_current_state (TASK_INTERRUPTIBLE );if (!kthread_should_stop ())schedule ();
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/btrfs-cleaner_kthread-doesn-t-need-explicit-freeze.patch