Skip to contentSkip to conversation

Misc fixes and additions for phy-connection-type

PATCH Applied Florian Fainelli 2 participants 6 messages May 6, 2016 2 messages not in the archive

lore
Share & tools
lore
#0 lore raw

cover Misc fixes and additions for phy-connection-type

Hi Grant,

Here are some fixes in the phy-connection-type property area, thanks!

Florian Fainelli (3):
Fix property value for the Gigabit MII type
Fix property name, table and defined value for "phy-connection-type" Document additional "phy-connection-type" values

 source/device-bindings.rst | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): 1462511327-21077-1-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

#2 lore raw

PATCH 1/3 Fix property value for the Gigabit MII type

The property description is correct but the property value should be "gmii" instead of "rgmii"

---
 source/device-bindings.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
source/device-bindings.rst +1 -1
index 60e5560..ec50c67 100644
@@ -337,7 +337,7 @@ the network device class.
    ===================================== ============
    Media Independent Interface           ``mii``
    Reduced Media Independent Interface   ``rmii``
-   Gigabit Media Independent Interface   ``rgmii``
+   Gigabit Media Independent Interface   ``gmii``
    Reduced Gigabit Media Independent     ``rgmii``
    rgmii with internal delay             ``rgmii-id``
    rgmii with internal delay on TX only  ``rgmii-txid``
Signature · 1 line
2.7.4
#3 lore raw

PATCH 2/3 Fix property name, table and defined value for "phy-connection-type"

In reply to a message not in the archive

Table 4.12 describes the "phy-connection-type" property and its valid values, not "max-speed" (which is at 4.11).

---
 source/device-bindings.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
source/device-bindings.rst +3 -3
index ec50c67..6bf79ff 100644
@@ -315,10 +315,10 @@ the network device class.
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
 .. tabularcolumns:: | l J |
-.. table:: ``max-speed`` Property
+.. table:: ``phy-connection-type`` Property
 
    =========== ==============================================================
-   Property    ``max-speed``
+   Property    ``phy-connection-type``
    =========== ==============================================================
    Value type  ``<string>``
    Description Specifies interface type between the Ethernet device and a
@@ -330,7 +330,7 @@ the network device class.
    =========== ==============================================================
 
 .. tabularcolumns:: | l J |
-.. table:: Defined values for the ``max-speed`` Property
+.. table:: Defined values for the ``phy-connection-type`` Property
 
    ===================================== ============
    Connection type                       Value
Signature · 1 line
2.7.4
#4 lore raw

PATCH 3/3 Document additional "phy-connection-type" values

In reply to a message not in the archive

Add the following values to the "phy-connection-type" property:

* Serial Gigabit Media Independent Interface      ``sgmii``
* Reverse Media Independent Interface             ``rev-mii``
* 10 Gigabits Media Independent Interface         ``xgmii``
* Multimedia over Coaxial                         ``moca``

* Quad Serial Gigabit Media Independent Interface ``qsgmii``

---
 source/device-bindings.rst | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)
source/device-bindings.rst +18 -13
index 6bf79ff..bf197ee 100644
@@ -332,20 +332,25 @@ the network device class.
 .. tabularcolumns:: | l J |
 .. table:: Defined values for the ``phy-connection-type`` Property
 
-   ===================================== ============
+   =============================================== ============
    Connection type                       Value
-   ===================================== ============
-   Media Independent Interface           ``mii``
-   Reduced Media Independent Interface   ``rmii``
-   Gigabit Media Independent Interface   ``gmii``
-   Reduced Gigabit Media Independent     ``rgmii``
-   rgmii with internal delay             ``rgmii-id``
-   rgmii with internal delay on TX only  ``rgmii-txid``
-   rgmii with internal delay on RX only  ``rgmii-rxid``
-   Ten Bit Interface                     ``tbi``
-   Reduced Ten Bit Interface             ``rtbi``
-   Serial Media Independent Interface    ``smii``
-   ===================================== ============
+   =============================================== ============
+   Media Independent Interface                     ``mii``
+   Reduced Media Independent Interface             ``rmii``
+   Gigabit Media Independent Interface             ``gmii``
+   Reduced Gigabit Media Independent               ``rgmii``
+   rgmii with internal delay                       ``rgmii-id``
+   rgmii with internal delay on TX only            ``rgmii-txid``
+   rgmii with internal delay on RX only            ``rgmii-rxid``
+   Ten Bit Interface                               ``tbi``
+   Reduced Ten Bit Interface                       ``rtbi``
+   Serial Media Independent Interface              ``smii``
+   Serial Gigabit Media Independent Interface      ``sgmii``
+   Reverse Media Independent Interface             ``rev-mii``
+   10 Gigabits Media Independent Interface         ``xgmii``
+   Multimedia over Coaxial                         ``moca``
+   Quad Serial Gigabit Media Independent Interface ``qsgmii``
+   =============================================== ============
 
 ``phy-handle`` Property
 ^^^^^^^^^^^^^^^^^^^^^^^
Signature · 1 line
2.7.4

A message that is not in the archive (sent off-list or not yet received): 1462511327-21077-4-git-send-email-f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org

Applied
#6 lore raw

Re: [PATCH DT spec 3/3] Document additional "phy-connection-type" values

Quoted 9 lines · Florian Fainelli

Add the following values to the "phy-connection-type" property:

* Serial Gigabit Media Independent Interface      ``sgmii``
* Reverse Media Independent Interface             ``rev-mii``
* 10 Gigabits Media Independent Interface         ``xgmii``
* Multimedia over Coaxial                         ``moca``

* Quad Serial Gigabit Media Independent Interface ``qsgmii``

Merged, thanks. Made one minor correction below...

Quoted 9 lines
---
 source/device-bindings.rst | 31 ++++++++++++++++++-------------
 1 file changed, 18 insertions(+), 13 deletions(-)
source/device-bindings.rst +0 -0
index 6bf79ff..bf197ee 100644

source/device-bindings.rst the network device class. · line 337

Quoted 7 lines
source/device-bindings.rst +1 -2
@@ -332,20 +332,25 @@ the network device class.
 .. tabularcolumns:: | l J |
 .. table:: Defined values for the ``phy-connection-type`` Property
 
-   ===================================== ============
+   =============================================== ============
    Connection type                       Value
-   ===================================== ============

The "Value" heading needed to be indented further also to get the table to render correctly.

g.

Quoted 34 lines
source/device-bindings.rst +17 -12
-   Media Independent Interface           ``mii``
-   Reduced Media Independent Interface   ``rmii``
-   Gigabit Media Independent Interface   ``gmii``
-   Reduced Gigabit Media Independent     ``rgmii``
-   rgmii with internal delay             ``rgmii-id``
-   rgmii with internal delay on TX only  ``rgmii-txid``
-   rgmii with internal delay on RX only  ``rgmii-rxid``
-   Ten Bit Interface                     ``tbi``
-   Reduced Ten Bit Interface             ``rtbi``
-   Serial Media Independent Interface    ``smii``
-   ===================================== ============
+   =============================================== ============
+   Media Independent Interface                     ``mii``
+   Reduced Media Independent Interface             ``rmii``
+   Gigabit Media Independent Interface             ``gmii``
+   Reduced Gigabit Media Independent               ``rgmii``
+   rgmii with internal delay                       ``rgmii-id``
+   rgmii with internal delay on TX only            ``rgmii-txid``
+   rgmii with internal delay on RX only            ``rgmii-rxid``
+   Ten Bit Interface                               ``tbi``
+   Reduced Ten Bit Interface                       ``rtbi``
+   Serial Media Independent Interface              ``smii``
+   Serial Gigabit Media Independent Interface      ``sgmii``
+   Reverse Media Independent Interface             ``rev-mii``
+   10 Gigabits Media Independent Interface         ``xgmii``
+   Multimedia over Coaxial                         ``moca``
+   Quad Serial Gigabit Media Independent Interface ``qsgmii``
+   =============================================== ============
 
 ``phy-handle`` Property
 ^^^^^^^^^^^^^^^^^^^^^^^
--

2.7.4

#7 lore raw
In reply to a message not in the archive
Quoted 11 lines · Florian Fainelli

Hi Grant,

Here are some fixes in the phy-connection-type property area, thanks!

Florian Fainelli (3):
Fix property value for the Gigabit MII type
Fix property name, table and defined value for "phy-connection-type" Document additional "phy-connection-type" values

 source/device-bindings.rst | 37 +++++++++++++++++++++----------------
 1 file changed, 21 insertions(+), 16 deletions(-)

Merged all three. Thanks.

g.

Quoted 4 lines

--
2.7.4