Patch "ipvs: correct initial offset of Call-ID header search in SIP persistence engine" has been added to the 4.4-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
ipvs: correct initial offset of Call-ID header search in SIP persistence engine
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ipvs-correct-initial-offset-of-call-id-header-search-in-sip-persistence-engine.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
7617a24f83b5d67f4dab1844956be1cebc44aec8Mon Sep 17 00:00:00 2001
From: Marco Angaroni <[email protected]>
Date: Sat, 5 Mar 2016 12:10:02 +0100
Subject: ipvs: correct initial offset of Call-ID header search in SIP persistence engine
From: Marco Angaroni <[email protected]>
commit 7617a24f83b5d67f4dab1844956be1cebc44aec8 upstream.
The IPVS SIP persistence engine is not able to parse the SIP header "Call-ID" when such header is inserted in the first positions of the SIP message.
When IPVS is configured with "--pe sip" option, like for example:
ipvsadm -A -u 1.2.3.4:5060 -s rr --pe sip -p 120 -o
some particular messages (see below for details) do not create entries in the connection template table, which can be listed with:
ipvsadm -Lcn --persistent-conn
Problematic SIP messages are SIP responses having "Call-ID" header positioned just after message first line:
SIP/2.0 200 OK
[Call-ID header here]
[rest of the headers]
When "Call-ID" header is positioned down (after a few other headers) it is correctly recognized.
This is due to the data offset used in get_callid function call inside ip_vs_pe_sip.c file: since dptr already points to the start of the SIP message, the value of dataoff should be initially 0. Otherwise the header is searched starting from some bytes after the first character of the SIP message.
--- net/netfilter/ipvs/ip_vs_pe_sip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_pe_sip.c +1 -1
@@ -88,7 +88,7 @@ ip_vs_sip_fill_param(struct ip_vs_conn_p dptr = skb->data + dataoff; datalen = skb->len - dataoff; -if (get_callid (dptr, dataoff, datalen, &matchoff, &matchlen)) +if (get_callid (dptr,0 , datalen, &matchoff, &matchlen))return -EINVAL ;/* N.B: pe_data is only set on success,
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/ipvs-correct-initial-offset-of-call-id-header-search-in-sip-persistence-engine.patch