Skip to contentSkip to conversation

Patch "ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 7, 2016

Subsystems (2)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
arm-cpuidle-pass-on-arm_cpuidle_suspend-s-return-value.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 625fe4f8ffc1b915248558481bb94249f6bd411c Mon Sep 17 00:00:00 2001

From: James Morse <[email protected]>
Date: Tue, 26 Apr 2016 12:15:01 +0100
Subject: ARM: cpuidle: Pass on arm_cpuidle_suspend()'s return value

From: James Morse <[email protected]>

commit 625fe4f8ffc1b915248558481bb94249f6bd411c upstream.

arm_cpuidle_suspend() may return -EOPNOTSUPP, or any value returned by the cpu_ops/cpuidle_ops suspend call. arm_enter_idle_state() doesn't update 'ret' with this value, meaning we always signal success to cpuidle_enter_state(), causing it to update the usage counters as if we succeeded.

Fixes 191de17aa3c1 ("ARM64: cpuidle: Replace cpu_suspend by the common ARM/ARM64 function")
---
 drivers/cpuidle/cpuidle-arm.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpuidle/cpuidle-arm.c +1 -1
@@ -50,7 +50,7 @@ static int arm_enter_idle_state(struct c
 		 * call the CPU ops suspend protocol with idle index as a
 		 * parameter.
 		 */
-		arm_cpuidle_suspend(idx);
+		ret = arm_cpuidle_suspend(idx);
 
 		cpu_pm_exit();
 	}

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/arm-cpuidle-pass-on-arm_cpuidle_suspend-s-return-value.patch