Skip to contentSkip to conversation

Patch "nvmem: mxs-ocotp: fix buffer overflow in read" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 8, 2016

Subsystems (3)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

nvmem: mxs-ocotp: fix buffer overflow in read

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
nvmem-mxs-ocotp-fix-buffer-overflow-in-read.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From d1306eb675ad7a9a760b6b8e8e189824b8db89e7 Mon Sep 17 00:00:00 2001

From: Stanislav Meduna <[email protected]>
Date: Mon, 2 May 2016 16:05:11 +0100
Subject: nvmem: mxs-ocotp: fix buffer overflow in read

From: Stanislav Meduna <[email protected]>

commit d1306eb675ad7a9a760b6b8e8e189824b8db89e7 upstream.

This patch fixes the issue where the mxs_ocotp_read is reading the ocotp in reg_size steps but decrements the remaining size by 1. The number of iterations is thus four times higher, overwriting the area behind the output buffer.

Fixes c01e9a11ab6f ("nvmem: add driver for ocotp in i.MX23 and i.MX28")
---
 drivers/nvmem/mxs-ocotp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/nvmem/mxs-ocotp.c +2 -2
@@ -94,7 +94,7 @@ static int mxs_ocotp_read(void *context,
 	if (ret)
 		goto close_banks;
 
-	while (val_size) {
+	while (val_size >= reg_size) {
 		if ((offset < OCOTP_DATA_OFFSET) || (offset % 16)) {
 			/* fill up non-data register */
 			*buf = 0;
@@ -103,7 +103,7 @@ static int mxs_ocotp_read(void *context,
 		}
 
 		buf++;
-		val_size--;
+		val_size -= reg_size;
 		offset += reg_size;
 	}
 

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/nvmem-mxs-ocotp-fix-buffer-overflow-in-read.patch