Skip to contentSkip to conversation

Patch "spi: pxa2xx: Do not detect number of enabled chip selects on Intel SPT" has been added to the 4.4-stable tree

PATCH [email protected] 1 participant 1 message May 15, 2016

Subsystems (4)
lore
Share & tools
lore

[email protected]

author maintainer Applied
#0 lore raw

This is a note to let you know that I've just added the patch titled

spi: pxa2xx: Do not detect number of enabled chip selects on Intel SPT

to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

The filename of the patch is:
spi-pxa2xx-do-not-detect-number-of-enabled-chip-selects-on-intel-spt.patch
and it can be found in the queue-4.4 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 1 line

From 66ec246eb9982e7eb8e15e1fc55f543230310dd0 Mon Sep 17 00:00:00 2001

From: Jarkko Nikula <[email protected]>
Date: Tue, 26 Apr 2016 10:08:26 +0300
Subject: spi: pxa2xx: Do not detect number of enabled chip selects on Intel SPT

From: Jarkko Nikula <[email protected]>

commit 66ec246eb9982e7eb8e15e1fc55f543230310dd0 upstream.

Certain Intel Sunrisepoint PCH variants report zero chip selects in SPI capabilities register even they have one per port. Detection in pxa2xx_spi_probe() sets master->num_chipselect to 0 leading to -EINVAL from spi_register_master() where chip select count is validated.

Fix this by not using SPI capabilities register on Sunrisepoint. They don't have more than one chip select so use the default value 1 instead of detection.

Fixes 8b136baa5892 ("spi: pxa2xx: Detect number of enabled Intel LPSS SPI chip select signals")
---
 drivers/spi/spi-pxa2xx.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/spi/spi-pxa2xx.c +1 -1
@@ -111,7 +111,7 @@ static const struct lpss_config lpss_pla
 		.reg_general = -1,
 		.reg_ssp = 0x20,
 		.reg_cs_ctrl = 0x24,
-		.reg_capabilities = 0xfc,
+		.reg_capabilities = -1,
 		.rx_threshold = 1,
 		.tx_threshold_lo = 32,
 		.tx_threshold_hi = 56,

Patches currently in stable-queue which might be from [email protected] are

queue-4.4/spi-pxa2xx-do-not-detect-number-of-enabled-chip-selects-on-intel-spt.patch