Patch "perf diff: Fix duplicated output column" has been added to the 4.5-stable tree
Subsystems (2)
This is a note to let you know that I've just added the patch titled
perf diff: Fix duplicated output column
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
perf-diff-fix-duplicated-output-column.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
e9d848cb65d5f6f7731d12bd1b6d994bfdbcc94fMon Sep 17 00:00:00 2001
From: Namhyung Kim <[email protected]>
Date: Tue, 10 May 2016 11:26:24 -0300
Subject: perf diff: Fix duplicated output column
From: Namhyung Kim <[email protected]>
commit e9d848cb65d5f6f7731d12bd1b6d994bfdbcc94f upstream.
The commit b97511c5bc94 ("perf tools: Add overhead/overhead_children keys defaults via string") moved initialization of column headers but it missed to check the sort__mode. As 'perf diff' doesn't call perf_hpp__init(), the setup_overhead() also should not be called.
Before:
# Baseline Delta Children Overhead Shared Object Symbol
# ........ ....... ........ ........ ................... .......................
#
28.48% -28.47% 28.48% 28.48% [kernel.vmlinux ] [k] intel_idle
11.51% -11.47% 11.51% 11.51% libxul.so [.] 0x0000000001a360f7
3.49% -3.49% 3.49% 3.49% [kernel.vmlinux] [k] generic_exec_single
2.91% -2.89% 2.91% 2.91% libdbus-1.so.3.8.11 [.] 0x000000000000cdc2
2.86% -2.85% 2.86% 2.86% libxcb.so.1.1.0 [.] 0x000000000000c890
2.44% -2.39% 2.44% 2.44% [kernel.vmlinux] [k] perf_event_aux_ctxAfter:
# Baseline Delta Shared Object Symbol
# ........ ....... ................... .......................
#
28.48% -28.47% [kernel.vmlinux] [k] intel_idle
11.51% -11.47% libxul.so [.] 0x0000000001a360f7
3.49% -3.49% [kernel.vmlinux] [k] generic_exec_single
2.91% -2.89% libdbus-1.so.3.8.11 [.] 0x000000000000cdc2
2.86% -2.85% libxcb.so.1.1.0 [.] 0x000000000000c890
2.44% -2.39% [kernel.vmlinux] [k] perf_event_aux_ctx--- tools/perf/util/sort.c | 3 +++ 1 file changed, 3 insertions(+)
tools/perf/util/sort.c +3 -0
@@ -2272,6 +2272,9 @@ static char *prefix_if_not_in(const charstatic char *setup_overhead (char *keys) { +if (sort__mode ==SORT_MODE__DIFF ) +return keys; + keys =prefix_if_not_in ("overhead" , keys);if (symbol_conf.cumulate_callchain)
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/perf-diff-fix-duplicated-output-column.patch queue-4.5/tools-lib-traceevent-do-not-reassign-parg-after-collapse_tree.patch