Patch "ipv4/fib: don't warn when primary address is missing if in_dev is dead" has been added to the 4.4-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
ipv4/fib: don't warn when primary address is missing if in_dev is dead
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
ipv4-fib-don-t-warn-when-primary-address-is-missing-if-in_dev-is-dead.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon May 16 11:21:32 PDT 2016
From: Paolo Abeni <[email protected]>
Date: Thu, 21 Apr 2016 22:23:31 +0200
Subject: ipv4/fib: don't warn when primary address is missing if in_dev is dead
From: Paolo Abeni <[email protected]>
[ Upstream commit 391a20333b8393ef2e13014e6e59d192c5594471 ]
After commit fbd40ea0180a ("ipv4: Don't do expensive useless work during inetdev destroy.") when deleting an interface, fib_del_ifaddr() can be executed without any primary address present on the dead interface.
The above is safe, but triggers some "bug: prim == NULL" warnings.
This commit avoids warning if the in_dev is dead
--- net/ipv4/fib_frontend.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
net/ipv4/fib_frontend.c +5 -1
@@ -904,7 +904,11 @@ void fib_del_ifaddr(struct in_ifaddr *ifif (ifa->ifa_flags &IFA_F_SECONDARY ) { prim =inet_ifa_byprefix (in_dev, any, ifa->ifa_mask);if (!prim) { -pr_warn ("%s: bug: prim == NULL\n" , __func__); +/* if the device has been deleted, we don't perform +* address promotion +*/ +if (!in_dev->dead) +pr_warn ("%s: bug: prim == NULL\n" , __func__);return ; }if (iprim && iprim != prim) {
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/ipv4-fib-don-t-warn-when-primary-address-is-missing-if-in_dev-is-dead.patch queue-4.4/net-route-enforce-hoplimit-max-value.patch