Patch "net/mlx4_en: Fix endianness bug in IPV6 csum calculation" has been added to the 4.4-stable tree
Subsystems (4)
This is a note to let you know that I've just added the patch titled
net/mlx4_en: Fix endianness bug in IPV6 csum calculation
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
net-mlx4_en-fix-endianness-bug-in-ipv6-csum-calculation.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From foo@baz Mon May 16 11:21:32 PDT 2016
From: Daniel Jurgens <[email protected]>
Date: Wed, 4 May 2016 15:00:33 +0300
Subject: net/mlx4_en: Fix endianness bug in IPV6 csum calculation
From: Daniel Jurgens <[email protected]>
[ Upstream commit 82d69203df634b4dfa765c94f60ce9482bcc44d6 ]
Use htons instead of unconditionally byte swapping nexthdr. On a little endian systems shifting the byte is correct behavior, but it results in incorrect csums on big endian architectures.
--- drivers/net/ethernet/mellanox/mlx4/en_rx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/ethernet/mellanox/mlx4/en_rx.c +1 -1
@@ -704,7 +704,7 @@ static int get_fixed_ipv6_csum(__wsum hwif (ipv6h->nexthdr ==IPPROTO_FRAGMENT || ipv6h->nexthdr ==IPPROTO_HOPOPTS )return -1 ; - hw_checksum =csum_add (hw_checksum, (__force __wsum)(ipv6h->nexthdr <<8 )); + hw_checksum =csum_add (hw_checksum, (__force __wsum )htons (ipv6h->nexthdr)); csum_pseudo_hdr =csum_partial (&ipv6h->saddr,sizeof (ipv6h->saddr) +sizeof (ipv6h->daddr),0 );
Patches currently in stable-queue which might be from [email protected] are
queue-4.4/net-mlx4_en-fix-endianness-bug-in-ipv6-csum-calculation.patch