Patch "Revert "drm/i915: start adding dp mst audio"" has been added to the 4.5-stable tree
Subsystems (3)
This is a note to let you know that I've just added the patch titled
Revert "drm/i915: start adding dp mst audio"
to the 4.5-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
revert-drm-i915-start-adding-dp-mst-audio.patch
and it can be found in the queue-4.5 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.
Quoted 1 line
From
26792526cc3e29e3ccbc15c996beb61fa64be5afMon Sep 17 00:00:00 2001
From: Lyude <[email protected]>
Date: Tue, 3 May 2016 11:01:32 -0400
Subject: Revert "drm/i915: start adding dp mst audio"
From: Lyude <[email protected]>
commit 26792526cc3e29e3ccbc15c996beb61fa64be5af upstream.
Right now MST audio is causing too many kernel panics to really keep around in the kernel. On top of that, even after fixing said panics it's still basically non-functional (at least on all the setups I've tested it on). Revert until we have a proper solution for this.
This reverts commit 3d52ccf52f2c51f613e42e65be0f06e4e6788093.
--- drivers/gpu/drm/i915/i915_debugfs.c | 16 ---------------- drivers/gpu/drm/i915/intel_audio.c | 9 +++------ drivers/gpu/drm/i915/intel_ddi.c | 24 +++++------------------- drivers/gpu/drm/i915/intel_dp_mst.c | 22 ---------------------- drivers/gpu/drm/i915/intel_drv.h | 2 -- 5 files changed, 8 insertions(+), 65 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +0 -16
@@ -2860,20 +2860,6 @@ static void intel_dp_info(struct seq_filintel_panel_info (m, &intel_connector->panel); } -static void intel_dp_mst_info (struct seq_file *m, -struct intel_connector *intel_connector) -{ -struct intel_encoder *intel_encoder = intel_connector->encoder; -struct intel_dp_mst_encoder *intel_mst = -enc_to_mst (&intel_encoder->base); -struct intel_digital_port *intel_dig_port = intel_mst->primary; -struct intel_dp *intel_dp = &intel_dig_port->dp; -bool has_audio =drm_dp_mst_port_has_audio (&intel_dp->mst_mgr, - intel_connector->port); - -seq_printf (m,"\taudio support: %s\n" ,yesno (has_audio)); -} -static void intel_hdmi_info (struct seq_file *m,struct intel_connector *intel_connector) {
@@ -2917,8 +2903,6 @@ static void intel_connector_info(structintel_hdmi_info (m, intel_connector); else if (intel_encoder->type == INTEL_OUTPUT_LVDS) intel_lvds_info(m, intel_connector); - else if (intel_encoder->type == INTEL_OUTPUT_DP_MST) - intel_dp_mst_info(m, intel_connector); }seq_printf (m,"\tmodes:\n" );
drivers/gpu/drm/i915/intel_audio.c +3 -6
@@ -262,8 +262,7 @@ static void hsw_audio_codec_disable(stru tmp |=AUD_CONFIG_N_PROG_ENABLE ; tmp &= ~AUD_CONFIG_UPPER_N_MASK ; tmp &= ~AUD_CONFIG_LOWER_N_MASK ; -if (intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DISPLAYPORT ) || -intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DP_MST )) +if (intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DISPLAYPORT )) tmp |=AUD_CONFIG_N_VALUE_INDEX ;I915_WRITE (HSW_AUD_CFG (pipe), tmp);
@@ -476,8 +475,7 @@ static void ilk_audio_codec_enable(struc tmp &= ~AUD_CONFIG_N_VALUE_INDEX ; tmp &= ~AUD_CONFIG_N_PROG_ENABLE ; tmp &= ~AUD_CONFIG_PIXEL_CLOCK_HDMI_MASK ; -if (intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DISPLAYPORT ) || -intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DP_MST )) +if (intel_pipe_has_type (intel_crtc,INTEL_OUTPUT_DISPLAYPORT )) tmp |=AUD_CONFIG_N_VALUE_INDEX ;else tmp |=audio_config_hdmi_pixel_clock (adjusted_mode);
@@ -515,8 +513,7 @@ void intel_audio_codec_enable(struct int/* ELD Conn_Type */ connector->eld[5 ] &= ~(3 <<2 ); -if (intel_pipe_has_type (crtc,INTEL_OUTPUT_DISPLAYPORT ) || -intel_pipe_has_type (crtc,INTEL_OUTPUT_DP_MST )) +if (intel_pipe_has_type (crtc,INTEL_OUTPUT_DISPLAYPORT )) connector->eld[5 ] |= (1 <<2 ); connector->eld[6 ] =drm_av_sync_delay (connector, adjusted_mode) /2 ;
drivers/gpu/drm/i915/intel_ddi.c +5 -19
@@ -3165,23 +3165,6 @@ void intel_ddi_fdi_disable(struct drm_crI915_WRITE (FDI_RX_CTL (PIPE_A ), val); } -bool intel_ddi_is_audio_enabled (struct drm_i915_private *dev_priv, -struct intel_crtc *intel_crtc) -{ -u32 temp; - -if (intel_display_power_get_if_enabled (dev_priv,POWER_DOMAIN_AUDIO )) { - temp =I915_READ (HSW_AUD_PIN_ELD_CP_VLD ); - -intel_display_power_put (dev_priv,POWER_DOMAIN_AUDIO ); - -if (temp &AUDIO_OUTPUT_ENABLE (intel_crtc->pipe)) -return true; - } - -return false; -} -void intel_ddi_get_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config) {
@@ -3242,8 +3225,11 @@ void intel_ddi_get_config(struct intel_ebreak ; } - pipe_config->has_audio = -intel_ddi_is_audio_enabled (dev_priv, intel_crtc); +if (intel_display_power_is_enabled (dev_priv,POWER_DOMAIN_AUDIO )) { + temp =I915_READ (HSW_AUD_PIN_ELD_CP_VLD ); +if (temp &AUDIO_OUTPUT_ENABLE (intel_crtc->pipe)) + pipe_config->has_audio = true; + }if (encoder->type ==INTEL_OUTPUT_EDP && dev_priv->vbt.edp_bpp && pipe_config->pipe_bpp > dev_priv->vbt.edp_bpp) {
drivers/gpu/drm/i915/intel_dp_mst.c +0 -22
@@ -78,8 +78,6 @@ static bool intel_dp_mst_compute_config(return false; } -if (drm_dp_mst_port_has_audio (&intel_dp->mst_mgr, found->port)) - pipe_config->has_audio = true; mst_pbn =drm_dp_calc_pbn_mode (adjusted_mode->crtc_clock, bpp); pipe_config->pbn = mst_pbn;
@@ -104,11 +102,6 @@ static void intel_mst_disable_dp(structstruct intel_dp_mst_encoder *intel_mst =enc_to_mst (&encoder->base);struct intel_digital_port *intel_dig_port = intel_mst->primary;struct intel_dp *intel_dp = &intel_dig_port->dp; -struct drm_device *dev = encoder->base.dev; -struct drm_i915_private *dev_priv = dev->dev_private; -struct drm_crtc *crtc = encoder->base.crtc; -struct intel_crtc *intel_crtc =to_intel_crtc (crtc); -int ret;DRM_DEBUG_KMS ("%d\n" , intel_dp->active_mst_links);
@@ -119,10 +112,6 @@ static void intel_mst_disable_dp(structif (ret) {DRM_ERROR ("failed to update payload %d\n" , ret); } -if (intel_crtc->config->has_audio) { -intel_audio_codec_disable (encoder); -intel_display_power_put (dev_priv,POWER_DOMAIN_AUDIO ); - } }static void intel_mst_post_disable_dp (struct intel_encoder *encoder)
@@ -219,7 +208,6 @@ static void intel_mst_enable_dp(struct istruct intel_dp *intel_dp = &intel_dig_port->dp;struct drm_device *dev = intel_dig_port->base.base.dev;struct drm_i915_private *dev_priv = dev->dev_private; -struct intel_crtc *crtc =to_intel_crtc (encoder->base.crtc);enum port port = intel_dig_port->port;int ret;
@@ -232,13 +220,6 @@ static void intel_mst_enable_dp(struct i ret =drm_dp_check_act_status (&intel_dp->mst_mgr); ret =drm_dp_update_payload_part2 (&intel_dp->mst_mgr); - -if (crtc->config->has_audio) { -DRM_DEBUG_DRIVER ("Enabling DP audio on pipe %c\n" , -pipe_name (crtc->pipe)); -intel_display_power_get (dev_priv,POWER_DOMAIN_AUDIO ); -intel_audio_codec_enable (encoder); - } } static bool intel_dp_mst_enc_get_hw_state(struct intel_encoder *encoder,
@@ -264,9 +245,6 @@ static void intel_dp_mst_enc_get_config( pipe_config->has_dp_encoder = true; - pipe_config->has_audio = -intel_ddi_is_audio_enabled (dev_priv, crtc); - temp =I915_READ (TRANS_DDI_FUNC_CTL (cpu_transcoder));if (temp &TRANS_DDI_PHSYNC ) flags |=DRM_MODE_FLAG_PHSYNC ;
drivers/gpu/drm/i915/intel_drv.h +0 -2
@@ -1013,8 +1013,6 @@ void intel_ddi_set_pipe_settings(structvoid intel_ddi_prepare_link_retrain (struct intel_dp *intel_dp);bool intel_ddi_connector_get_hw_state (struct intel_connector *intel_connector);void intel_ddi_fdi_disable (struct drm_crtc *crtc); -bool intel_ddi_is_audio_enabled (struct drm_i915_private *dev_priv, -struct intel_crtc *intel_crtc);void intel_ddi_get_config (struct intel_encoder *encoder,struct intel_crtc_state *pipe_config); struct intel_encoder *
Patches currently in stable-queue which might be from [email protected] are
queue-4.5/revert-drm-i915-start-adding-dp-mst-audio.patch